You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cloudstack.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/08/17 14:41:45 UTC
[jira] [Commented] (CLOUDSTACK-8736) Refactor network code
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14699473#comment-14699473 ]
ASF GitHub Bot commented on CLOUDSTACK-8736:
--------------------------------------------
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/705
Refactored NicProfile.java for readability.
Only changed names and reorganized them! No functional implementation change.
See issue CLOUDSTACK-8736 for ongoing effort to clean up network code.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/borisroman/cloudstack CLOUDSTACK-8736
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/705.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #705
----
commit 5db337184057193001056f46e178836e6be2d6fd
Author: Boris Schrijver <bo...@pcextreme.nl>
Date: 2015-08-17T12:12:10Z
Refactored NicProfile.java for readability.
See issue CLOUDSTACK-8736 for ongoing effort to clean up network code.
----
> Refactor network code
> ---------------------
>
> Key: CLOUDSTACK-8736
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8736
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the default.)
> Components: Network Controller, Network Devices
> Reporter: Boris Schrijver
> Assignee: Boris Schrijver
> Priority: Minor
>
> Over the years after many code additions, change and/or removals the network code has become obfuscated. Multiple getters/setters exist for the same variable, order and structure is missing, variable naming is not consistent, no clear difference exists between IPv4 and IPv6 code, and so on.
> This ticket exist to be referenced to by PRs which includes refactors of network classes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)