You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2021/07/29 02:44:40 UTC

[GitHub] [incubator-shenyu] 0x12FD16B opened a new issue #1827: shenyu-common module test coverage improvement

0x12FD16B opened a new issue #1827:
URL: https://github.com/apache/incubator-shenyu/issues/1827


   ## Task
   
   Writing junit test case to impove shenyu-common module test coverage. Each task has been marked the classes that should be appended test code, if not specify, there are current code test coverage at end of line of each class. We hope the code test coverage can be improved to 85% above (the key logic code to 95%).
   
   Task List:
   
   - [ ] task1: impove the follow classes code test coverage
   	org.apache.shenyu.common.healthcheck.HealthCheckTask(0%)
   - [ ] task2: impove the follow classes code test coverage
   	org.apache.shenyu.common.enums.RpcTypeEnum(0%)
   	org.apache.shenyu.common.enums.RpcTypeEnum(0%)
   	org.apache.shenyu.common.enums.RateLimitEnum(0%)
   	org.apache.shenyu.common.enums.AdminPluginOperateEnum(0%)
   	org.apache.shenyu.common.enums.AdminResourceEnum(0%)
   	org.apache.shenyu.common.enums.PluginTypeEnum(0%)
   	org.apache.shenyu.common.enums.WafEnum(0%)
   	org.apache.shenyu.common.enums.ParamTypeEnum(line coverage 100%, key branch coverage missing 25%)
   	org.apache.shenyu.common.enums.HttpMethodEnum(line coverage 100%, key branch coverage missing 25%)
   - [ ] task3: impove the follow classes code test coverage
   	org.apache.shenyu.common.dto.convert.Resilience4JHandle(0%)
   	org.apache.shenyu.common.dto.convert.SentinelHandle(0%)
   	org.apache.shenyu.common.dto.convert.RequestHandle(0%)
   	org.apache.shenyu.common.dto.convert.HystrixHandle(0%)
   	org.apache.shenyu.common.dto.convert.RequestHandle.ShenyuRequestParameter(0%)
   	org.apache.shenyu.common.dto.convert.RequestHandle.ShenyuCookie(0%)
   	org.apache.shenyu.common.dto.convert.RequestHandle.ShenyuRequestHeader(0%)
   	org.apache.shenyu.common.dto.convert.HystrixThreadPoolConfig(0%)
   	org.apache.shenyu.common.dto.convert.ZombieUpstream(0%)
   	org.apache.shenyu.common.dto.convert.rule.RuleHandle(0%)
   - [ ] task4: impove the follow classes code test coverage
   	org.apache.shenyu.common.utils.ReflectUtils(64%)
   	org.apache.shenyu.common.utils.GsonUtils(86%)
   - [ ] task5: impove the follow classes code test coverage
   	org.apache.shenyu.common.constant.HttpConstants(0%)
   	org.apache.shenyu.common.constant.AdminConstants(0%)
   	org.apache.shenyu.common.constant.ConsulConstants(0%)
   	org.apache.shenyu.common.constant.ResourceTypeConstants(0%)
   	org.apache.shenyu.common.constant.RuleHandleConstants(50%)
   	org.apache.shenyu.common.constant.DubboParamConstants(0%)
   	org.apache.shenyu.common.constant.NacosPathConstants(0%)
   - [ ] task6: impove the follow classes code test coverage
   	org.apache.shenyu.common.exception.SerializerException(0%)
   	org.apache.shenyu.common.exception.ShenyuException(30%)
   	org.apache.shenyu.common.exception.CommonErrorCode(0%)
   - [ ] task7: impove the follow classes code test coverage
   	org.apache.shenyu.common.dto.MetaData(0%)
   	org.apache.shenyu.common.dto.ConfigData(0%)
   	org.apache.shenyu.common.dto.convert.rule.impl.ModifyResponseRuleHandle(0%)
   	org.apache.shenyu.common.dto.convert.rule.impl.ContextMappingHandle(0%)
   	org.apache.shenyu.common.dto.convert.rule.impl.ParamMappingHandle(0%)
   
   Please read the [Contribution Guideline](https://shenyu.apache.org/community/contributor/) before submitting the PR
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-shenyu] Technoboy- commented on issue #1827: shenyu-common module test coverage improvement

Posted by GitBox <gi...@apache.org>.
Technoboy- commented on issue #1827:
URL: https://github.com/apache/incubator-shenyu/issues/1827#issuecomment-889570054


   > Sorry, the company has added important tasks for the time being. There is no time to deal with them for the time being
   
   Please assign to me, @yu199195 .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-shenyu] lahmXu commented on issue #1827: shenyu-common module test coverage improvement

Posted by GitBox <gi...@apache.org>.
lahmXu commented on issue #1827:
URL: https://github.com/apache/incubator-shenyu/issues/1827#issuecomment-888764022


   i wanna take task3,pls assign to me


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-shenyu] hhj0719 commented on issue #1827: shenyu-common module test coverage improvement

Posted by GitBox <gi...@apache.org>.
hhj0719 commented on issue #1827:
URL: https://github.com/apache/incubator-shenyu/issues/1827#issuecomment-888764092


   task1: impove the follow classes code test coverage assign to me


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-shenyu] yu199195 closed issue #1827: shenyu-common module test coverage improvement

Posted by GitBox <gi...@apache.org>.
yu199195 closed issue #1827:
URL: https://github.com/apache/incubator-shenyu/issues/1827


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-shenyu] lahmXu commented on issue #1827: shenyu-common module test coverage improvement

Posted by GitBox <gi...@apache.org>.
lahmXu commented on issue #1827:
URL: https://github.com/apache/incubator-shenyu/issues/1827#issuecomment-894669460


   I have finished the task3, please mark it @0x12FD16B 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-shenyu] hhj0719 commented on issue #1827: shenyu-common module test coverage improvement

Posted by GitBox <gi...@apache.org>.
hhj0719 commented on issue #1827:
URL: https://github.com/apache/incubator-shenyu/issues/1827#issuecomment-889134334


   Sorry, the company has added important tasks for the time being. There is no time to deal with them for the time being


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-shenyu] changanjennifer commented on issue #1827: shenyu-common module test coverage improvement

Posted by GitBox <gi...@apache.org>.
changanjennifer commented on issue #1827:
URL: https://github.com/apache/incubator-shenyu/issues/1827#issuecomment-888790089


   I wanna take task 4 or task 2,  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-shenyu] yu199195 commented on issue #1827: shenyu-common module test coverage improvement

Posted by GitBox <gi...@apache.org>.
yu199195 commented on issue #1827:
URL: https://github.com/apache/incubator-shenyu/issues/1827#issuecomment-888772276


   Hi, 
   
   You can reply to the communication on the mailing list : 
   https://lists.apache.org/thread.html/r5c090356c793ad0bd7ada2dd51a76451580a1d583033ed0e97a472ec%40%3Cdev.shenyu.apache.org%3E 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-shenyu] Banana1995 commented on issue #1827: shenyu-common module test coverage improvement

Posted by GitBox <gi...@apache.org>.
Banana1995 commented on issue #1827:
URL: https://github.com/apache/incubator-shenyu/issues/1827#issuecomment-888763753


   i wanna take task2,pls assign to me


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-shenyu] ywj1352 commented on issue #1827: shenyu-common module test coverage improvement

Posted by GitBox <gi...@apache.org>.
ywj1352 commented on issue #1827:
URL: https://github.com/apache/incubator-shenyu/issues/1827#issuecomment-888763236


   task4: impove the follow classes code test coverage  assign me


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-shenyu] yu199195 commented on issue #1827: shenyu-common module test coverage improvement

Posted by GitBox <gi...@apache.org>.
yu199195 commented on issue #1827:
URL: https://github.com/apache/incubator-shenyu/issues/1827#issuecomment-889586659


   @Technoboy-   thanks for help


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org