You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/04/13 22:06:13 UTC
[GitHub] [tvm] tkonolige opened a new pull request #7841: [FIX] Fix howto_deploy
tkonolige opened a new pull request #7841:
URL: https://github.com/apache/tvm/pull/7841
We were missing files in tvm_runtime_pack.cc.
Manually packing the runtime files has led to many issues when adding new features. We should probably figure out a better way to do it.
@tqchen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen merged pull request #7841: [FIX] Fix howto_deploy
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #7841:
URL: https://github.com/apache/tvm/pull/7841
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tkonolige commented on a change in pull request #7841: [FIX] Fix howto_deploy
Posted by GitBox <gi...@apache.org>.
tkonolige commented on a change in pull request #7841:
URL: https://github.com/apache/tvm/pull/7841#discussion_r613390423
##########
File path: apps/howto_deploy/tvm_runtime_pack.cc
##########
@@ -37,7 +37,9 @@
* You need to remember to change it to point to the right file.
*
*/
+#define TVM_USE_LIBBACKTRACE 0
Review comment:
yes, because we aren't linking to libbacktrace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] yzh119 commented on a change in pull request #7841: [FIX] Fix howto_deploy
Posted by GitBox <gi...@apache.org>.
yzh119 commented on a change in pull request #7841:
URL: https://github.com/apache/tvm/pull/7841#discussion_r612883991
##########
File path: apps/howto_deploy/tvm_runtime_pack.cc
##########
@@ -37,7 +37,9 @@
* You need to remember to change it to point to the right file.
*
*/
+#define TVM_USE_LIBBACKTRACE 0
Review comment:
Is it necessary to disable libbacktrace?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] yzh119 commented on a change in pull request #7841: [FIX] Fix howto_deploy
Posted by GitBox <gi...@apache.org>.
yzh119 commented on a change in pull request #7841:
URL: https://github.com/apache/tvm/pull/7841#discussion_r613403916
##########
File path: apps/howto_deploy/tvm_runtime_pack.cc
##########
@@ -37,7 +37,9 @@
* You need to remember to change it to point to the right file.
*
*/
+#define TVM_USE_LIBBACKTRACE 0
Review comment:
That makes sense to me, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org