You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org> on 2023/08/08 13:54:06 UTC
[Impala-ASF-CR] IMPALA-10829: Fix leak in KuduPartitionExpr::CloseEvaluator()
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20330
Change subject: IMPALA-10829: Fix leak in KuduPartitionExpr::CloseEvaluator()
......................................................................
IMPALA-10829: Fix leak in KuduPartitionExpr::CloseEvaluator()
KuduPartitionExpr::CloseEvaluator() didn't call the base class's
CloseEvaluator() which led to not closing its child expressions
recursively.
Testing:
- added a regression test
Change-Id: Ifcf35721e16ba780d01c19e916d58fb2e77a0836
---
M be/src/exprs/kudu-partition-expr.cc
M testdata/workloads/functional-query/queries/QueryTest/kudu_insert.test
2 files changed, 22 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/20330/1
--
To view, visit http://gerrit.cloudera.org:8080/20330
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifcf35721e16ba780d01c19e916d58fb2e77a0836
Gerrit-Change-Number: 20330
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
[Impala-ASF-CR] IMPALA-10829: Fix leak in KuduPartitionExpr::CloseEvaluator()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20330 )
Change subject: IMPALA-10829: Fix leak in KuduPartitionExpr::CloseEvaluator()
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9578/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/20330
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcf35721e16ba780d01c19e916d58fb2e77a0836
Gerrit-Change-Number: 20330
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 09 Aug 2023 00:35:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10829: Fix leak in KuduPartitionExpr::CloseEvaluator()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20330 )
Change subject: IMPALA-10829: Fix leak in KuduPartitionExpr::CloseEvaluator()
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/20330
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcf35721e16ba780d01c19e916d58fb2e77a0836
Gerrit-Change-Number: 20330
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 09 Aug 2023 04:52:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10829: Fix leak in KuduPartitionExpr::CloseEvaluator()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20330 )
Change subject: IMPALA-10829: Fix leak in KuduPartitionExpr::CloseEvaluator()
......................................................................
IMPALA-10829: Fix leak in KuduPartitionExpr::CloseEvaluator()
KuduPartitionExpr::CloseEvaluator() didn't call the base class's
CloseEvaluator() which led to not closing its child expressions
recursively.
Testing:
- added a regression test
Change-Id: Ifcf35721e16ba780d01c19e916d58fb2e77a0836
Reviewed-on: http://gerrit.cloudera.org:8080/20330
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/exprs/kudu-partition-expr.cc
M testdata/workloads/functional-query/queries/QueryTest/kudu_insert.test
2 files changed, 12 insertions(+), 0 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/20330
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifcf35721e16ba780d01c19e916d58fb2e77a0836
Gerrit-Change-Number: 20330
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-10829: Fix leak in KuduPartitionExpr::CloseEvaluator()
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/20330 )
Change subject: IMPALA-10829: Fix leak in KuduPartitionExpr::CloseEvaluator()
......................................................................
IMPALA-10829: Fix leak in KuduPartitionExpr::CloseEvaluator()
KuduPartitionExpr::CloseEvaluator() didn't call the base class's
CloseEvaluator() which led to not closing its child expressions
recursively.
Testing:
- added a regression test
Change-Id: Ifcf35721e16ba780d01c19e916d58fb2e77a0836
---
M be/src/exprs/kudu-partition-expr.cc
M testdata/workloads/functional-query/queries/QueryTest/kudu_insert.test
2 files changed, 12 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/20330/2
--
To view, visit http://gerrit.cloudera.org:8080/20330
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifcf35721e16ba780d01c19e916d58fb2e77a0836
Gerrit-Change-Number: 20330
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
[Impala-ASF-CR] IMPALA-10829: Fix leak in KuduPartitionExpr::CloseEvaluator()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20330 )
Change subject: IMPALA-10829: Fix leak in KuduPartitionExpr::CloseEvaluator()
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/13721/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/20330
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcf35721e16ba780d01c19e916d58fb2e77a0836
Gerrit-Change-Number: 20330
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 08 Aug 2023 14:18:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10829: Fix leak in KuduPartitionExpr::CloseEvaluator()
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20330 )
Change subject: IMPALA-10829: Fix leak in KuduPartitionExpr::CloseEvaluator()
......................................................................
Patch Set 2: Code-Review+2
LGTM. Thanks for fixing this!
--
To view, visit http://gerrit.cloudera.org:8080/20330
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcf35721e16ba780d01c19e916d58fb2e77a0836
Gerrit-Change-Number: 20330
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 09 Aug 2023 00:34:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10829: Fix leak in KuduPartitionExpr::CloseEvaluator()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20330 )
Change subject: IMPALA-10829: Fix leak in KuduPartitionExpr::CloseEvaluator()
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20330
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcf35721e16ba780d01c19e916d58fb2e77a0836
Gerrit-Change-Number: 20330
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 09 Aug 2023 00:35:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10829: Fix leak in KuduPartitionExpr::CloseEvaluator()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20330 )
Change subject: IMPALA-10829: Fix leak in KuduPartitionExpr::CloseEvaluator()
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/13720/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/20330
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcf35721e16ba780d01c19e916d58fb2e77a0836
Gerrit-Change-Number: 20330
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 08 Aug 2023 14:17:19 +0000
Gerrit-HasComments: No