[shardingsphere] branch master updated: Refactor HandleConfigurationTest (#16947)

[du...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

duanzhengqiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 56310fc80d0 Refactor HandleConfigurationTest (#16947)
56310fc80d0 is described below

commit 56310fc80d0d5fd94566b6ed67e5a09ae93ae8c4
Author: Liang Zhang <zh...@apache.org>
AuthorDate: Wed Apr 20 14:08:56 2022 +0800

    Refactor HandleConfigurationTest (#16947)
---
 .../rulealtered/HandleConfigurationTest.java       | 49 ++++++++++------------
 1 file changed, 21 insertions(+), 28 deletions(-)

diff --git a/shardingsphere-kernel/shardingsphere-data-pipeline/shardingsphere-data-pipeline-spi/src/test/java/org/apache/shardingsphere/data/pipeline/api/config/rulealtered/HandleConfigurationTest.java b/shardingsphere-kernel/shardingsphere-data-pipeline/shardingsphere-data-pipeline-spi/src/test/java/org/apache/shardingsphere/data/pipeline/api/config/rulealtered/HandleConfigurationTest.java
index 6312806c625..8b51502ad7a 100644
--- a/shardingsphere-kernel/shardingsphere-data-pipeline/shardingsphere-data-pipeline-spi/src/test/java/org/apache/shardingsphere/data/pipeline/api/config/rulealtered/HandleConfigurationTest.java
+++ b/shardingsphere-kernel/shardingsphere-data-pipeline/shardingsphere-data-pipeline-spi/src/test/java/org/apache/shardingsphere/data/pipeline/api/config/rulealtered/HandleConfigurationTest.java
@@ -20,50 +20,43 @@ package org.apache.shardingsphere.data.pipeline.api.config.rulealtered;
 import com.google.common.collect.Lists;
 import org.junit.Test;
 
+import java.util.Arrays;
+
 import static org.hamcrest.CoreMatchers.is;
 import static org.junit.Assert.assertThat;
 
 public final class HandleConfigurationTest {
-
-    private static final String TABLE_NAME_1 = "tableName1";
-
-    private static final String TABLE_NAME_2 = "tableName2";
-
-    private static final String TABLE_NAME = "tableName1,tableName2";
-
+    
     @Test
     public void assertGetJobShardingCountByNull() {
-        HandleConfiguration handleConfiguration = new HandleConfiguration();
-        handleConfiguration.getJobShardingCount();
-        assertThat(handleConfiguration.getJobShardingCount(), is(0));
+        assertThat(new HandleConfiguration().getJobShardingCount(), is(0));
     }
-
+    
     @Test
     public void assertGetJobShardingCount() {
-        HandleConfiguration handleConfiguration = new HandleConfiguration();
-        handleConfiguration.setJobShardingDataNodes(Lists.newArrayList("node1", "node2"));
-        handleConfiguration.getJobShardingCount();
-        assertThat(handleConfiguration.getJobShardingCount(), is(2));
+        HandleConfiguration handleConfig = new HandleConfiguration();
+        handleConfig.setJobShardingDataNodes(Arrays.asList("node1", "node2"));
+        assertThat(handleConfig.getJobShardingCount(), is(2));
     }
-
+    
     @Test
     public void assertSplitLogicTableNames() {
-        HandleConfiguration handleConfiguration = new HandleConfiguration();
-        handleConfiguration.setLogicTables(TABLE_NAME);
-        assertThat(handleConfiguration.splitLogicTableNames(), is(Lists.newArrayList(TABLE_NAME_1, TABLE_NAME_2)));
+        HandleConfiguration handleConfig = new HandleConfiguration();
+        handleConfig.setLogicTables("foo_tbl,bar_tbl");
+        assertThat(handleConfig.splitLogicTableNames(), is(Lists.newArrayList("foo_tbl", "bar_tbl")));
     }
-
+    
     @Test
-    public void assertGetJobIdDigestBySuperLong() {
-        HandleConfiguration handleConfiguration = new HandleConfiguration();
-        handleConfiguration.setJobId("jobIdExceed");
-        assertThat(handleConfiguration.getJobIdDigest(), is("jobIdE"));
+    public void assertGetJobIdDigestByLongName() {
+        HandleConfiguration handleConfig = new HandleConfiguration();
+        handleConfig.setJobId("abcdefg");
+        assertThat(handleConfig.getJobIdDigest(), is("abcdef"));
     }
-
+    
     @Test
-    public void assertGetJobIdDigest() {
+    public void assertGetJobIdDigestByShortName() {
         HandleConfiguration handleConfiguration = new HandleConfiguration();
-        handleConfiguration.setJobId("jobId");
-        assertThat(handleConfiguration.getJobIdDigest(), is("jobId"));
+        handleConfiguration.setJobId("abcdef");
+        assertThat(handleConfiguration.getJobIdDigest(), is("abcdef"));
     }
 }