You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "summaryzb (via GitHub)" <gi...@apache.org> on 2023/10/09 18:20:19 UTC
[PR] improvement: Refactor the writer code with builder pattern [incubator-uniffle]
summaryzb opened a new pull request, #1228:
URL: https://github.com/apache/incubator-uniffle/pull/1228
### What changes were proposed in this pull request?
As the title
### Why are the changes needed?
https://github.com/apache/incubator-uniffle/issues/1091
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] improvement: Refactor the writer code with builder pattern [incubator-uniffle]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1228:
URL: https://github.com/apache/incubator-uniffle/pull/1228#issuecomment-1753472694
## [Codecov](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1228?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#1228](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1228?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (2854899) into [master](https://app.codecov.io/gh/apache/incubator-uniffle/commit/6bfbbc2c3f9aef5ac2bf7c59e84baf7f2ffdddd3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (6bfbbc2) will **increase** coverage by `2.02%`.
> The diff coverage is `82.81%`.
```diff
@@ Coverage Diff @@
## master #1228 +/- ##
============================================
+ Coverage 53.48% 55.50% +2.02%
+ Complexity 2613 2138 -475
============================================
Files 395 326 -69
Lines 22584 14369 -8215
Branches 1930 1323 -607
============================================
- Hits 12078 7976 -4102
+ Misses 9771 5947 -3824
+ Partials 735 446 -289
```
| [Files](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1228?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/uniffle/client/factory/ShuffleClientFactory.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1228?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NsaWVudC9mYWN0b3J5L1NodWZmbGVDbGllbnRGYWN0b3J5LmphdmE=) | `65.57% <88.63%> (+65.57%)` | :arrow_up: |
| [...he/uniffle/client/impl/ShuffleWriteClientImpl.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1228?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NsaWVudC9pbXBsL1NodWZmbGVXcml0ZUNsaWVudEltcGwuamF2YQ==) | `35.05% <70.00%> (-0.74%)` | :arrow_down: |
... and [73 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1228/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1091] refactor: Refactor the writer code with builder pattern [incubator-uniffle]
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi merged PR #1228:
URL: https://github.com/apache/incubator-uniffle/pull/1228
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org