You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2021/01/12 05:11:15 UTC
[GitHub] [incubator-gobblin] chris9692 opened a new pull request #3198: GOBBLIN-1225 Multistage Generic Connector for HTTP Protocol and JSON Format
chris9692 opened a new pull request #3198:
URL: https://github.com/apache/incubator-gobblin/pull/3198
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [X] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1225
### Description
- [X] Here are some details about my PR, including screenshots (if applicable):
Many HTTP data sources, including OData and GraphQL based data sources, use a set of common HTTP request methods,
but their parameters can vary significantly case by case. The Gobblin ecosystem has multiple connectors that were
built to suite those needs, for example, the Salesforce connector, the Google Search Console connector, etc.
Multistage connector framework is a paradigm that makes connectors more generic and more reusable. We have used this framework to address the huge variety challenge in data integration with external data sources.
HTTP data sources are the top beneficiary of this framework, including Rest API, OData, and SOAP based data sources. S3 and GCS (Google Cloud Storage) data sources can also benefit from it in small data volumes that are less than 10TB, without using SDK.
We have also verified the HTTP Multistage connector can greatly simplify data ingestion from Salesforce.com. However, this PR doesn't included the necessary component, CSV Extractor, yet.
This PR includes following functionalities:
- This PR contains a separate multistage module that works with HTTP data sources
- It supports HTTP GET, PUT, POST, and DELETE operations
- It supports nested JSON format
- It supports Rest API calls and its derived OData service
- It supports following ways of pagination
○ By offset and page size
○ By page number
○ By a total record count
○ By signal of an empty response
○ By next page URL
○ By a cursor or next page locator
- It supports session state control as a mechanism of pagination or asynchronous requests
- It supports pulling files from GCS or S3 via HTTP requests
- It supports field project, including nested field projection, based on a given schema
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
All 113 unit tests were successful.
### Commits
- [X] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 ##characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] codecov-io commented on pull request #3198: GOBBLIN-1225 Multistage Generic Connector for HTTP Protocol and JSON Format
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #3198:
URL: https://github.com/apache/incubator-gobblin/pull/3198#issuecomment-758532213
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3198?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@5be1702`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3198?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3198 +/- ##
========================================
Coverage ? 8.87%
Complexity ? 1737
========================================
Files ? 2054
Lines ? 80050
Branches ? 9085
========================================
Hits ? 7108
Misses ? 72247
Partials ? 695
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3198?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3198?src=pr&el=footer). Last update [5be1702...0250bc5](https://codecov.io/gh/apache/incubator-gobblin/pull/3198?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org