You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/24 01:34:41 UTC
[GitHub] [arrow-datafusion] happysalada opened a new issue #2071: Commiting the Cargo.lock
happysalada opened a new issue #2071:
URL: https://github.com/apache/arrow-datafusion/issues/2071
Hi, could you commit the cargo.lock file please ?
The reason I am asking is that it is usually needed to build the software from source to package for other discributions.
I am currently having a look at packaging for nixos.
Let me know if you need more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] houqp commented on issue #2071: Commiting the Cargo.lock
Posted by GitBox <gi...@apache.org>.
houqp commented on issue #2071:
URL: https://github.com/apache/arrow-datafusion/issues/2071#issuecomment-1080877993
Thank you. Please put the lock file only in datafusion-cli folder so it won't get applied to the datafusion core library :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] happysalada commented on issue #2071: Commiting the Cargo.lock
Posted by GitBox <gi...@apache.org>.
happysalada commented on issue #2071:
URL: https://github.com/apache/arrow-datafusion/issues/2071#issuecomment-1080101103
Right, I completely agree. I wanted to try out datafution-cli . Do you think you can commit the lockfile for it ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] houqp commented on issue #2071: Commiting the Cargo.lock
Posted by GitBox <gi...@apache.org>.
houqp commented on issue #2071:
URL: https://github.com/apache/arrow-datafusion/issues/2071#issuecomment-1080099527
The general rule of thumb is to only checkin lock files for crates that produces binary artifacts. For example: datafusion-cli, ballista-scheduler, ballista-executor, etc. But we should avoid checking in lock file for the datafusion core itself since it's a library.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] happysalada commented on issue #2071: Commiting the Cargo.lock
Posted by GitBox <gi...@apache.org>.
happysalada commented on issue #2071:
URL: https://github.com/apache/arrow-datafusion/issues/2071#issuecomment-1081356889
like I said in the PR. unfortunately cargo does not tolerate a lock that is not at the root of the workspace.
So as a workaround I added exclude statements in the other cargo.toml files (for all the libraries).
Let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] houqp commented on issue #2071: Commiting the Cargo.lock
Posted by GitBox <gi...@apache.org>.
houqp commented on issue #2071:
URL: https://github.com/apache/arrow-datafusion/issues/2071#issuecomment-1080113412
adding a lockfile to datafusion-cli should be fine, you can generate one by running cargo build locally, then send a PR to have it checked it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] happysalada commented on issue #2071: Commiting the Cargo.lock
Posted by GitBox <gi...@apache.org>.
happysalada commented on issue #2071:
URL: https://github.com/apache/arrow-datafusion/issues/2071#issuecomment-1080637411
happy to do an MR!
One more question though. Would you prefer a cargo lock in the datafusion-cli directory only for that project, or a global cargo.lock that would be added to the cargoignore. With the second way, everyone who develops on the repo would benefit from it.
Let me know what you prefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org