You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "vishesh92 (via GitHub)" <gi...@apache.org> on 2024/08/21 08:57:06 UTC
[PR] Provide option to use existing ISOs for kubernetes supported version [cloudstack]
vishesh92 opened a new pull request, #9561:
URL: https://github.com/apache/cloudstack/pull/9561
### Description
This PR fixes https://github.com/apache/cloudstack/issues/8417 by allowing the user to register an ISO first by uploading or by using a URL. And then passing in an existing ISO id while adding a new kubernetes supported version.
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ******************************************************************************* -->
<!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ******************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
#### How did you try to break this feature and the system with this change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-2306401995
@vishesh92
To be frank, I think this is too complicated.
We could add an API to transform a regular ISO (registered or uploaded from local) to a CKS ISO, it will be simple and cover mose cases (e.g. Update an existing ISO to support CKS)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on code in PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#discussion_r1956297505
##########
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/version/KubernetesVersionManagerImpl.java:
##########
@@ -160,6 +164,33 @@ private List <KubernetesSupportedVersionVO> filterKubernetesSupportedVersions(Li
return versions;
}
+ private GetUploadParamsResponse registerKubernetesVersionIsoForUpload(final Long zoneId, final String versionName, final String isoChecksum) {
+ CallContext.register(CallContext.current(), ApiCommandResourceType.Iso);
+ String isoName = String.format("%s-Kubernetes-Binaries-ISO", versionName);
+ GetUploadParamsForIsoCmd uploadIso = new GetUploadParamsForIsoCmd();
+ uploadIso = ComponentContext.inject(uploadIso);
+ uploadIso.setName(isoName);
+ uploadIso.setPublicIso(true);
+ if (zoneId != null) {
+ uploadIso.setZoneId(zoneId);
Review Comment:
I also need to check if we allow domain admin or a user to add kubernetes versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-3252489095
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-2304410693
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 10747
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-2684534145
@vishesh92 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-2717304990
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12751
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland merged PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on code in PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#discussion_r1956295770
##########
ui/src/config/section/image.js:
##########
@@ -395,6 +395,14 @@ export default {
show: isZoneCreated,
component: shallowRef(defineAsyncComponent(() => import('@/views/image/AddKubernetesSupportedVersion.vue')))
},
+ {
+ api: 'addKubernetesSupportedVersion',
Review Comment:
Yes. This didn't cause issues, since the component is ignoring the api defined here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Provide option to use existing ISOs for kubernetes supported version [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-2301549112
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9561?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 4.17%. Comparing base [(`f84e043`)](https://app.codecov.io/gh/apache/cloudstack/commit/f84e04372c98f82667214ab53f566c2e5f17af68?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`aa011bf`)](https://app.codecov.io/gh/apache/cloudstack/commit/aa011bff2651f668f01f78da2688f8325fb47382?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 9 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #9561 +/- ##
=====================================
Coverage 4.17% 4.17%
=====================================
Files 377 376 -1
Lines 30866 30819 -47
Branches 5463 5450 -13
=====================================
Hits 1288 1288
+ Misses 29432 29385 -47
Partials 146 146
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9561/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9561/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.17% <ø> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/9561?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-2306528465
> > > @vishesh92 To be frank, I think this is too complicated. We could add an API to transform a regular ISO (registered or uploaded from local) to a CKS ISO, it will be simple and cover mose cases (e.g. Update an existing ISO to support CKS)
> >
> >
> > @weizhouapache My initial PR was for linking an existing ISO with a CKS Supported version ([main...shapeblue:cloudstack:k8s-version-add-iso-id-backup](https://github.com/apache/cloudstack/compare/main...shapeblue:cloudstack:k8s-version-add-iso-id-backup)). @shwstppr had some concerns regarding the iso's permissions. So, I made the implementation similar to how it is there right now for templates & ISOs.
>
> we can add some restrictions
>
> * only root admin can do (same as add k8s version API)
>
> * the ISO will be changed to the same properties as k8s ISO (e.g. owner is system account, all users can access)
>
>
> I had a quick look at your initial PR, it looks ok to me
@weizhouapache I am not sure about changing the properties of the existing ISO. I can maybe create a copy of the ISO with required ownership and properties. Do you think that would be a better approach?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-3265000289
> > @vishesh92
> > Failed iso upload remains in allocated state
> > Step to reproduce the issue
> > ```
> > 1. Navaigte to images > kubetnetes iso > Upload a k8s iso
> >
> > 2. For some reason the job fails
> >
> > 3. The kubernetes iso state will be in Allocated state
> > ```
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > 
> > ```
> > 4. Navaigte to images >iso the k8s iso will be in "Not ready" state
> > ```
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > 
> > ```
> > 5. Navaigte to images > kubetnetes iso
> > ```
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > Later on it goes into a failed state after "upload.operation.timeout)"
> > 
> > While images > Iso > the state will be still in Not ready
> > In case of failures
> > When end user executed the API call list kubernetessupportedversions
> > can you change the behaviour of isostate from
> > Allocated >>failed
> > to
> > Notready to failed
> > (localcloud) 🐱 > list kubernetessupportedversions filter=isoname,isostate { "count": 4, "kubernetessupportedversion": [ { "isoname": "v1.31.1-Kubernetes-Binaries-ISO", "isostate": "Failed" },
>
> @kiranchavala Can you try again? You will need to ensure certs are valid for the SSVM or an exception is added in the browser.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-3266859617
<b>[SF] Trillian Build Failed (tid-14244)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-3264995946
> @vishesh92
>
> Failed iso upload remains in allocated state
>
> Step to reproduce the issue
>
> 1. Navaigte to images > kubetnetes iso > Upload a k8s iso
>
> 2. For some reason the job fails
>
> 3. The kubernetes iso state will be in Allocated state
>
>
> 
>
> 4. Navaigte to images >iso the k8s iso will be in "Not ready" state
>
>
> 
>
> 5. Navaigte to images > kubetnetes iso
>
>
> Later on it goes into a failed state after "upload.operation.timeout)"
>
> 
>
> While images > Iso > the state will be still in Not ready
>
> In case of failures
>
> When end user executed the API call list kubernetessupportedversions
>
> can you change the behaviour of isostate from
>
> Allocated >>failed
>
> to
>
> Notready to failed
>
> (localcloud) 🐱 > list kubernetessupportedversions filter=isoname,isostate { "count": 4, "kubernetessupportedversion": [ { "isoname": "v1.31.1-Kubernetes-Binaries-ISO", "isostate": "Failed" },
@kiranchavala Can you try again? You will need to ensure certs are valid for the SSVM or an exception is added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-2306415876
> @vishesh92 To be frank, I think this is too complicated. We could add an API to transform a regular ISO (registered or uploaded from local) to a CKS ISO, it will be simple and cover mose cases (e.g. Update an existing ISO to support CKS)
@weizhouapache My initial PR was for linking an existing ISO with a CKS Supported version (https://github.com/apache/cloudstack/compare/main...shapeblue:cloudstack:k8s-version-add-iso-id-backup). @shwstppr had some concerns regarding the iso's permissions. So, I made the implementation similar to how it is there right now for templates & ISOs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-2686711801
<b>[SF] Trillian test result (tid-12495)</b>
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 56479 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9561-t12495-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_06_purge_expunged_vm_background_task | `Failure` | 405.75 | test_purge_expunged_vms.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-3252882958
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 14844
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-3272533691
<b>[SF] Trillian test result (tid-14250)</b>
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 51965 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9561-t14250-kvm-ol8.zip
Smoke tests completed. 146 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Provide option to use existing ISOs for kubernetes supported version [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-2301891140
@vishesh92 will this create access issues? Currently, k8s ISOs are registered as public and are accessible to all. But now will it allow linking any existing ISO which can be seen by root admin.
Also, earlier such ISOs were owned by system account to prevent direct deletion. Is there a check to prevent deletion if it is linked to a k8s version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Provide option to use existing ISOs for kubernetes supported version [cloudstack]
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-2301648991
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Posted by "Pearl1594 (via GitHub)" <gi...@apache.org>.
Pearl1594 commented on code in PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#discussion_r1956259338
##########
plugins/integrations/kubernetes-service/src/main/java/org/apache/cloudstack/api/command/admin/kubernetes/version/GetUploadParamsForKubernetesSupportedVersionCmd.java:
##########
@@ -0,0 +1,127 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.api.command.admin.kubernetes.version;
+
+import com.cloud.exception.ConcurrentOperationException;
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.kubernetes.version.KubernetesSupportedVersion;
+import com.cloud.kubernetes.version.KubernetesVersionService;
+import com.cloud.utils.exception.CloudRuntimeException;
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.AbstractGetUploadParamsCmd;
+import org.apache.cloudstack.api.ApiCommandResourceType;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ResponseObject;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.command.admin.AdminCmd;
+import org.apache.cloudstack.api.response.GetUploadParamsResponse;
+import org.apache.cloudstack.api.response.KubernetesSupportedVersionResponse;
+import org.apache.cloudstack.context.CallContext;
+import org.apache.commons.lang3.StringUtils;
+
+import javax.inject.Inject;
+
+@APICommand(name = "getUploadParamsForKubernetesSupportedVersion",
+ description = "Add a supported Kubernetes version",
Review Comment:
Can we say - `Upload a supported Kubernetes version`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Provide option to use existing ISOs for kubernetes supported version [cloudstack]
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-2303916239
> @vishesh92 will this create access issues? Currently, k8s ISOs are registered as public and are accessible to all. But now will it allow linking any existing ISO which can be seen by root admin. Also, earlier such ISOs were owned by system account to prevent direct deletion. Is there a check to prevent deletion if it is linked to a k8s version?
I can add checks on the backend to ensure that the ISO has the required configuration settings. But it might be confusing for the end user.
Let me revisit the approach and directly allow uploading of ISO for k8s.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-2306391455
@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on code in PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#discussion_r1956291612
##########
plugins/integrations/kubernetes-service/src/main/java/org/apache/cloudstack/api/command/admin/kubernetes/version/GetUploadParamsForKubernetesSupportedVersionCmd.java:
##########
@@ -0,0 +1,127 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.api.command.admin.kubernetes.version;
+
+import com.cloud.exception.ConcurrentOperationException;
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.kubernetes.version.KubernetesSupportedVersion;
+import com.cloud.kubernetes.version.KubernetesVersionService;
+import com.cloud.utils.exception.CloudRuntimeException;
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.AbstractGetUploadParamsCmd;
+import org.apache.cloudstack.api.ApiCommandResourceType;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ResponseObject;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.command.admin.AdminCmd;
+import org.apache.cloudstack.api.response.GetUploadParamsResponse;
+import org.apache.cloudstack.api.response.KubernetesSupportedVersionResponse;
+import org.apache.cloudstack.context.CallContext;
+import org.apache.commons.lang3.StringUtils;
+
+import javax.inject.Inject;
+
+@APICommand(name = "getUploadParamsForKubernetesSupportedVersion",
+ description = "Add a supported Kubernetes version",
Review Comment:
```suggestion
description = "Upload a supported Kubernetes version",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on code in PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#discussion_r1956294884
##########
ui/src/config/section/image.js:
##########
@@ -395,6 +395,14 @@ export default {
show: isZoneCreated,
component: shallowRef(defineAsyncComponent(() => import('@/views/image/AddKubernetesSupportedVersion.vue')))
},
+ {
+ api: 'addKubernetesSupportedVersion',
Review Comment:
```suggestion
api: 'getUploadParamsForKubernetesSupportedVersion',
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Posted by "rosi-shapeblue (via GitHub)" <gi...@apache.org>.
rosi-shapeblue commented on PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-3396938442
**1. Valid ISO upload:**
- Upload ISO from local → progress bar works → Allocated → Ready
- K8s supported version is created and visible in UI
- DB reflects ISO as Active
- Cleanup works correctly.
<img width="3099" height="1673" alt="Screenshot from 2025-10-13 11-41-06" src="https://github.com/user-attachments/assets/ecaa2625-4dc5-4dee-990c-1f77ebf5d37a" />
<img width="3099" height="1673" alt="Screenshot from 2025-10-13 11-41-10" src="https://github.com/user-attachments/assets/85e72e2d-1bfc-4d6f-b609-2e875e132a8a" />
<img width="3099" height="1673" alt="Screenshot from 2025-10-13 11-42-18" src="https://github.com/user-attachments/assets/81174170-d2bd-446f-abee-a38da84c0119" />
```
mysql> SELECT id, name, state FROM vm_template WHERE name LIKE '%Kubernetes-Binaries-ISO%';
+-----+-------------------------------------------+--------+
| id | name | state |
+-----+-------------------------------------------+--------+
| 211 | test-local-upload-Kubernetes-Binaries-ISO | Active |
+-----+-------------------------------------------+--------+
1 row in set (0.00 sec)
```
```
(localcloud) 🐱 > list kubernetessupportedversions filter=name,isoname,isostate
{
"count": 1,
"kubernetessupportedversion": [
{
"isoname": "test-local-upload-Kubernetes-Binaries-ISO",
"isostate": "Ready",
"name": "test-local-upload"
}
]
}
```
**2. Invalid ISO / format upload:**
<img width="2628" height="548" alt="image" src="https://github.com/user-attachments/assets/1eff2b41-06be-43d6-8b8b-3557bb79089d" />
<img width="2628" height="548" alt="image" src="https://github.com/user-attachments/assets/9971c88e-9575-4168-81a0-0652bd2b6e0f" />
<img width="2681" height="636" alt="image" src="https://github.com/user-attachments/assets/195f8292-9215-4136-91b1-d16a85e4e435" />
**3. Permission & Role Testing:**
<img width="3113" height="867" alt="image" src="https://github.com/user-attachments/assets/af79e5ca-d9b6-42a8-8117-504ec89c7f46" />
- with permissions (**NOTE**: only admin users should be allowed to execute such uploads; the modal is not functional, despite it might be present in some cases where the user was granted such permissions)
<img width="3108" height="1644" alt="image" src="https://github.com/user-attachments/assets/ef5e92ca-d8d8-4d03-8664-deb4445f4808" />
- without permissions:
<img width="3108" height="826" alt="image" src="https://github.com/user-attachments/assets/c519afbb-85cf-44d3-9650-336ba727cedf" />
**4. URL Path Upload**
via UI / API
```
(admin) 🐱 > addKubernetesSupportedVersion semanticversion=1.33.1 url=https://download.cloudstack.org/cks/setup-v1.33.1-calico-aarch64.iso mincpunumber=2 minmemory=2048 zoneid=139d7f30-ab8e-4dbb-9f67-f23f4de8241c
{
"kubernetessupportedversion": {
"arch": "x86_64",
"created": "2025-10-13T10:10:30+0000",
"directdownload": false,
"id": "ea635f13-f475-4db1-972d-d7951668fa23",
"isoid": "e9444a71-fc81-4cb1-ba2d-b21c9a24044a",
"isoname": "v1.33.1-ref-trl-9660-k-Mol8-rositsa-kyuchukova-Kubernetes-Binaries-ISO",
"isostate": "Creating",
"mincpunumber": 2,
"minmemory": 2048,
"name": "v1.33.1-ref-trl-9660-k-Mol8-rositsa-kyuchukova",
"semanticversion": "1.33.1",
"state": "Enabled",
"supportsautoscaling": true,
"supportsha": true,
"zoneid": "139d7f30-ab8e-4dbb-9f67-f23f4de8241c",
"zonename": "ref-trl-9660-k-Mol8-rositsa-kyuchukova"
}
}
(admin) 🐱 >
```
<img width="2681" height="622" alt="image" src="https://github.com/user-attachments/assets/7eed9528-d6bc-41f3-bc2e-ab8c17eb8625" />
- invalid path
<img width="2609" height="762" alt="image" src="https://github.com/user-attachments/assets/fdf4697c-9e79-43ac-bd93-7c392ae3e00f" />
```
(admin) 🐱 > delete kubernetessupportedversion id=c5d50d38-c1e3-48ae-8459-0cfee9a7a118
{
"success": true
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-2306432072
> > @vishesh92 To be frank, I think this is too complicated. We could add an API to transform a regular ISO (registered or uploaded from local) to a CKS ISO, it will be simple and cover mose cases (e.g. Update an existing ISO to support CKS)
>
> @weizhouapache My initial PR was for linking an existing ISO with a CKS Supported version ([main...shapeblue:cloudstack:k8s-version-add-iso-id-backup](https://github.com/apache/cloudstack/compare/main...shapeblue:cloudstack:k8s-version-add-iso-id-backup)). @shwstppr had some concerns regarding the iso's permissions. So, I made the implementation similar to how it is there right now for templates & ISOs.
we can add some restrictions
- only root admin can do (same as add k8s version API)
- the ISO will be changed to the same properties as k8s ISO (e.g. owner is system account, all users can access)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-2666261798
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12508
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-2717086842
@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-2656647539
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12444
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Posted by "Pearl1594 (via GitHub)" <gi...@apache.org>.
Pearl1594 commented on code in PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#discussion_r1956303710
##########
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/version/KubernetesVersionManagerImpl.java:
##########
@@ -160,6 +164,33 @@ private List <KubernetesSupportedVersionVO> filterKubernetesSupportedVersions(Li
return versions;
}
+ private GetUploadParamsResponse registerKubernetesVersionIsoForUpload(final Long zoneId, final String versionName, final String isoChecksum) {
+ CallContext.register(CallContext.current(), ApiCommandResourceType.Iso);
+ String isoName = String.format("%s-Kubernetes-Binaries-ISO", versionName);
+ GetUploadParamsForIsoCmd uploadIso = new GetUploadParamsForIsoCmd();
+ uploadIso = ComponentContext.inject(uploadIso);
+ uploadIso.setName(isoName);
+ uploadIso.setPublicIso(true);
+ if (zoneId != null) {
+ uploadIso.setZoneId(zoneId);
Review Comment:
It seems like by default we do not allow registering kubernetes iso for dom admins. Corner case is when we add custom roles. But I think that can be overlooked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Posted by "harikrishna-patnala (via GitHub)" <gi...@apache.org>.
harikrishna-patnala commented on PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-3251831146
> moved to 4.22.0 milestone. cc @harikrishna-patnala @vishesh92
@vishesh92 can you please change the base branch to main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-3252015416
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-3253123225
@vishesh92 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Posted by "Pearl1594 (via GitHub)" <gi...@apache.org>.
Pearl1594 commented on PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-2666074314
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-2666081167
@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-2333362231
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-2656438056
@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on code in PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#discussion_r1956289722
##########
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/version/KubernetesVersionManagerImpl.java:
##########
@@ -160,6 +164,33 @@ private List <KubernetesSupportedVersionVO> filterKubernetesSupportedVersions(Li
return versions;
}
+ private GetUploadParamsResponse registerKubernetesVersionIsoForUpload(final Long zoneId, final String versionName, final String isoChecksum) {
+ CallContext.register(CallContext.current(), ApiCommandResourceType.Iso);
+ String isoName = String.format("%s-Kubernetes-Binaries-ISO", versionName);
+ GetUploadParamsForIsoCmd uploadIso = new GetUploadParamsForIsoCmd();
+ uploadIso = ComponentContext.inject(uploadIso);
+ uploadIso.setName(isoName);
+ uploadIso.setPublicIso(true);
+ if (zoneId != null) {
+ uploadIso.setZoneId(zoneId);
Review Comment:
I followed the existing checks in `AddKubernetesSupportedVersionCmd` for the upload command.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on code in PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#discussion_r1956292854
##########
ui/src/config/section/image.js:
##########
@@ -395,6 +395,14 @@ export default {
show: isZoneCreated,
component: shallowRef(defineAsyncComponent(() => import('@/views/image/AddKubernetesSupportedVersion.vue')))
},
+ {
+ api: 'addKubernetesSupportedVersion',
+ icon: 'cloud-upload-outlined',
+ label: 'label.kubernetes.version.add.from.local',
+ listView: true,
+ popup: true,
Review Comment:
```suggestion
popup: true,
show: isZoneCreated,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-3266743792
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-2306509220
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10772
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-2304358531
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Provide option to use existing ISOs for kubernetes supported version [cloudstack]
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-2301650097
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-2304362105
@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Posted by "Pearl1594 (via GitHub)" <gi...@apache.org>.
Pearl1594 commented on PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-2654513954
@vishesh92 could you please fix the merge conflicts. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-2656040408
> @vishesh92 could you please fix the merge conflicts. Thank you.
@vishesh92 , please also look at target branch and release, these do not match.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Posted by "Pearl1594 (via GitHub)" <gi...@apache.org>.
Pearl1594 commented on code in PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#discussion_r1956245278
##########
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/version/KubernetesVersionManagerImpl.java:
##########
@@ -160,6 +164,33 @@ private List <KubernetesSupportedVersionVO> filterKubernetesSupportedVersions(Li
return versions;
}
+ private GetUploadParamsResponse registerKubernetesVersionIsoForUpload(final Long zoneId, final String versionName, final String isoChecksum) {
+ CallContext.register(CallContext.current(), ApiCommandResourceType.Iso);
+ String isoName = String.format("%s-Kubernetes-Binaries-ISO", versionName);
+ GetUploadParamsForIsoCmd uploadIso = new GetUploadParamsForIsoCmd();
+ uploadIso = ComponentContext.inject(uploadIso);
+ uploadIso.setName(isoName);
+ uploadIso.setPublicIso(true);
+ if (zoneId != null) {
+ uploadIso.setZoneId(zoneId);
Review Comment:
zoneId - seems to be a mandatory param for upload iso, so I wonder if this could cause some failure if upload iso is done by a user / dom admin
considering https://github.com/apache/cloudstack/blob/main/server/src/main/java/com/cloud/template/TemplateAdapterBase.java#L194-L197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-3264996741
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-3252495093
@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-3266735262
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Provide option to use existing ISOs for kubernetes supported version [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-2301774702
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10728
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Provide option to use existing ISOs for kubernetes supported version [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-2301652818
@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-2717080874
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Provide option to use existing ISOs for kubernetes supported version [cloudstack]
Posted by "FelipeM525 (via GitHub)" <gi...@apache.org>.
FelipeM525 commented on PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-2301849108
@vishesh92 would you mind adding some images to the description?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-2306389590
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-2656434975
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Posted by "Pearl1594 (via GitHub)" <gi...@apache.org>.
Pearl1594 commented on code in PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#discussion_r1956263462
##########
ui/src/config/section/image.js:
##########
@@ -395,6 +395,14 @@ export default {
show: isZoneCreated,
component: shallowRef(defineAsyncComponent(() => import('@/views/image/AddKubernetesSupportedVersion.vue')))
},
+ {
+ api: 'addKubernetesSupportedVersion',
Review Comment:
should this be `getUploadParamsForKubernetesSupportedVersion` instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-2684532466
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-3249333580
moved to 4.22.0 milestone. cc @harikrishna-patnala @vishesh92
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Posted by "harikrishna-patnala (via GitHub)" <gi...@apache.org>.
harikrishna-patnala commented on PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-3251834162
> > moved to 4.22.0 milestone. cc @harikrishna-patnala @vishesh92
>
> @vishesh92 can you please change the base branch to main
I've changed it, please check if everything else is fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-3253115665
@blueorangutan test keepEnv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org