You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Ashutosh Kelkar <as...@clogeny.com> on 2014/12/19 08:26:36 UTC
Review Request 29241: CLOUDSTACK-8095: Fixed Iso attach issue in
test_escalations_instances.py
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29241/
-----------------------------------------------------------
Review request for cloudstack and SrikanteswaraRao Talluri.
Bugs: CLOUDSTACK-8095
https://issues.apache.org/jira/browse/CLOUDSTACK-8095
Repository: cloudstack-git
Description
-------
The test case was failing while attaching Iso to VM because it did not check whether the Iso is compatible to the VM.
Added the check for xenserver and vmware compatible Iso so that xs-tools iso would get attached in case of XenServer and similar to vmware.
Also fixed pep8 issues.
Diffs
-----
test/integration/component/test_escalations_instances.py e79cd3d
Diff: https://reviews.apache.org/r/29241/diff/
Testing
-------
@Desc: Test Attach ISO to VM and Detach ISO from VM. ... === TestName: test_13_attach_detach_iso | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 1 test in 167.657s
OK
Thanks,
Ashutosh Kelkar
Re: Review Request 29241: CLOUDSTACK-8095: Fixed Iso attach issue in
test_escalations_instances.py
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29241/#review65796
-----------------------------------------------------------
Ship it!
Ship It!
- SrikanteswaraRao Talluri
On Dec. 19, 2014, 7:26 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29241/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2014, 7:26 a.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-8095
> https://issues.apache.org/jira/browse/CLOUDSTACK-8095
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The test case was failing while attaching Iso to VM because it did not check whether the Iso is compatible to the VM.
> Added the check for xenserver and vmware compatible Iso so that xs-tools iso would get attached in case of XenServer and similar to vmware.
> Also fixed pep8 issues.
>
>
> Diffs
> -----
>
> test/integration/component/test_escalations_instances.py e79cd3d
>
> Diff: https://reviews.apache.org/r/29241/diff/
>
>
> Testing
> -------
>
> @Desc: Test Attach ISO to VM and Detach ISO from VM. ... === TestName: test_13_attach_detach_iso | Status : SUCCESS ===
> ok
>
> ----------------------------------------------------------------------
> Ran 1 test in 167.657s
>
> OK
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>