[GitHub] rnewson commented on issue #1234: Fix 413 response handling and re-enable related couch replicator test

[GitBox <gi...@apache.org>]

rnewson commented on issue #1234: Fix 413 response handling and re-enable related couch replicator test
URL: https://github.com/apache/couchdb/pull/1234#issuecomment-375818638
 
 
   You described the previous behaviour in the pr description but not the new behaviour. 
   
   Sent from my iPhone
   
   > On 23 Mar 2018, at 22:28, Nick Vatamaniuc <no...@github.com> wrote:
   > 
   > Previously, when the server decided too much data sent with the client's
   > request, it would immediately send a 413 response and close the socket. The
   > client side kept sending incoming data as the socket was closed with unread
   > data in it. When this happens the connection was reset instead of going through
   > a regular close sequence. The client, specifically the replicator client,
   > detected the connection reset event before it had a chance to process the 413
   > response.
   > 
   > Also re-enable the previously disabled replicate_one_with_attachment test.
   > 
   > To test run this for a while:
   > 
   > make soak-eunit apps=couch_replicator suites=couch_replicator_small_max_request_size_target
   >  Code is written and works correctly;
   >  Changes are covered by tests;
   >  Documentation reflects the changes;
   > You can view, comment on, or merge this pull request online at:
   > 
   >   https://github.com/apache/couchdb/pull/1234
   > 
   > Commit Summary
   > 
   > Revert "Revert "re-enable "flaky" test in quest to nail down #745""
   > Improve 413 response handling
   > File Changes
   > 
   > M src/couch/src/couch_httpd.erl (11)
   > M src/couch_replicator/test/couch_replicator_small_max_request_size_target.erl     (28)
   > Patch Links:
   > 
   > https://github.com/apache/couchdb/pull/1234.patch
   > https://github.com/apache/couchdb/pull/1234.diff
   > —
   > You are receiving this because you are subscribed to this thread.
   > Reply to this email directly, view it on GitHub, or mute the thread.
   > 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services