You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/07/31 09:56:08 UTC

[GitHub] [inlong] gong opened a new pull request, #5298: [INLONG-5242][Sort] Add metric computing for mongoDB and Oracle

gong opened a new pull request, #5298:
URL: https://github.com/apache/inlong/pull/5298

   ### Prepare a Pull Request
   
   - [INLONG-5242][Sort] Add metric computing for mongodb and oracle
   - Fixes #5242 
   
   ### Motivation
   
   Add metric computing for mongodb and oracle
   
   ### Modifications
   
   * Add metric computing for mongodb and oracle
   * Add optional table option `inlong.metric` for mongodb and oracle
   * Modify delimiter of `inlong.metric`, from  `_`  to  `&`. Because groupId and streamId can contain `_`, it will lead split error.
   * Modify pom of postgres. Beacause it will cause lost dependency class about connector-base. 
   * Improve connector-base, It will support custom Counter.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] gong commented on a diff in pull request #5298: [INLONG-5242][Sort] Add metric computing for mongoDB and Oracle

Posted by GitBox <gi...@apache.org>.
gong commented on code in PR #5298:
URL: https://github.com/apache/inlong/pull/5298#discussion_r934283589


##########
inlong-sort/sort-connectors/oracle-cdc/src/main/resources/META-INF/services/org.apache.flink.table.factories.Factory:
##########
@@ -0,0 +1,33 @@
+#

Review Comment:
   remove duplication license header



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] healchow commented on a diff in pull request #5298: [INLONG-5242][Sort] Add metric computing for mongoDB and Oracle

Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #5298:
URL: https://github.com/apache/inlong/pull/5298#discussion_r934274560


##########
inlong-sort/sort-connectors/oracle-cdc/src/main/resources/META-INF/services/org.apache.flink.table.factories.Factory:
##########
@@ -0,0 +1,33 @@
+#

Review Comment:
   Why two license headers?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] gong commented on a diff in pull request #5298: [INLONG-5242][Sort] Add metric computing for mongoDB and Oracle

Posted by GitBox <gi...@apache.org>.
gong commented on code in PR #5298:
URL: https://github.com/apache/inlong/pull/5298#discussion_r934220680


##########
inlong-sort/sort-connectors/postgres-cdc/src/main/java/org/apache/inlong/sort/cdc/postgres/table/PostgreSQLTableFactory.java:
##########
@@ -44,7 +44,7 @@ public class PostgreSQLTableFactory implements DynamicTableSourceFactory {
             ConfigOptions.key("inlong.metric")
                     .stringType()
                     .defaultValue("")
-                    .withDescription("INLONG GROUP ID + '_' + STREAM ID + '_' + NODE ID");
+                    .withDescription("INLONG GROUP ID + '&' + STREAM ID + '&' + NODE ID");

Review Comment:
   Here is description. not concat string



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] yunqingmoswu commented on a diff in pull request #5298: [INLONG-5242][Sort] Add metric computing for mongoDB and Oracle

Posted by GitBox <gi...@apache.org>.
yunqingmoswu commented on code in PR #5298:
URL: https://github.com/apache/inlong/pull/5298#discussion_r934217671


##########
inlong-sort/sort-connectors/postgres-cdc/src/main/java/org/apache/inlong/sort/cdc/postgres/table/PostgreSQLTableFactory.java:
##########
@@ -44,7 +44,7 @@ public class PostgreSQLTableFactory implements DynamicTableSourceFactory {
             ConfigOptions.key("inlong.metric")
                     .stringType()
                     .defaultValue("")
-                    .withDescription("INLONG GROUP ID + '_' + STREAM ID + '_' + NODE ID");
+                    .withDescription("INLONG GROUP ID + '&' + STREAM ID + '&' + NODE ID");

Review Comment:
   It is recommended to use str.format.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] dockerzhang merged pull request #5298: [INLONG-5242][Sort] Add metric computing for mongoDB and Oracle

Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #5298:
URL: https://github.com/apache/inlong/pull/5298


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] gong commented on pull request #5298: [INLONG-5242][Sort] Add metric computing for mongoDB and Oracle

Posted by GitBox <gi...@apache.org>.
gong commented on PR #5298:
URL: https://github.com/apache/inlong/pull/5298#issuecomment-1200907571

   > Can DebeziumSourceFunction be extracted?
   
   some connector don't need dependency about debezium. So DebeziumSourceFunction can't be extracted.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org