You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/04/05 00:24:48 UTC
[GitHub] [airflow] kaxil opened a new pull request #8148: Fix broken
TriggerDag UI
kaxil opened a new pull request #8148: Fix broken TriggerDag UI
URL: https://github.com/apache/airflow/pull/8148
https://github.com/apache/airflow/pull/7899 broke Triggering DAG from UI
```
> return self.get_dag().create_dagrun(run_id=run_id,
state=state,
execution_date=execution_date,
start_date=start_date,
external_trigger=external_trigger,
conf=conf,
session=session)
E AttributeError: 'DagModel' object has no attribute 'get_dag'
airflow/models/dag.py:1778: AttributeError
```
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil merged pull request #8148: Fix broken Triggering
Dag from UI functionality
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #8148: Fix broken Triggering Dag from UI functionality
URL: https://github.com/apache/airflow/pull/8148
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #8148: Fix broken
Triggering Dag from UI functionality
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #8148: Fix broken Triggering Dag from UI functionality
URL: https://github.com/apache/airflow/pull/8148#issuecomment-609416725
# [Codecov](https://codecov.io/gh/apache/airflow/pull/8148?src=pr&el=h1) Report
> Merging [#8148](https://codecov.io/gh/apache/airflow/pull/8148?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/68d1714f296989b7aad1a04b75dc033e76afb747&el=desc) will **increase** coverage by `21.89%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/airflow/pull/8148?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8148 +/- ##
===========================================
+ Coverage 66.39% 88.28% +21.89%
===========================================
Files 935 935
Lines 45170 45168 -2
===========================================
+ Hits 29990 39878 +9888
+ Misses 15180 5290 -9890
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/8148?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/8148/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5) | `91.52% <ø> (+33.21%)` | :arrow_up: |
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/8148/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.67% <100.00%> (+50.86%)` | :arrow_up: |
| [airflow/providers/google/cloud/operators/vision.py](https://codecov.io/gh/apache/airflow/pull/8148/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy92aXNpb24ucHk=) | `99.63% <0.00%> (+0.36%)` | :arrow_up: |
| [...osoft/azure/operators/azure\_container\_instances.py](https://codecov.io/gh/apache/airflow/pull/8148/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbWljcm9zb2Z0L2F6dXJlL29wZXJhdG9ycy9henVyZV9jb250YWluZXJfaW5zdGFuY2VzLnB5) | `78.28% <0.00%> (+0.65%)` | :arrow_up: |
| [airflow/cli/cli\_parser.py](https://codecov.io/gh/apache/airflow/pull/8148/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY2xpX3BhcnNlci5weQ==) | `97.24% <0.00%> (+0.91%)` | :arrow_up: |
| [airflow/providers/postgres/hooks/postgres.py](https://codecov.io/gh/apache/airflow/pull/8148/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvaG9va3MvcG9zdGdyZXMucHk=) | `94.36% <0.00%> (+1.40%)` | :arrow_up: |
| [...rflow/providers/databricks/operators/databricks.py](https://codecov.io/gh/apache/airflow/pull/8148/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZGF0YWJyaWNrcy9vcGVyYXRvcnMvZGF0YWJyaWNrcy5weQ==) | `92.24% <0.00%> (+1.72%)` | :arrow_up: |
| [.../providers/google/cloud/operators/presto\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/8148/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9wcmVzdG9fdG9fZ2NzLnB5) | `38.66% <0.00%> (+2.66%)` | :arrow_up: |
| [airflow/models/log.py](https://codecov.io/gh/apache/airflow/pull/8148/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvbG9nLnB5) | `100.00% <0.00%> (+3.03%)` | :arrow_up: |
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/8148/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.51% <0.00%> (+3.37%)` | :arrow_up: |
| ... and [496 more](https://codecov.io/gh/apache/airflow/pull/8148/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/8148?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/8148?src=pr&el=footer). Last update [68d1714...0f898b1](https://codecov.io/gh/apache/airflow/pull/8148?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services