[GitHub] [pinot] tanmesh commented on a diff in pull request #10042: [WIP] Adding support for broker short-circuit for point queries w/ a limit clause

[GitBox <gi...@apache.org>]

tanmesh commented on code in PR #10042:
URL: https://github.com/apache/pinot/pull/10042#discussion_r1062093669


##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/SingleConnectionBrokerRequestHandler.java:
##########
@@ -106,13 +106,36 @@ protected BrokerResponseNative processBrokerRequest(long requestId, BrokerReques
       serverBrokerRequest.getPinotQuery().putToQueryOptions(CommonConstants.Broker.Request.TRACE, "true");
     }
 
+    // broker short-circuit for `select` and `select distinct` queries without `ORDER BY`
+    boolean orderByPresent = false;

Review Comment:
   Thanks Jackie, it was very helpful. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org