[jira] Updated: (MJAR-20) Don't create empty jars

["Rodrigo Ruiz (JIRA)" <ji...@codehaus.org>]

     [ http://jira.codehaus.org/browse/MJAR-20?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rodrigo Ruiz updated MJAR-20:
-----------------------------

    Attachment: MJAR-20-02.patch

My two cents :-)

IMHO, if there is no contents to put into the jar, the plugin should do nothing. I have followed this approach and made a modification in trunk (2.3-SNAPSHOT).

I have verified the modification does not break the current tests, and added two new integration tests for verifying the altered behaviour.

I have attached my modification in patch format (MJAR-20-02.patch). The patch includes the modification to AbstractJarMojo.java, and the new integration tests.

I hope this helps,
Rodrigo

> Don't create empty jars
> -----------------------
>
>                 Key: MJAR-20
>                 URL: http://jira.codehaus.org/browse/MJAR-20
>             Project: Maven 2.x Jar Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.0
>            Reporter: Carlos Sanchez
>            Priority: Minor
>         Attachments: MJAR-20-02.patch, MJAR-20.patch
>
>
> Creating empty jars is confusing, it should just print a warning
> use case:
> parent pom attaching test jar, some subprojects may not have tests, why create jars for them?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira