You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "guohao-rosicky (via GitHub)" <gi...@apache.org> on 2024/05/29 09:06:37 UTC
[PR] HDDS-10870. moveSelectionToFutureMap cleanup when future complete [ozone]
guohao-rosicky opened a new pull request, #6746:
URL: https://github.com/apache/ozone/pull/6746
## What changes were proposed in this pull request?
moveSelectionToFutureMap cleanup when future complete
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10870
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10870. moveSelectionToFutureMap cleanup when future complete [ozone]
Posted by "siddhantsangwan (via GitHub)" <gi...@apache.org>.
siddhantsangwan commented on code in PR #6746:
URL: https://github.com/apache/ozone/pull/6746#discussion_r1627494358
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancerTask.java:
##########
@@ -598,21 +600,25 @@ private void checkIterationResults(boolean isMoveGeneratedInThisIteration) {
*/
private void checkIterationMoveResults() {
this.countDatanodesInvolvedPerIteration = 0;
- CompletableFuture<Void> allFuturesResult = CompletableFuture.allOf(
- moveSelectionToFutureMap.values()
- .toArray(new CompletableFuture[moveSelectionToFutureMap.size()]));
- try {
- allFuturesResult.get(config.getMoveTimeout().toMillis(),
- TimeUnit.MILLISECONDS);
- } catch (InterruptedException e) {
- LOG.warn("Container balancer is interrupted");
- Thread.currentThread().interrupt();
- } catch (TimeoutException e) {
- long timeoutCounts = cancelMovesThatExceedTimeoutDuration();
- LOG.warn("{} Container moves are canceled.", timeoutCounts);
- metrics.incrementNumContainerMovesTimeoutInLatestIteration(timeoutCounts);
- } catch (ExecutionException e) {
- LOG.error("Got exception while checkIterationMoveResults", e);
+ Collection<CompletableFuture<MoveManager.MoveResult>> futures =
+ moveSelectionToFutureMap.values();
+ if (!futures.isEmpty()) {
+ CompletableFuture<Void> allFuturesResult = CompletableFuture.allOf(
+ futures.toArray(new CompletableFuture[futures.size()]));
Review Comment:
Intellij recommends changing this to
```
CompletableFuture.allOf(
futures.toArray(new CompletableFuture[0]));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10870. moveSelectionToFutureMap cleanup when future complete [ozone]
Posted by "siddhantsangwan (via GitHub)" <gi...@apache.org>.
siddhantsangwan merged PR #6746:
URL: https://github.com/apache/ozone/pull/6746
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10870. moveSelectionToFutureMap cleanup when future complete [ozone]
Posted by "siddhantsangwan (via GitHub)" <gi...@apache.org>.
siddhantsangwan commented on PR #6746:
URL: https://github.com/apache/ozone/pull/6746#issuecomment-2157753754
Merging, we can handle the comment in a different jira if required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org