[GitHub] [incubator-mxnet] yajiedesign commented on a change in pull request #18362: fix windows dll search path in python 3.8

[GitBox <gi...@apache.org>]

yajiedesign commented on a change in pull request #18362:
URL: https://github.com/apache/incubator-mxnet/pull/18362#discussion_r427778721



##########
File path: python/mxnet/libinfo.py
##########
@@ -73,6 +73,11 @@ def find_lib_path(prefix='libmxnet'):
                            'List of candidates:\n' + str('\n'.join(dll_path)))
     if os.name == 'nt':
         os.environ['PATH'] = os.environ['PATH'] + ';' + os.path.dirname(lib_path[0])
+        if sys.version_info >= (3, 8):
+            if 'CUDA_PATH' not in os.environ:
+                raise RuntimeError('Cannot find the env CUDA_PATH.Please set CUDA_PATH env with cuda path')

Review comment:
       cuda default provided.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org