You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by Matthias Wessendorf <ma...@apache.org> on 2006/11/17 09:44:42 UTC
findNestingForm
is there a reason, why we have the findNestingForm method twice?
with the same logic.
I'd like to refactor that, if there is no real reason.
-M
--
Matthias Wessendorf
http://tinyurl.com/fmywh
further stuff:
blog: http://jroller.com/page/mwessendorf
mail: mwessendorf-at-gmail-dot-com
Re: findNestingForm
Posted by Matthias Wessendorf <ma...@apache.org>.
k
lemme work on that
(already opend an issue)
the pubic in the class was in that particular case the weired thing
here for me ;)
-M
On 11/23/06, Manfred Geiler <ma...@gmail.com> wrote:
> Yep, those "_" classes where meant as internal classes and never for
> public API-like use.
> And if I remember right, they where all package private (you know,
> those weird classes that lack the access modifier ;-) in the
> beginning. Didn't realize they have been changed to public... Hmm
> Of course there is no real need for the "_" prefix in the shared
> classes. But in myfaces-api the prefix is a nice hint for the API
> users that this class is *not* meant for *them*. Even if the class is
> package-only visible, one could find this class in IDE "intellisense"
> suggest lists and be confused because there is no such class in the
> JSF spec. With the "_" prefix those classes should remain invisble, at
> least as long as the user does not look right into the jar. ;-)
>
> Manfred
>
>
>
> On 11/22/06, Mario Ivankovits <ma...@ops.co.at> wrote:
> > Hi!
> > > in myfaces-api we have the same;
> > > but nobody outside of myfaces-api uses them ;)
> > >
> > > so same should be true for shared as well...
> > I think those _ thingies were introduces before the shared comes to
> > live, so thats why we have them all around.
> > If we think this breaks our "naming convention" we should deprecate the
> > _ComponentUtils too and create a new ComponentUtils class.
> >
> > Then, you can delegate from _ComponentUtils to ComponentUtils.
> > *hehe* :-D hihi, lol
> >
> > Ciao,
> > Mario
> >
> >
>
--
Matthias Wessendorf
http://tinyurl.com/fmywh
further stuff:
blog: http://jroller.com/page/mwessendorf
mail: mwessendorf-at-gmail-dot-com
Re: findNestingForm
Posted by Manfred Geiler <ma...@gmail.com>.
Yep, those "_" classes where meant as internal classes and never for
public API-like use.
And if I remember right, they where all package private (you know,
those weird classes that lack the access modifier ;-) in the
beginning. Didn't realize they have been changed to public... Hmm
Of course there is no real need for the "_" prefix in the shared
classes. But in myfaces-api the prefix is a nice hint for the API
users that this class is *not* meant for *them*. Even if the class is
package-only visible, one could find this class in IDE "intellisense"
suggest lists and be confused because there is no such class in the
JSF spec. With the "_" prefix those classes should remain invisble, at
least as long as the user does not look right into the jar. ;-)
Manfred
On 11/22/06, Mario Ivankovits <ma...@ops.co.at> wrote:
> Hi!
> > in myfaces-api we have the same;
> > but nobody outside of myfaces-api uses them ;)
> >
> > so same should be true for shared as well...
> I think those _ thingies were introduces before the shared comes to
> live, so thats why we have them all around.
> If we think this breaks our "naming convention" we should deprecate the
> _ComponentUtils too and create a new ComponentUtils class.
>
> Then, you can delegate from _ComponentUtils to ComponentUtils.
> *hehe* :-D hihi, lol
>
> Ciao,
> Mario
>
>
Re: findNestingForm
Posted by Mario Ivankovits <ma...@ops.co.at>.
Hi!
> in myfaces-api we have the same;
> but nobody outside of myfaces-api uses them ;)
>
> so same should be true for shared as well...
I think those _ thingies were introduces before the shared comes to
live, so thats why we have them all around.
If we think this breaks our "naming convention" we should deprecate the
_ComponentUtils too and create a new ComponentUtils class.
Then, you can delegate from _ComponentUtils to ComponentUtils.
*hehe* :-D hihi, lol
Ciao,
Mario
Re: findNestingForm
Posted by Matthias Wessendorf <ma...@apache.org>.
in myfaces-api we have the same;
but nobody outside of myfaces-api uses them ;)
so same should be true for shared as well...
On 11/22/06, Matthias Wessendorf <ma...@apache.org> wrote:
> internally for me in that case only means inside the shared;
> I consider shared as an API
>
> so a *user* of shared shouldn't use _XXX
>
> -M
>
> On 11/22/06, Mario Ivankovits <ma...@ops.co.at> wrote:
> > Hi!
> > >> _ComponentUtils to RendererUtils ?
> > > Also why is the name starting with "_" ?
> > I think that was to express the fact that this is an "internal" utils
> > class. Not for public use.
> > You know, one of the major oddities in java, you can't have package and
> > sub-package private methods.
> >
> > Ciao,
> > Mario
> >
> >
>
>
> --
> Matthias Wessendorf
> http://tinyurl.com/fmywh
>
> further stuff:
> blog: http://jroller.com/page/mwessendorf
> mail: mwessendorf-at-gmail-dot-com
>
--
Matthias Wessendorf
http://tinyurl.com/fmywh
further stuff:
blog: http://jroller.com/page/mwessendorf
mail: mwessendorf-at-gmail-dot-com
Re: findNestingForm
Posted by Matthias Wessendorf <ma...@apache.org>.
internally for me in that case only means inside the shared;
I consider shared as an API
so a *user* of shared shouldn't use _XXX
-M
On 11/22/06, Mario Ivankovits <ma...@ops.co.at> wrote:
> Hi!
> >> _ComponentUtils to RendererUtils ?
> > Also why is the name starting with "_" ?
> I think that was to express the fact that this is an "internal" utils
> class. Not for public use.
> You know, one of the major oddities in java, you can't have package and
> sub-package private methods.
>
> Ciao,
> Mario
>
>
--
Matthias Wessendorf
http://tinyurl.com/fmywh
further stuff:
blog: http://jroller.com/page/mwessendorf
mail: mwessendorf-at-gmail-dot-com
Re: findNestingForm
Posted by Mario Ivankovits <ma...@ops.co.at>.
Hi!
>> _ComponentUtils to RendererUtils ?
> Also why is the name starting with "_" ?
I think that was to express the fact that this is an "internal" utils
class. Not for public use.
You know, one of the major oddities in java, you can't have package and
sub-package private methods.
Ciao,
Mario
Re: findNestingForm
Posted by Matthias Wessendorf <ma...@apache.org>.
On 11/20/06, Matthias Wessendorf <ma...@apache.org> wrote:
> What about moving getStringValue(Fcontext, VBinding) from
> _ComponentUtils to RendererUtils ?
I committed that change. If we really move the getStringValue() to
RendererUtils that would mean classes like AliasBean or ValidatorBase
are using RendererUtils. Which sounds to much like a util for a
renderer developer :)
But on the other hand the findNestingForm is much more related to
renderers and if we move only that function away, we have a class with
a single method.
Also why is the name starting with "_" ?
Thanks,
Matthias
> then I can *remove* that clazz, or at least set it as deprecated,
> since 3rd party can have dependency against it...
>
>
>
> On 11/20/06, Matthias Wessendorf <ma...@apache.org> wrote:
> > fixed only once :)
> >
> > I saw that other find method, when looking at TabbedPane renderer :)
> >
> > On 11/20/06, Martin Marinschek <ma...@gmail.com> wrote:
> > > Sure not - I thought you had fixed that already a while ago - don't
> > > remember. We might need it once in the API and once in shared? Two
> > > times in shared is once too much.
> > >
> > > regards,
> > >
> > > Martin
> > >
> > > On 11/19/06, Matthias Wessendorf <ma...@apache.org> wrote:
> > > > but not in two methods :)
> > > >
> > > > On 11/19/06, Martin Marinschek <ma...@gmail.com> wrote:
> > > > > Hi Matze,
> > > > >
> > > > > we could do both an instanceof, and as a failsafe method, a family
> > > > > check as well.
> > > > >
> > > > > regards,
> > > > >
> > > > > Martin
> > > > >
> > > > > On 11/18/06, Matthias Wessendorf <ma...@apache.org> wrote:
> > > > > > one more on that.
> > > > > >
> > > > > > since we only use "families" the *second* method is not able to work
> > > > > > with the struts-faces bridge lib
> > > > > >
> > > > > > (since they provide a new form component (and family))
> > > > > >
> > > > > > -M
> > > > > >
> > > > > > On 11/18/06, Matthias Wessendorf <ma...@apache.org> wrote:
> > > > > > > created issue and assigned to me:
> > > > > > >
> > > > > > > http://issues.apache.org/jira/browse/MYFACES-1496
> > > > > > >
> > > > > > > I prefer to remove the method in the _Com...... clazz
> > > > > > >
> > > > > > > -M
> > > > > > >
> > > > > > > On 11/17/06, Matthias Wessendorf <ma...@apache.org> wrote:
> > > > > > > > is there a reason, why we have the findNestingForm method twice?
> > > > > > > > with the same logic.
> > > > > > > >
> > > > > > > > I'd like to refactor that, if there is no real reason.
> > > > > > > >
> > > > > > > > -M
> > > > > > > >
> > > > > > > > --
> > > > > > > > Matthias Wessendorf
> > > > > > > > http://tinyurl.com/fmywh
> > > > > > > >
> > > > > > > > further stuff:
> > > > > > > > blog: http://jroller.com/page/mwessendorf
> > > > > > > > mail: mwessendorf-at-gmail-dot-com
> > > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > --
> > > > > > > Matthias Wessendorf
> > > > > > > http://tinyurl.com/fmywh
> > > > > > >
> > > > > > > further stuff:
> > > > > > > blog: http://jroller.com/page/mwessendorf
> > > > > > > mail: mwessendorf-at-gmail-dot-com
> > > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Matthias Wessendorf
> > > > > > http://tinyurl.com/fmywh
> > > > > >
> > > > > > further stuff:
> > > > > > blog: http://jroller.com/page/mwessendorf
> > > > > > mail: mwessendorf-at-gmail-dot-com
> > > > > >
> > > > >
> > > > >
> > > > > --
> > > > >
> > > > > http://www.irian.at
> > > > >
> > > > > Your JSF powerhouse -
> > > > > JSF Consulting, Development and
> > > > > Courses in English and German
> > > > >
> > > > > Professional Support for Apache MyFaces
> > > > >
> > > >
> > > >
> > > > --
> > > > Matthias Wessendorf
> > > > http://tinyurl.com/fmywh
> > > >
> > > > further stuff:
> > > > blog: http://jroller.com/page/mwessendorf
> > > > mail: mwessendorf-at-gmail-dot-com
> > > >
> > >
> > >
> > > --
> > >
> > > http://www.irian.at
> > >
> > > Your JSF powerhouse -
> > > JSF Consulting, Development and
> > > Courses in English and German
> > >
> > > Professional Support for Apache MyFaces
> > >
> >
> >
> > --
> > Matthias Wessendorf
> > http://tinyurl.com/fmywh
> >
> > further stuff:
> > blog: http://jroller.com/page/mwessendorf
> > mail: mwessendorf-at-gmail-dot-com
> >
>
>
> --
> Matthias Wessendorf
> http://tinyurl.com/fmywh
>
> further stuff:
> blog: http://jroller.com/page/mwessendorf
> mail: mwessendorf-at-gmail-dot-com
>
--
Matthias Wessendorf
http://tinyurl.com/fmywh
further stuff:
blog: http://jroller.com/page/mwessendorf
mail: mwessendorf-at-gmail-dot-com
Re: findNestingForm
Posted by Matthias Wessendorf <ma...@apache.org>.
What about moving getStringValue(Fcontext, VBinding) from
_ComponentUtils to RendererUtils ?
then I can *remove* that clazz, or at least set it as deprecated,
since 3rd party can have dependency against it...
On 11/20/06, Matthias Wessendorf <ma...@apache.org> wrote:
> fixed only once :)
>
> I saw that other find method, when looking at TabbedPane renderer :)
>
> On 11/20/06, Martin Marinschek <ma...@gmail.com> wrote:
> > Sure not - I thought you had fixed that already a while ago - don't
> > remember. We might need it once in the API and once in shared? Two
> > times in shared is once too much.
> >
> > regards,
> >
> > Martin
> >
> > On 11/19/06, Matthias Wessendorf <ma...@apache.org> wrote:
> > > but not in two methods :)
> > >
> > > On 11/19/06, Martin Marinschek <ma...@gmail.com> wrote:
> > > > Hi Matze,
> > > >
> > > > we could do both an instanceof, and as a failsafe method, a family
> > > > check as well.
> > > >
> > > > regards,
> > > >
> > > > Martin
> > > >
> > > > On 11/18/06, Matthias Wessendorf <ma...@apache.org> wrote:
> > > > > one more on that.
> > > > >
> > > > > since we only use "families" the *second* method is not able to work
> > > > > with the struts-faces bridge lib
> > > > >
> > > > > (since they provide a new form component (and family))
> > > > >
> > > > > -M
> > > > >
> > > > > On 11/18/06, Matthias Wessendorf <ma...@apache.org> wrote:
> > > > > > created issue and assigned to me:
> > > > > >
> > > > > > http://issues.apache.org/jira/browse/MYFACES-1496
> > > > > >
> > > > > > I prefer to remove the method in the _Com...... clazz
> > > > > >
> > > > > > -M
> > > > > >
> > > > > > On 11/17/06, Matthias Wessendorf <ma...@apache.org> wrote:
> > > > > > > is there a reason, why we have the findNestingForm method twice?
> > > > > > > with the same logic.
> > > > > > >
> > > > > > > I'd like to refactor that, if there is no real reason.
> > > > > > >
> > > > > > > -M
> > > > > > >
> > > > > > > --
> > > > > > > Matthias Wessendorf
> > > > > > > http://tinyurl.com/fmywh
> > > > > > >
> > > > > > > further stuff:
> > > > > > > blog: http://jroller.com/page/mwessendorf
> > > > > > > mail: mwessendorf-at-gmail-dot-com
> > > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Matthias Wessendorf
> > > > > > http://tinyurl.com/fmywh
> > > > > >
> > > > > > further stuff:
> > > > > > blog: http://jroller.com/page/mwessendorf
> > > > > > mail: mwessendorf-at-gmail-dot-com
> > > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Matthias Wessendorf
> > > > > http://tinyurl.com/fmywh
> > > > >
> > > > > further stuff:
> > > > > blog: http://jroller.com/page/mwessendorf
> > > > > mail: mwessendorf-at-gmail-dot-com
> > > > >
> > > >
> > > >
> > > > --
> > > >
> > > > http://www.irian.at
> > > >
> > > > Your JSF powerhouse -
> > > > JSF Consulting, Development and
> > > > Courses in English and German
> > > >
> > > > Professional Support for Apache MyFaces
> > > >
> > >
> > >
> > > --
> > > Matthias Wessendorf
> > > http://tinyurl.com/fmywh
> > >
> > > further stuff:
> > > blog: http://jroller.com/page/mwessendorf
> > > mail: mwessendorf-at-gmail-dot-com
> > >
> >
> >
> > --
> >
> > http://www.irian.at
> >
> > Your JSF powerhouse -
> > JSF Consulting, Development and
> > Courses in English and German
> >
> > Professional Support for Apache MyFaces
> >
>
>
> --
> Matthias Wessendorf
> http://tinyurl.com/fmywh
>
> further stuff:
> blog: http://jroller.com/page/mwessendorf
> mail: mwessendorf-at-gmail-dot-com
>
--
Matthias Wessendorf
http://tinyurl.com/fmywh
further stuff:
blog: http://jroller.com/page/mwessendorf
mail: mwessendorf-at-gmail-dot-com
Re: findNestingForm
Posted by Matthias Wessendorf <ma...@apache.org>.
fixed only once :)
I saw that other find method, when looking at TabbedPane renderer :)
On 11/20/06, Martin Marinschek <ma...@gmail.com> wrote:
> Sure not - I thought you had fixed that already a while ago - don't
> remember. We might need it once in the API and once in shared? Two
> times in shared is once too much.
>
> regards,
>
> Martin
>
> On 11/19/06, Matthias Wessendorf <ma...@apache.org> wrote:
> > but not in two methods :)
> >
> > On 11/19/06, Martin Marinschek <ma...@gmail.com> wrote:
> > > Hi Matze,
> > >
> > > we could do both an instanceof, and as a failsafe method, a family
> > > check as well.
> > >
> > > regards,
> > >
> > > Martin
> > >
> > > On 11/18/06, Matthias Wessendorf <ma...@apache.org> wrote:
> > > > one more on that.
> > > >
> > > > since we only use "families" the *second* method is not able to work
> > > > with the struts-faces bridge lib
> > > >
> > > > (since they provide a new form component (and family))
> > > >
> > > > -M
> > > >
> > > > On 11/18/06, Matthias Wessendorf <ma...@apache.org> wrote:
> > > > > created issue and assigned to me:
> > > > >
> > > > > http://issues.apache.org/jira/browse/MYFACES-1496
> > > > >
> > > > > I prefer to remove the method in the _Com...... clazz
> > > > >
> > > > > -M
> > > > >
> > > > > On 11/17/06, Matthias Wessendorf <ma...@apache.org> wrote:
> > > > > > is there a reason, why we have the findNestingForm method twice?
> > > > > > with the same logic.
> > > > > >
> > > > > > I'd like to refactor that, if there is no real reason.
> > > > > >
> > > > > > -M
> > > > > >
> > > > > > --
> > > > > > Matthias Wessendorf
> > > > > > http://tinyurl.com/fmywh
> > > > > >
> > > > > > further stuff:
> > > > > > blog: http://jroller.com/page/mwessendorf
> > > > > > mail: mwessendorf-at-gmail-dot-com
> > > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Matthias Wessendorf
> > > > > http://tinyurl.com/fmywh
> > > > >
> > > > > further stuff:
> > > > > blog: http://jroller.com/page/mwessendorf
> > > > > mail: mwessendorf-at-gmail-dot-com
> > > > >
> > > >
> > > >
> > > > --
> > > > Matthias Wessendorf
> > > > http://tinyurl.com/fmywh
> > > >
> > > > further stuff:
> > > > blog: http://jroller.com/page/mwessendorf
> > > > mail: mwessendorf-at-gmail-dot-com
> > > >
> > >
> > >
> > > --
> > >
> > > http://www.irian.at
> > >
> > > Your JSF powerhouse -
> > > JSF Consulting, Development and
> > > Courses in English and German
> > >
> > > Professional Support for Apache MyFaces
> > >
> >
> >
> > --
> > Matthias Wessendorf
> > http://tinyurl.com/fmywh
> >
> > further stuff:
> > blog: http://jroller.com/page/mwessendorf
> > mail: mwessendorf-at-gmail-dot-com
> >
>
>
> --
>
> http://www.irian.at
>
> Your JSF powerhouse -
> JSF Consulting, Development and
> Courses in English and German
>
> Professional Support for Apache MyFaces
>
--
Matthias Wessendorf
http://tinyurl.com/fmywh
further stuff:
blog: http://jroller.com/page/mwessendorf
mail: mwessendorf-at-gmail-dot-com
Re: findNestingForm
Posted by Martin Marinschek <ma...@gmail.com>.
Sure not - I thought you had fixed that already a while ago - don't
remember. We might need it once in the API and once in shared? Two
times in shared is once too much.
regards,
Martin
On 11/19/06, Matthias Wessendorf <ma...@apache.org> wrote:
> but not in two methods :)
>
> On 11/19/06, Martin Marinschek <ma...@gmail.com> wrote:
> > Hi Matze,
> >
> > we could do both an instanceof, and as a failsafe method, a family
> > check as well.
> >
> > regards,
> >
> > Martin
> >
> > On 11/18/06, Matthias Wessendorf <ma...@apache.org> wrote:
> > > one more on that.
> > >
> > > since we only use "families" the *second* method is not able to work
> > > with the struts-faces bridge lib
> > >
> > > (since they provide a new form component (and family))
> > >
> > > -M
> > >
> > > On 11/18/06, Matthias Wessendorf <ma...@apache.org> wrote:
> > > > created issue and assigned to me:
> > > >
> > > > http://issues.apache.org/jira/browse/MYFACES-1496
> > > >
> > > > I prefer to remove the method in the _Com...... clazz
> > > >
> > > > -M
> > > >
> > > > On 11/17/06, Matthias Wessendorf <ma...@apache.org> wrote:
> > > > > is there a reason, why we have the findNestingForm method twice?
> > > > > with the same logic.
> > > > >
> > > > > I'd like to refactor that, if there is no real reason.
> > > > >
> > > > > -M
> > > > >
> > > > > --
> > > > > Matthias Wessendorf
> > > > > http://tinyurl.com/fmywh
> > > > >
> > > > > further stuff:
> > > > > blog: http://jroller.com/page/mwessendorf
> > > > > mail: mwessendorf-at-gmail-dot-com
> > > > >
> > > >
> > > >
> > > > --
> > > > Matthias Wessendorf
> > > > http://tinyurl.com/fmywh
> > > >
> > > > further stuff:
> > > > blog: http://jroller.com/page/mwessendorf
> > > > mail: mwessendorf-at-gmail-dot-com
> > > >
> > >
> > >
> > > --
> > > Matthias Wessendorf
> > > http://tinyurl.com/fmywh
> > >
> > > further stuff:
> > > blog: http://jroller.com/page/mwessendorf
> > > mail: mwessendorf-at-gmail-dot-com
> > >
> >
> >
> > --
> >
> > http://www.irian.at
> >
> > Your JSF powerhouse -
> > JSF Consulting, Development and
> > Courses in English and German
> >
> > Professional Support for Apache MyFaces
> >
>
>
> --
> Matthias Wessendorf
> http://tinyurl.com/fmywh
>
> further stuff:
> blog: http://jroller.com/page/mwessendorf
> mail: mwessendorf-at-gmail-dot-com
>
--
http://www.irian.at
Your JSF powerhouse -
JSF Consulting, Development and
Courses in English and German
Professional Support for Apache MyFaces
Re: findNestingForm
Posted by Matthias Wessendorf <ma...@apache.org>.
but not in two methods :)
On 11/19/06, Martin Marinschek <ma...@gmail.com> wrote:
> Hi Matze,
>
> we could do both an instanceof, and as a failsafe method, a family
> check as well.
>
> regards,
>
> Martin
>
> On 11/18/06, Matthias Wessendorf <ma...@apache.org> wrote:
> > one more on that.
> >
> > since we only use "families" the *second* method is not able to work
> > with the struts-faces bridge lib
> >
> > (since they provide a new form component (and family))
> >
> > -M
> >
> > On 11/18/06, Matthias Wessendorf <ma...@apache.org> wrote:
> > > created issue and assigned to me:
> > >
> > > http://issues.apache.org/jira/browse/MYFACES-1496
> > >
> > > I prefer to remove the method in the _Com...... clazz
> > >
> > > -M
> > >
> > > On 11/17/06, Matthias Wessendorf <ma...@apache.org> wrote:
> > > > is there a reason, why we have the findNestingForm method twice?
> > > > with the same logic.
> > > >
> > > > I'd like to refactor that, if there is no real reason.
> > > >
> > > > -M
> > > >
> > > > --
> > > > Matthias Wessendorf
> > > > http://tinyurl.com/fmywh
> > > >
> > > > further stuff:
> > > > blog: http://jroller.com/page/mwessendorf
> > > > mail: mwessendorf-at-gmail-dot-com
> > > >
> > >
> > >
> > > --
> > > Matthias Wessendorf
> > > http://tinyurl.com/fmywh
> > >
> > > further stuff:
> > > blog: http://jroller.com/page/mwessendorf
> > > mail: mwessendorf-at-gmail-dot-com
> > >
> >
> >
> > --
> > Matthias Wessendorf
> > http://tinyurl.com/fmywh
> >
> > further stuff:
> > blog: http://jroller.com/page/mwessendorf
> > mail: mwessendorf-at-gmail-dot-com
> >
>
>
> --
>
> http://www.irian.at
>
> Your JSF powerhouse -
> JSF Consulting, Development and
> Courses in English and German
>
> Professional Support for Apache MyFaces
>
--
Matthias Wessendorf
http://tinyurl.com/fmywh
further stuff:
blog: http://jroller.com/page/mwessendorf
mail: mwessendorf-at-gmail-dot-com
Re: findNestingForm
Posted by Martin Marinschek <ma...@gmail.com>.
Hi Matze,
we could do both an instanceof, and as a failsafe method, a family
check as well.
regards,
Martin
On 11/18/06, Matthias Wessendorf <ma...@apache.org> wrote:
> one more on that.
>
> since we only use "families" the *second* method is not able to work
> with the struts-faces bridge lib
>
> (since they provide a new form component (and family))
>
> -M
>
> On 11/18/06, Matthias Wessendorf <ma...@apache.org> wrote:
> > created issue and assigned to me:
> >
> > http://issues.apache.org/jira/browse/MYFACES-1496
> >
> > I prefer to remove the method in the _Com...... clazz
> >
> > -M
> >
> > On 11/17/06, Matthias Wessendorf <ma...@apache.org> wrote:
> > > is there a reason, why we have the findNestingForm method twice?
> > > with the same logic.
> > >
> > > I'd like to refactor that, if there is no real reason.
> > >
> > > -M
> > >
> > > --
> > > Matthias Wessendorf
> > > http://tinyurl.com/fmywh
> > >
> > > further stuff:
> > > blog: http://jroller.com/page/mwessendorf
> > > mail: mwessendorf-at-gmail-dot-com
> > >
> >
> >
> > --
> > Matthias Wessendorf
> > http://tinyurl.com/fmywh
> >
> > further stuff:
> > blog: http://jroller.com/page/mwessendorf
> > mail: mwessendorf-at-gmail-dot-com
> >
>
>
> --
> Matthias Wessendorf
> http://tinyurl.com/fmywh
>
> further stuff:
> blog: http://jroller.com/page/mwessendorf
> mail: mwessendorf-at-gmail-dot-com
>
--
http://www.irian.at
Your JSF powerhouse -
JSF Consulting, Development and
Courses in English and German
Professional Support for Apache MyFaces
Re: findNestingForm
Posted by Matthias Wessendorf <ma...@apache.org>.
one more on that.
since we only use "families" the *second* method is not able to work
with the struts-faces bridge lib
(since they provide a new form component (and family))
-M
On 11/18/06, Matthias Wessendorf <ma...@apache.org> wrote:
> created issue and assigned to me:
>
> http://issues.apache.org/jira/browse/MYFACES-1496
>
> I prefer to remove the method in the _Com...... clazz
>
> -M
>
> On 11/17/06, Matthias Wessendorf <ma...@apache.org> wrote:
> > is there a reason, why we have the findNestingForm method twice?
> > with the same logic.
> >
> > I'd like to refactor that, if there is no real reason.
> >
> > -M
> >
> > --
> > Matthias Wessendorf
> > http://tinyurl.com/fmywh
> >
> > further stuff:
> > blog: http://jroller.com/page/mwessendorf
> > mail: mwessendorf-at-gmail-dot-com
> >
>
>
> --
> Matthias Wessendorf
> http://tinyurl.com/fmywh
>
> further stuff:
> blog: http://jroller.com/page/mwessendorf
> mail: mwessendorf-at-gmail-dot-com
>
--
Matthias Wessendorf
http://tinyurl.com/fmywh
further stuff:
blog: http://jroller.com/page/mwessendorf
mail: mwessendorf-at-gmail-dot-com
Re: findNestingForm
Posted by Matthias Wessendorf <ma...@apache.org>.
created issue and assigned to me:
http://issues.apache.org/jira/browse/MYFACES-1496
I prefer to remove the method in the _Com...... clazz
-M
On 11/17/06, Matthias Wessendorf <ma...@apache.org> wrote:
> is there a reason, why we have the findNestingForm method twice?
> with the same logic.
>
> I'd like to refactor that, if there is no real reason.
>
> -M
>
> --
> Matthias Wessendorf
> http://tinyurl.com/fmywh
>
> further stuff:
> blog: http://jroller.com/page/mwessendorf
> mail: mwessendorf-at-gmail-dot-com
>
--
Matthias Wessendorf
http://tinyurl.com/fmywh
further stuff:
blog: http://jroller.com/page/mwessendorf
mail: mwessendorf-at-gmail-dot-com