You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@edgent.apache.org by Julian Feinauer <j....@pragmaticminds.de> on 2019/03/07 16:48:25 UTC

Maven Artifact refactoring

Hey all,

today we started to check and clean the maven modules a bit.
I observed that in the api/ module there are a lot of submodules (which all build to jars).
And all submodules contain only one package and a hand full of classes.

This leads to many other modules referencing two or more of these api modules.
This adds, to my perspective, a lot of noise to the poms and makes it very unintuitive to use these modules.

So I prepared a branch where I merged all these “sub-api” modules into the api module to have only one api dependency.
The branch is https://github.com/apache/incubator-edgent/tree/one-module-for-api.

Are there any objections to that, otherwise I would like to merge that.

Julian

Re: Maven Artifact refactoring

Posted by Gayashan Amarasinghe <ga...@gmail.com>.
+1

It makes sense to get rid of this clutter.

Best,
Gayashan


On Tue, Mar 12, 2019 at 2:38 AM Julian Feinauer <
j.feinauer@pragmaticminds.de> wrote:

> Hi all,
>
> as I got no responses at all, I'll merge my PR.
>
> Julian
>
> Am 07.03.19, 17:48 schrieb "Julian Feinauer" <
> j.feinauer@pragmaticminds.de>:
>
>     Hey all,
>
>     today we started to check and clean the maven modules a bit.
>     I observed that in the api/ module there are a lot of submodules
> (which all build to jars).
>     And all submodules contain only one package and a hand full of classes.
>
>     This leads to many other modules referencing two or more of these api
> modules.
>     This adds, to my perspective, a lot of noise to the poms and makes it
> very unintuitive to use these modules.
>
>     So I prepared a branch where I merged all these “sub-api” modules into
> the api module to have only one api dependency.
>     The branch is
> https://github.com/apache/incubator-edgent/tree/one-module-for-api.
>
>     Are there any objections to that, otherwise I would like to merge that.
>
>     Julian
>
>
>

Re: Maven Artifact refactoring

Posted by Julian Feinauer <j....@pragmaticminds.de>.
Hi all,

as I got no responses at all, I'll merge my PR.

Julian

Am 07.03.19, 17:48 schrieb "Julian Feinauer" <j....@pragmaticminds.de>:

    Hey all,
    
    today we started to check and clean the maven modules a bit.
    I observed that in the api/ module there are a lot of submodules (which all build to jars).
    And all submodules contain only one package and a hand full of classes.
    
    This leads to many other modules referencing two or more of these api modules.
    This adds, to my perspective, a lot of noise to the poms and makes it very unintuitive to use these modules.
    
    So I prepared a branch where I merged all these “sub-api” modules into the api module to have only one api dependency.
    The branch is https://github.com/apache/incubator-edgent/tree/one-module-for-api.
    
    Are there any objections to that, otherwise I would like to merge that.
    
    Julian