You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "acvictor (via GitHub)" <gi...@apache.org> on 2026/02/20 15:05:09 UTC
[PR] [VL] Allocate VarChar sub-messages on protobuf arena in VeloxToSubstraitExpr [incubator-gluten]
acvictor opened a new pull request, #11636:
URL: https://github.com/apache/incubator-gluten/pull/11636
## What changes are proposed in this pull request?
This PR replaces `new` allocation of `VarChar` sub-messages with `Arena::CreateMessage` to match the arena-allocated parent in `VeloxToSubstraitExpr.cc`. When a protobuf message is arena-allocated, its destructor never runs so children attached via `set_allocated_*` that were heap-allocated with `new` are never deleted. Every other sub-message in this file already uses
`Arena::CreateMessage` correctly and `VarChar` was the only exception.
## How was this patch tested?
Existing UTs
## Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Allocate VarChar sub-messages on protobuf arena in VeloxToSubstraitExpr [incubator-gluten]
Posted by "acvictor (via GitHub)" <gi...@apache.org>.
acvictor commented on PR #11636:
URL: https://github.com/apache/incubator-gluten/pull/11636#issuecomment-4021290901
@rui-mo thanks for the review and approvals! Please let me know if there’s anything else needed from my side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Allocate VarChar sub-messages on protobuf arena in VeloxToSubstraitExpr [incubator-gluten]
Posted by "acvictor (via GitHub)" <gi...@apache.org>.
acvictor commented on PR #11636:
URL: https://github.com/apache/incubator-gluten/pull/11636#issuecomment-3977048888
@rui-mo can you please review this PR? Thanks in advance!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Allocate VarChar sub-messages on protobuf arena in VeloxToSubstraitExpr [incubator-gluten]
Posted by "rui-mo (via GitHub)" <gi...@apache.org>.
rui-mo merged PR #11636:
URL: https://github.com/apache/incubator-gluten/pull/11636
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org