You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "aweisberg (via GitHub)" <gi...@apache.org> on 2024/11/06 19:47:52 UTC
[PR] Miscellaneous migration test fixes [cassandra]
aweisberg opened a new pull request, #3660:
URL: https://github.com/apache/cassandra/pull/3660
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Miscellaneous migration test fixes [cassandra]
Posted by "dcapwell (via GitHub)" <gi...@apache.org>.
dcapwell commented on code in PR #3660:
URL: https://github.com/apache/cassandra/pull/3660#discussion_r1831624495
##########
test/distributed/org/apache/cassandra/distributed/test/accord/AccordMigrationTest.java:
##########
@@ -373,7 +376,7 @@ private static void validateKeyMigrations(List<Pair<ByteBuffer, UUID>> expectedM
assertTrue(tableMessage, foundKey);
}
});
- }
+ //}
Review Comment:
if you are removing the loop can you fix the formatting?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Miscellaneous migration test fixes [cassandra]
Posted by "aweisberg (via GitHub)" <gi...@apache.org>.
aweisberg merged PR #3660:
URL: https://github.com/apache/cassandra/pull/3660
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Miscellaneous migration test fixes [cassandra]
Posted by "dcapwell (via GitHub)" <gi...@apache.org>.
dcapwell commented on code in PR #3660:
URL: https://github.com/apache/cassandra/pull/3660#discussion_r1831623540
##########
src/java/org/apache/cassandra/service/accord/AccordService.java:
##########
@@ -624,13 +624,13 @@ public IVerbHandler<? extends Reply> responseHandler()
AsyncResult<TxnId> asyncResult = syncPoint == null
? Barrier.barrier(node, keysOrRanges, route, epoch, barrierType)
: Barrier.barrier(node, keysOrRanges, route, epoch, barrierType, syncPoint);
+ long deadlineNanos = requestTime.startedAtNanos() + timeoutNanos;
+ TxnId txnId = AsyncChains.getBlocking(asyncResult, deadlineNanos - nanoTime(), NANOSECONDS);
if (keysOrRanges.domain() == Key)
{
PartitionKey key = (PartitionKey)keysOrRanges.get(0);
- asyncResult.accept(txnId -> maybeSaveAccordKeyMigrationLocally(key, Epoch.create(txnId.epoch())));
Review Comment:
`.accept` without a `.begin` means we never trigger that callback... this has been a constant pain point for `AsyncChain`....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org