You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2019/12/27 19:27:21 UTC
[GitHub] [incubator-iceberg] rdblue commented on issue #688: [ISSUE #672]
Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog'
rdblue commented on issue #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog'
URL: https://github.com/apache/incubator-iceberg/pull/688#issuecomment-569330909
@shawnding, I've noticed that you've missed several review comments, like removing unnecessary `toString` calls when concatenating strings or formatting error messages. Please go back through the review comments to make sure you've made all of the needed changes. It's not very fun to ask for the same changes each time I take a look at this PR. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org