You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Budnik <ab...@mesosphere.com> on 2017/06/02 11:53:50 UTC
Re: Review Request 59605: Used glog for logging in executors.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59605/
-----------------------------------------------------------
(Updated June 2, 2017, 11:53 a.m.)
Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Benjamin Mahler, and Till Toenshoff.
Summary (updated)
-----------------
Used glog for logging in executors.
Bugs: MESOS-6961
https://issues.apache.org/jira/browse/MESOS-6961
Repository: mesos
Description (updated)
-------
The rule for choosing between glog and cout is described by MESOS-7586.
Diffs (updated)
-----
src/docker/executor.cpp 464a74859e0f477ec2e5525a5fc726ea420a00a2
src/launcher/default_executor.cpp 1a60e3bb2b0e8312b349cddedb4cd55716c1b574
src/launcher/executor.cpp 9ac3c3d84c0ec47954c5c72228ad0b8795ff3eec
Diff: https://reviews.apache.org/r/59605/diff/2/
Changes: https://reviews.apache.org/r/59605/diff/1-2/
Testing
-------
1. make check (mac os x 10.12, fedora 25)
2. jenkins: https://jenkins.mesosphere.com/service/jenkins/job/mesos/job/Mesos_CI-build/1087/
3. I've modified NoTaskKillingCapability from command_executor_tests.cpp to launch command "sleep 0.1" (as well as "sleep 0"),
then to wait for a task completion. The test was launched in an endless loop:
GLOG_v=1 ./bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure --gtest_filter="HTTPCommandExecutor/CommandExecutorTest.NoTaskKillingCapability/0" --verbose
I've run this test multiple times for a while both on mac os and linux (gru1.hw.ca1.mesosphere.com).
Race condition problem described in a jira ticket wasn't reproduced.
Thanks,
Andrei Budnik
Re: Review Request 59605: Used glog for logging in executors.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59605/#review176759
-----------------------------------------------------------
Patch looks great!
Reviews applied: [59605]
Passed command: support\windows-build.bat
- Mesos Reviewbot Windows
On June 2, 2017, 1:53 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59605/
> -----------------------------------------------------------
>
> (Updated June 2, 2017, 1:53 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Benjamin Mahler, and Till Toenshoff.
>
>
> Bugs: MESOS-6961
> https://issues.apache.org/jira/browse/MESOS-6961
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The rule for choosing between glog and cout is described by MESOS-7586.
>
>
> Diffs
> -----
>
> src/docker/executor.cpp 464a74859e0f477ec2e5525a5fc726ea420a00a2
> src/launcher/default_executor.cpp 1a60e3bb2b0e8312b349cddedb4cd55716c1b574
> src/launcher/executor.cpp 9ac3c3d84c0ec47954c5c72228ad0b8795ff3eec
>
>
> Diff: https://reviews.apache.org/r/59605/diff/2/
>
>
> Testing
> -------
>
> 1. make check (mac os x 10.12, fedora 25)
> 2. jenkins: https://jenkins.mesosphere.com/service/jenkins/job/mesos/job/Mesos_CI-build/1087/
>
> 3. I've modified NoTaskKillingCapability from command_executor_tests.cpp to launch command "sleep 0.1" (as well as "sleep 0"),
> then to wait for a task completion. The test was launched in an endless loop:
>
> GLOG_v=1 ./bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure --gtest_filter="HTTPCommandExecutor/CommandExecutorTest.NoTaskKillingCapability/0" --verbose
>
> I've run this test multiple times for a while both on mac os and linux (gru1.hw.ca1.mesosphere.com).
> Race condition problem described in a jira ticket wasn't reproduced.
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 59605: Used glog for logging in executors.
Posted by Andrei Budnik <ab...@mesosphere.com>.
> On June 2, 2017, 2:16 p.m., Alexander Rukletsov wrote:
> > src/launcher/default_executor.cpp
> > Line 1365 (original), 1367-1369 (patched)
> > <https://reviews.apache.org/r/59605/diff/2/?file=1740320#file1740320line1367>
> >
> > Not yours, but could you also print warnings as we do it for example for command executor? In a separate patch, please.
> > ```
> > // Log any flag warnings (after logging is initialized).
> > foreach (const flags::Warning& warning, load->warnings) {
> > LOG(WARNING) << warning.message;
> > }
> > ```
https://reviews.apache.org/r/59837/
- Andrei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59605/#review176771
-----------------------------------------------------------
On June 6, 2017, 11:24 a.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59605/
> -----------------------------------------------------------
>
> (Updated June 6, 2017, 11:24 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Benjamin Mahler, and Till Toenshoff.
>
>
> Bugs: MESOS-6961
> https://issues.apache.org/jira/browse/MESOS-6961
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The rule for choosing between glog and cout is described by MESOS-7586.
>
>
> Diffs
> -----
>
> src/docker/executor.cpp 464a74859e0f477ec2e5525a5fc726ea420a00a2
> src/launcher/default_executor.cpp 1a60e3bb2b0e8312b349cddedb4cd55716c1b574
> src/launcher/executor.cpp 9ac3c3d84c0ec47954c5c72228ad0b8795ff3eec
>
>
> Diff: https://reviews.apache.org/r/59605/diff/4/
>
>
> Testing
> -------
>
> 1. make check (mac os x 10.12, fedora 25)
> 2. jenkins: https://jenkins.mesosphere.com/service/jenkins/job/mesos/job/Mesos_CI-build/1087/
>
> 3. I've temporarily modified NoTaskKillingCapability from command_executor_tests.cpp to launch command "sleep 0.1" (as well as "sleep 0"),
> then to wait for a task completion. The test was launched in an endless loop:
>
> GLOG_v=1 ./bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure --gtest_filter="HTTPCommandExecutor/CommandExecutorTest.NoTaskKillingCapability/0" --verbose
>
> I've run this test multiple times for a while both on mac os and Fedora linux. Race condition problem described in a jira ticket wasn't reproduced.
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 59605: Used glog for logging in executors.
Posted by Andrei Budnik <ab...@mesosphere.com>.
> On June 2, 2017, 2:16 p.m., Alexander Rukletsov wrote:
> > src/docker/executor.cpp
> > Lines 747-750 (original), 747-750 (patched)
> > <https://reviews.apache.org/r/59605/diff/2/?file=1740319#file1740319line747>
> >
> > We should probably move this higher up before initializing logging, as we do in other executors.
Fixed.
> On June 2, 2017, 2:16 p.m., Alexander Rukletsov wrote:
> > src/docker/executor.cpp
> > Lines 752-770 (original), 752-770 (patched)
> > <https://reviews.apache.org/r/59605/diff/2/?file=1740319#file1740319line752>
> >
> > This looks like validation of flags, which is probably should be done before we initialize logging for consistency.
Fixed: used EXIT(EXIT_FAILURE) according to https://issues.apache.org/jira/browse/MESOS-7586
> On June 2, 2017, 2:16 p.m., Alexander Rukletsov wrote:
> > src/docker/executor.cpp
> > Lines 772-800 (original), 772-800 (patched)
> > <https://reviews.apache.org/r/59605/diff/2/?file=1740319#file1740319line772>
> >
> > I'd say this can use `EXIT(EXIT_FAILURE) << `
Fixed.
> On June 2, 2017, 2:16 p.m., Alexander Rukletsov wrote:
> > src/docker/executor.cpp
> > Lines 814-816 (original), 814-816 (patched)
> > <https://reviews.apache.org/r/59605/diff/2/?file=1740319#file1740319line814>
> >
> > Looks like we use `EXIT(EXIT_FAILURE)` in similar cases in other executors.
Fixed.
- Andrei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59605/#review176771
-----------------------------------------------------------
On June 2, 2017, 4:18 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59605/
> -----------------------------------------------------------
>
> (Updated June 2, 2017, 4:18 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Benjamin Mahler, and Till Toenshoff.
>
>
> Bugs: MESOS-6961
> https://issues.apache.org/jira/browse/MESOS-6961
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The rule for choosing between glog and cout is described by MESOS-7586.
>
>
> Diffs
> -----
>
> src/docker/executor.cpp 464a74859e0f477ec2e5525a5fc726ea420a00a2
> src/launcher/default_executor.cpp 1a60e3bb2b0e8312b349cddedb4cd55716c1b574
> src/launcher/executor.cpp 9ac3c3d84c0ec47954c5c72228ad0b8795ff3eec
>
>
> Diff: https://reviews.apache.org/r/59605/diff/3/
>
>
> Testing
> -------
>
> 1. make check (mac os x 10.12, fedora 25)
> 2. jenkins: https://jenkins.mesosphere.com/service/jenkins/job/mesos/job/Mesos_CI-build/1087/
>
> 3. I've temporarily modified NoTaskKillingCapability from command_executor_tests.cpp to launch command "sleep 0.1" (as well as "sleep 0"),
> then to wait for a task completion. The test was launched in an endless loop:
>
> GLOG_v=1 ./bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure --gtest_filter="HTTPCommandExecutor/CommandExecutorTest.NoTaskKillingCapability/0" --verbose
>
> I've run this test multiple times for a while both on mac os and Fedora linux. Race condition problem described in a jira ticket wasn't reproduced.
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 59605: Used glog for logging in executors.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59605/#review176771
-----------------------------------------------------------
src/docker/executor.cpp
Lines 747-750 (original), 747-750 (patched)
<https://reviews.apache.org/r/59605/#comment250239>
We should probably move this higher up before initializing logging, as we do in other executors.
src/docker/executor.cpp
Lines 752-770 (original), 752-770 (patched)
<https://reviews.apache.org/r/59605/#comment250240>
This looks like validation of flags, which is probably should be done before we initialize logging for consistency.
src/docker/executor.cpp
Lines 772-800 (original), 772-800 (patched)
<https://reviews.apache.org/r/59605/#comment250241>
I'd say this can use `EXIT(EXIT_FAILURE) << `
src/docker/executor.cpp
Lines 814-816 (original), 814-816 (patched)
<https://reviews.apache.org/r/59605/#comment250242>
Looks like we use `EXIT(EXIT_FAILURE)` in similar cases in other executors.
src/launcher/default_executor.cpp
Line 1365 (original), 1367-1369 (patched)
<https://reviews.apache.org/r/59605/#comment250238>
Not yours, but could you also print warnings as we do it for example for command executor? In a separate patch, please.
```
// Log any flag warnings (after logging is initialized).
foreach (const flags::Warning& warning, load->warnings) {
LOG(WARNING) << warning.message;
}
```
- Alexander Rukletsov
On June 2, 2017, 1:35 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59605/
> -----------------------------------------------------------
>
> (Updated June 2, 2017, 1:35 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Benjamin Mahler, and Till Toenshoff.
>
>
> Bugs: MESOS-6961
> https://issues.apache.org/jira/browse/MESOS-6961
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The rule for choosing between glog and cout is described by MESOS-7586.
>
>
> Diffs
> -----
>
> src/docker/executor.cpp 464a74859e0f477ec2e5525a5fc726ea420a00a2
> src/launcher/default_executor.cpp 1a60e3bb2b0e8312b349cddedb4cd55716c1b574
> src/launcher/executor.cpp 9ac3c3d84c0ec47954c5c72228ad0b8795ff3eec
>
>
> Diff: https://reviews.apache.org/r/59605/diff/2/
>
>
> Testing
> -------
>
> 1. make check (mac os x 10.12, fedora 25)
> 2. jenkins: https://jenkins.mesosphere.com/service/jenkins/job/mesos/job/Mesos_CI-build/1087/
>
> 3. I've temporarily modified NoTaskKillingCapability from command_executor_tests.cpp to launch command "sleep 0.1" (as well as "sleep 0"),
> then to wait for a task completion. The test was launched in an endless loop:
>
> GLOG_v=1 ./bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure --gtest_filter="HTTPCommandExecutor/CommandExecutorTest.NoTaskKillingCapability/0" --verbose
>
> I've run this test multiple times for a while both on mac os and Fedora linux. Race condition problem described in a jira ticket wasn't reproduced.
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 59605: Used glog for logging in executors.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59605/#review176770
-----------------------------------------------------------
src/launcher/executor.cpp
Lines 1245-1246 (original), 1247-1249 (patched)
<https://reviews.apache.org/r/59605/#comment250237>
`EXIT(EXIT_FAILURE)` according to https://issues.apache.org/jira/browse/MESOS-7586 ?
- Alexander Rukletsov
On June 2, 2017, 1:35 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59605/
> -----------------------------------------------------------
>
> (Updated June 2, 2017, 1:35 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Benjamin Mahler, and Till Toenshoff.
>
>
> Bugs: MESOS-6961
> https://issues.apache.org/jira/browse/MESOS-6961
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The rule for choosing between glog and cout is described by MESOS-7586.
>
>
> Diffs
> -----
>
> src/docker/executor.cpp 464a74859e0f477ec2e5525a5fc726ea420a00a2
> src/launcher/default_executor.cpp 1a60e3bb2b0e8312b349cddedb4cd55716c1b574
> src/launcher/executor.cpp 9ac3c3d84c0ec47954c5c72228ad0b8795ff3eec
>
>
> Diff: https://reviews.apache.org/r/59605/diff/2/
>
>
> Testing
> -------
>
> 1. make check (mac os x 10.12, fedora 25)
> 2. jenkins: https://jenkins.mesosphere.com/service/jenkins/job/mesos/job/Mesos_CI-build/1087/
>
> 3. I've temporarily modified NoTaskKillingCapability from command_executor_tests.cpp to launch command "sleep 0.1" (as well as "sleep 0"),
> then to wait for a task completion. The test was launched in an endless loop:
>
> GLOG_v=1 ./bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure --gtest_filter="HTTPCommandExecutor/CommandExecutorTest.NoTaskKillingCapability/0" --verbose
>
> I've run this test multiple times for a while both on mac os and Fedora linux. Race condition problem described in a jira ticket wasn't reproduced.
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 59605: Used glog for logging in executors.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59605/#review177022
-----------------------------------------------------------
Patch looks great!
Reviews applied: [59605]
Passed command: support\windows-build.bat
- Mesos Reviewbot Windows
On June 6, 2017, 11:24 a.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59605/
> -----------------------------------------------------------
>
> (Updated June 6, 2017, 11:24 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Benjamin Mahler, and Till Toenshoff.
>
>
> Bugs: MESOS-6961
> https://issues.apache.org/jira/browse/MESOS-6961
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The rule for choosing between glog and cout is described by MESOS-7586.
>
>
> Diffs
> -----
>
> src/docker/executor.cpp 464a74859e0f477ec2e5525a5fc726ea420a00a2
> src/launcher/default_executor.cpp 1a60e3bb2b0e8312b349cddedb4cd55716c1b574
> src/launcher/executor.cpp 9ac3c3d84c0ec47954c5c72228ad0b8795ff3eec
>
>
> Diff: https://reviews.apache.org/r/59605/diff/4/
>
>
> Testing
> -------
>
> 1. make check (mac os x 10.12, fedora 25)
> 2. jenkins: https://jenkins.mesosphere.com/service/jenkins/job/mesos/job/Mesos_CI-build/1087/
>
> 3. I've temporarily modified NoTaskKillingCapability from command_executor_tests.cpp to launch command "sleep 0.1" (as well as "sleep 0"),
> then to wait for a task completion. The test was launched in an endless loop:
>
> GLOG_v=1 ./bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure --gtest_filter="HTTPCommandExecutor/CommandExecutorTest.NoTaskKillingCapability/0" --verbose
>
> I've run this test multiple times for a while both on mac os and Fedora linux. Race condition problem described in a jira ticket wasn't reproduced.
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 59605: Used glog for logging in executors.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59605/#review177165
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On June 6, 2017, 11:24 a.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59605/
> -----------------------------------------------------------
>
> (Updated June 6, 2017, 11:24 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Benjamin Mahler, and Till Toenshoff.
>
>
> Bugs: MESOS-6961
> https://issues.apache.org/jira/browse/MESOS-6961
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The rule for choosing between glog and cout is described by MESOS-7586.
>
>
> Diffs
> -----
>
> src/docker/executor.cpp 464a74859e0f477ec2e5525a5fc726ea420a00a2
> src/launcher/default_executor.cpp 1a60e3bb2b0e8312b349cddedb4cd55716c1b574
> src/launcher/executor.cpp 9ac3c3d84c0ec47954c5c72228ad0b8795ff3eec
>
>
> Diff: https://reviews.apache.org/r/59605/diff/4/
>
>
> Testing
> -------
>
> 1. make check (mac os x 10.12, fedora 25)
> 2. jenkins: https://jenkins.mesosphere.com/service/jenkins/job/mesos/job/Mesos_CI-build/1087/
>
> 3. I've temporarily modified NoTaskKillingCapability from command_executor_tests.cpp to launch command "sleep 0.1" (as well as "sleep 0"),
> then to wait for a task completion. The test was launched in an endless loop:
>
> GLOG_v=1 ./bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure --gtest_filter="HTTPCommandExecutor/CommandExecutorTest.NoTaskKillingCapability/0" --verbose
>
> I've run this test multiple times for a while both on mac os and Fedora linux. Race condition problem described in a jira ticket wasn't reproduced.
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 59605: Used glog for logging in executors.
Posted by Andrei Budnik <ab...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59605/
-----------------------------------------------------------
(Updated June 6, 2017, 11:24 a.m.)
Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Benjamin Mahler, and Till Toenshoff.
Bugs: MESOS-6961
https://issues.apache.org/jira/browse/MESOS-6961
Repository: mesos
Description
-------
The rule for choosing between glog and cout is described by MESOS-7586.
Diffs (updated)
-----
src/docker/executor.cpp 464a74859e0f477ec2e5525a5fc726ea420a00a2
src/launcher/default_executor.cpp 1a60e3bb2b0e8312b349cddedb4cd55716c1b574
src/launcher/executor.cpp 9ac3c3d84c0ec47954c5c72228ad0b8795ff3eec
Diff: https://reviews.apache.org/r/59605/diff/4/
Changes: https://reviews.apache.org/r/59605/diff/3-4/
Testing
-------
1. make check (mac os x 10.12, fedora 25)
2. jenkins: https://jenkins.mesosphere.com/service/jenkins/job/mesos/job/Mesos_CI-build/1087/
3. I've temporarily modified NoTaskKillingCapability from command_executor_tests.cpp to launch command "sleep 0.1" (as well as "sleep 0"),
then to wait for a task completion. The test was launched in an endless loop:
GLOG_v=1 ./bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure --gtest_filter="HTTPCommandExecutor/CommandExecutorTest.NoTaskKillingCapability/0" --verbose
I've run this test multiple times for a while both on mac os and Fedora linux. Race condition problem described in a jira ticket wasn't reproduced.
Thanks,
Andrei Budnik
Re: Review Request 59605: Used glog for logging in executors.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59605/#review176812
-----------------------------------------------------------
Patch looks great!
Reviews applied: [59605]
Passed command: support\windows-build.bat
- Mesos Reviewbot Windows
On June 2, 2017, 4:18 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59605/
> -----------------------------------------------------------
>
> (Updated June 2, 2017, 4:18 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Benjamin Mahler, and Till Toenshoff.
>
>
> Bugs: MESOS-6961
> https://issues.apache.org/jira/browse/MESOS-6961
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The rule for choosing between glog and cout is described by MESOS-7586.
>
>
> Diffs
> -----
>
> src/docker/executor.cpp 464a74859e0f477ec2e5525a5fc726ea420a00a2
> src/launcher/default_executor.cpp 1a60e3bb2b0e8312b349cddedb4cd55716c1b574
> src/launcher/executor.cpp 9ac3c3d84c0ec47954c5c72228ad0b8795ff3eec
>
>
> Diff: https://reviews.apache.org/r/59605/diff/3/
>
>
> Testing
> -------
>
> 1. make check (mac os x 10.12, fedora 25)
> 2. jenkins: https://jenkins.mesosphere.com/service/jenkins/job/mesos/job/Mesos_CI-build/1087/
>
> 3. I've temporarily modified NoTaskKillingCapability from command_executor_tests.cpp to launch command "sleep 0.1" (as well as "sleep 0"),
> then to wait for a task completion. The test was launched in an endless loop:
>
> GLOG_v=1 ./bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure --gtest_filter="HTTPCommandExecutor/CommandExecutorTest.NoTaskKillingCapability/0" --verbose
>
> I've run this test multiple times for a while both on mac os and Fedora linux. Race condition problem described in a jira ticket wasn't reproduced.
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 59605: Used glog for logging in executors.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59605/#review177009
-----------------------------------------------------------
src/docker/executor.cpp
Lines 790-791 (original), 787-788 (patched)
<https://reviews.apache.org/r/59605/#comment250587>
Please 4 spaces indent when carrying over after `(`
- Alexander Rukletsov
On June 2, 2017, 4:18 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59605/
> -----------------------------------------------------------
>
> (Updated June 2, 2017, 4:18 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Benjamin Mahler, and Till Toenshoff.
>
>
> Bugs: MESOS-6961
> https://issues.apache.org/jira/browse/MESOS-6961
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The rule for choosing between glog and cout is described by MESOS-7586.
>
>
> Diffs
> -----
>
> src/docker/executor.cpp 464a74859e0f477ec2e5525a5fc726ea420a00a2
> src/launcher/default_executor.cpp 1a60e3bb2b0e8312b349cddedb4cd55716c1b574
> src/launcher/executor.cpp 9ac3c3d84c0ec47954c5c72228ad0b8795ff3eec
>
>
> Diff: https://reviews.apache.org/r/59605/diff/3/
>
>
> Testing
> -------
>
> 1. make check (mac os x 10.12, fedora 25)
> 2. jenkins: https://jenkins.mesosphere.com/service/jenkins/job/mesos/job/Mesos_CI-build/1087/
>
> 3. I've temporarily modified NoTaskKillingCapability from command_executor_tests.cpp to launch command "sleep 0.1" (as well as "sleep 0"),
> then to wait for a task completion. The test was launched in an endless loop:
>
> GLOG_v=1 ./bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure --gtest_filter="HTTPCommandExecutor/CommandExecutorTest.NoTaskKillingCapability/0" --verbose
>
> I've run this test multiple times for a while both on mac os and Fedora linux. Race condition problem described in a jira ticket wasn't reproduced.
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 59605: Used glog for logging in executors.
Posted by Andrei Budnik <ab...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59605/
-----------------------------------------------------------
(Updated June 2, 2017, 4:18 p.m.)
Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Benjamin Mahler, and Till Toenshoff.
Bugs: MESOS-6961
https://issues.apache.org/jira/browse/MESOS-6961
Repository: mesos
Description
-------
The rule for choosing between glog and cout is described by MESOS-7586.
Diffs (updated)
-----
src/docker/executor.cpp 464a74859e0f477ec2e5525a5fc726ea420a00a2
src/launcher/default_executor.cpp 1a60e3bb2b0e8312b349cddedb4cd55716c1b574
src/launcher/executor.cpp 9ac3c3d84c0ec47954c5c72228ad0b8795ff3eec
Diff: https://reviews.apache.org/r/59605/diff/3/
Changes: https://reviews.apache.org/r/59605/diff/2-3/
Testing
-------
1. make check (mac os x 10.12, fedora 25)
2. jenkins: https://jenkins.mesosphere.com/service/jenkins/job/mesos/job/Mesos_CI-build/1087/
3. I've temporarily modified NoTaskKillingCapability from command_executor_tests.cpp to launch command "sleep 0.1" (as well as "sleep 0"),
then to wait for a task completion. The test was launched in an endless loop:
GLOG_v=1 ./bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure --gtest_filter="HTTPCommandExecutor/CommandExecutorTest.NoTaskKillingCapability/0" --verbose
I've run this test multiple times for a while both on mac os and Fedora linux. Race condition problem described in a jira ticket wasn't reproduced.
Thanks,
Andrei Budnik
Re: Review Request 59605: Used glog for logging in executors.
Posted by Andrei Budnik <ab...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59605/
-----------------------------------------------------------
(Updated June 2, 2017, 1:35 p.m.)
Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Benjamin Mahler, and Till Toenshoff.
Bugs: MESOS-6961
https://issues.apache.org/jira/browse/MESOS-6961
Repository: mesos
Description
-------
The rule for choosing between glog and cout is described by MESOS-7586.
Diffs
-----
src/docker/executor.cpp 464a74859e0f477ec2e5525a5fc726ea420a00a2
src/launcher/default_executor.cpp 1a60e3bb2b0e8312b349cddedb4cd55716c1b574
src/launcher/executor.cpp 9ac3c3d84c0ec47954c5c72228ad0b8795ff3eec
Diff: https://reviews.apache.org/r/59605/diff/2/
Testing (updated)
-------
1. make check (mac os x 10.12, fedora 25)
2. jenkins: https://jenkins.mesosphere.com/service/jenkins/job/mesos/job/Mesos_CI-build/1087/
3. I've temporarily modified NoTaskKillingCapability from command_executor_tests.cpp to launch command "sleep 0.1" (as well as "sleep 0"),
then to wait for a task completion. The test was launched in an endless loop:
GLOG_v=1 ./bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure --gtest_filter="HTTPCommandExecutor/CommandExecutorTest.NoTaskKillingCapability/0" --verbose
I've run this test multiple times for a while both on mac os and Fedora linux. Race condition problem described in a jira ticket wasn't reproduced.
Thanks,
Andrei Budnik