You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2023/01/10 02:00:41 UTC

[GitHub] [tvm] wrongtest-intellif commented on a diff in pull request #13733: [TOPI][OP] Support grouped conv2d_NCHWc

wrongtest-intellif commented on code in PR #13733:
URL: https://github.com/apache/tvm/pull/13733#discussion_r1065268191


##########
python/tvm/topi/nn/conv2d.py:
##########
@@ -424,17 +424,15 @@ def conv2d_NCHWc(data, kernel, stride, padding, dilation, layout, out_layout, ou
 
     return te.compute(
         oshape,
-        lambda n, oc_chunk, oh, ow, oc_block: te.sum(
+        lambda n, occ, oh, ow, oc_block: te.sum(

Review Comment:
   Could we preserve a group=1 code path like `conv2d_NCHWc_int8` below?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org