[jira] [Commented] (WICKET-5643) WebPageRenderer should bind a Session if redirect is required and the session is temporary.

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-5643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14070450#comment-14070450 ] 

ASF subversion and git services commented on WICKET-5643:
---------------------------------------------------------

Commit 0b0e0980d6ac9cff063be2ec5b93bf7d37fe8bc8 in wicket's branch refs/heads/master from [~bitstorm]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=0b0e098 ]

WICKET-5643 WebPageRenderer should bind a Session if redirect is
required and the session is temporary.

Added a warning log if a null session id is provided.

> WebPageRenderer should bind a Session if redirect is required and the session is temporary.
> -------------------------------------------------------------------------------------------
>
>                 Key: WICKET-5643
>                 URL: https://issues.apache.org/jira/browse/WICKET-5643
>             Project: Wicket
>          Issue Type: Bug
>    Affects Versions: 6.16.0, 7.0.0-M2
>            Reporter: Andrea Del Bene
>            Assignee: Andrea Del Bene
>             Fix For: 7.0.0-M3, 6.17.0
>
>         Attachments: wicket5578.tar.gz
>
>
> WebApplication.storeBufferedResponse does not check if sessionId is null. This could lead to wrong behaviors as it happens  in the quickstart project. Let's say we have a stateless home page with page parameters that are populated inside page constructor. Under these conditions class WebPageRenderer will call storeBufferedResponse and will redirect the response to the final URL (line 289). But as the session is temporary, the buffered response is not consumed and  WebPageRenderer will rise a warning (line 194).
> I think we should check for null sessionId inside WebApplication or inside WebPageRender.



--
This message was sent by Atlassian JIRA
(v6.2#6252)