You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2017/11/27 23:03:00 UTC
[kudu-CR] tablet copy-itest: fix flaky TestMetricsResetAfterRevival
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8651
Change subject: tablet_copy-itest: fix flaky TestMetricsResetAfterRevival
......................................................................
tablet_copy-itest: fix flaky TestMetricsResetAfterRevival
The test aimed to assert that metrics would reset after successfully
bootstrapping the tablet. It originally used the condition that the
metadata reached TABLET_DATA_READY to ensure bootstrapping completed,
which is not the case.
This patch updates the test to ensure bootstrapping completes by
checking the number of running tablets reaches 1.
I validated this by adding a sleep statement just before OpenTablet() in
the tablet copy code (where the metadata has reached TABLET_DATA_READY
byt has yet to bootstrap) and seeing 100/100 failures. With the fix,
this case passes.
Change-Id: Icec1eb2cb8b9569c27210d0342087b1b05169046
---
M src/kudu/integration-tests/tablet_copy-itest.cc
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/8651/1
--
To view, visit http://gerrit.cloudera.org:8080/8651
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icec1eb2cb8b9569c27210d0342087b1b05169046
Gerrit-Change-Number: 8651
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR] tablet copy-itest: fix flaky TestMetricsResetAfterRevival
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8651 )
Change subject: tablet_copy-itest: fix flaky TestMetricsResetAfterRevival
......................................................................
tablet_copy-itest: fix flaky TestMetricsResetAfterRevival
The test aimed to assert that metrics would reset after successfully
bootstrapping the tablet. It originally used the condition that the
metadata reached TABLET_DATA_READY to ensure bootstrapping completed,
which may not be the case. E.g. during tablet copies, the data is copied
over in TABLET_DATA_READY state, and then the Tablet is bootstrapped
(and only then are the metrics reset).
This patch updates the test to ensure bootstrapping completes by instead
checking the number of running tablets reaches 1.
I validated this by adding a sleep statement just before OpenTablet() in
the tablet copy code (where the metadata has reached TABLET_DATA_READY
but has yet to bootstrap) and seeing 100/100 failures. With the fix,
this case passes.
Change-Id: Icec1eb2cb8b9569c27210d0342087b1b05169046
Reviewed-on: http://gerrit.cloudera.org:8080/8651
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Mike Percy <mp...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/integration-tests/tablet_copy-itest.cc
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Mike Percy: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/8651
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Icec1eb2cb8b9569c27210d0342087b1b05169046
Gerrit-Change-Number: 8651
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] tablet copy-itest: fix flaky TestMetricsResetAfterRevival
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8651
to look at the new patch set (#3).
Change subject: tablet_copy-itest: fix flaky TestMetricsResetAfterRevival
......................................................................
tablet_copy-itest: fix flaky TestMetricsResetAfterRevival
The test aimed to assert that metrics would reset after successfully
bootstrapping the tablet. It originally used the condition that the
metadata reached TABLET_DATA_READY to ensure bootstrapping completed,
which may not be the case. E.g. during tablet copies, the data is copied
over in TABLET_DATA_READY state, and then the Tablet is bootstrapped
(and only then are the metrics reset).
This patch updates the test to ensure bootstrapping completes by instead
checking the number of running tablets reaches 1.
I validated this by adding a sleep statement just before OpenTablet() in
the tablet copy code (where the metadata has reached TABLET_DATA_READY
but has yet to bootstrap) and seeing 100/100 failures. With the fix,
this case passes.
Change-Id: Icec1eb2cb8b9569c27210d0342087b1b05169046
---
M src/kudu/integration-tests/tablet_copy-itest.cc
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/8651/3
--
To view, visit http://gerrit.cloudera.org:8080/8651
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icec1eb2cb8b9569c27210d0342087b1b05169046
Gerrit-Change-Number: 8651
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] tablet copy-itest: fix flaky TestMetricsResetAfterRevival
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8651
to look at the new patch set (#2).
Change subject: tablet_copy-itest: fix flaky TestMetricsResetAfterRevival
......................................................................
tablet_copy-itest: fix flaky TestMetricsResetAfterRevival
The test aimed to assert that metrics would reset after successfully
bootstrapping the tablet. It originally used the condition that the
metadata reached TABLET_DATA_READY to ensure bootstrapping completed,
which may not be the case.
This patch updates the test to ensure bootstrapping completes by
checking the number of running tablets reaches 1.
I validated this by adding a sleep statement just before OpenTablet() in
the tablet copy code (where the metadata has reached TABLET_DATA_READY
but has yet to bootstrap) and seeing 100/100 failures. With the fix,
this case passes.
Change-Id: Icec1eb2cb8b9569c27210d0342087b1b05169046
---
M src/kudu/integration-tests/tablet_copy-itest.cc
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/8651/2
--
To view, visit http://gerrit.cloudera.org:8080/8651
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icec1eb2cb8b9569c27210d0342087b1b05169046
Gerrit-Change-Number: 8651
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] tablet copy-itest: fix flaky TestMetricsResetAfterRevival
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8651 )
Change subject: tablet_copy-itest: fix flaky TestMetricsResetAfterRevival
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8651
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icec1eb2cb8b9569c27210d0342087b1b05169046
Gerrit-Change-Number: 8651
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Tue, 28 Nov 2017 00:40:37 +0000
Gerrit-HasComments: No
[kudu-CR] tablet copy-itest: fix flaky TestMetricsResetAfterRevival
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8651 )
Change subject: tablet_copy-itest: fix flaky TestMetricsResetAfterRevival
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8651/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/8651/2//COMMIT_MSG@12
PS2, Line 12: which may not be the case
> nit: could you add the explanation why was that?
Done
--
To view, visit http://gerrit.cloudera.org:8080/8651
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icec1eb2cb8b9569c27210d0342087b1b05169046
Gerrit-Change-Number: 8651
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Tue, 28 Nov 2017 00:35:25 +0000
Gerrit-HasComments: Yes
[kudu-CR] tablet copy-itest: fix flaky TestMetricsResetAfterRevival
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8651 )
Change subject: tablet_copy-itest: fix flaky TestMetricsResetAfterRevival
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8651/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/8651/2//COMMIT_MSG@12
PS2, Line 12: which may not be the case
nit: could you add the explanation why was that?
--
To view, visit http://gerrit.cloudera.org:8080/8651
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icec1eb2cb8b9569c27210d0342087b1b05169046
Gerrit-Change-Number: 8651
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Tue, 28 Nov 2017 00:31:20 +0000
Gerrit-HasComments: Yes
[kudu-CR] tablet copy-itest: fix flaky TestMetricsResetAfterRevival
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8651 )
Change subject: tablet_copy-itest: fix flaky TestMetricsResetAfterRevival
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8651/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/8651/2//COMMIT_MSG@12
PS2, Line 12: which may not be the case
> Done
Thanks!
--
To view, visit http://gerrit.cloudera.org:8080/8651
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icec1eb2cb8b9569c27210d0342087b1b05169046
Gerrit-Change-Number: 8651
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Tue, 28 Nov 2017 00:39:01 +0000
Gerrit-HasComments: Yes
[kudu-CR] tablet copy-itest: fix flaky TestMetricsResetAfterRevival
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8651 )
Change subject: tablet_copy-itest: fix flaky TestMetricsResetAfterRevival
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8651
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icec1eb2cb8b9569c27210d0342087b1b05169046
Gerrit-Change-Number: 8651
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Tue, 28 Nov 2017 00:30:02 +0000
Gerrit-HasComments: No