You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yx9o (via GitHub)" <gi...@apache.org> on 2026/07/25 11:57:54 UTC
[I] [Studio] Reject missing Ops toggle values [rocketmq-dashboard]
yx9o opened a new issue, #584:
URL: https://github.com/apache/rocketmq-dashboard/issues/584
## Problem
`POST /api/ops/updateIsVIPChannel` and `POST /api/ops/updateUseTLS` accept requests without the required `useVIPChannel` or `useTLS` value.
Because the DTO fields use primitive `boolean`, a missing value is deserialized as `false`. The endpoint then returns success and calls the update service, which can silently disable the setting.
## Expected behavior
- Reject missing toggle values with HTTP 400.
- Prevent invalid requests from changing the setting.
- Preserve normal updates for explicit `true` and `false` values.
## Proposed fix
Use nullable `Boolean` fields with required validation, validate the request bodies before invoking the service, and add controller regression tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Studio] Reject missing Ops toggle values [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed issue #584: [Studio] Reject missing Ops toggle values
URL: https://github.com/apache/rocketmq-dashboard/issues/584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Studio] Reject missing Ops toggle values [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on issue #584:
URL: https://github.com/apache/rocketmq-dashboard/issues/584#issuecomment-5112062972
Resolved by #632 (merged into rocketmq-studio as eafbb19): OpsTlsDTO / OpsVipChannelDTO now use @NotNull Boolean with @Valid on the controller, so missing toggle values return 400. #585 proposed the same change and was closed as already covered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org