You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "greg sterijevski (JIRA)" <ji...@apache.org> on 2011/07/14 07:33:59 UTC
[jira] [Created] (MATH-619) ADJUSTED R SQUARED INCORRECT IN
REGRESSION RESULTS
ADJUSTED R SQUARED INCORRECT IN REGRESSION RESULTS
--------------------------------------------------
Key: MATH-619
URL: https://issues.apache.org/jira/browse/MATH-619
Project: Commons Math
Issue Type: Bug
Affects Versions: 3.0
Environment: Java
Reporter: greg sterijevski
Attachments: regres
I forgot to cast to double when dividing two integers:
this.globalFitInfo[ADJRSQ_IDX] = 1.0 -
(1.0 - this.globalFitInfo[RSQ_IDX]) *
( nobs / ( (nobs - rank)));
Should be
this.globalFitInfo[ADJRSQ_IDX] = 1.0 -
(1.0 - this.globalFitInfo[RSQ_IDX]) *
( (double) nobs / ( (double) (nobs - rank)));
Patch attached.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (MATH-619) ADJUSTED R SQUARED INCORRECT IN
REGRESSION RESULTS
Posted by "Phil Steitz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phil Steitz resolved MATH-619.
------------------------------
Resolution: Fixed
Fix Version/s: 3.0
Fixed in r1146575. Lets keep the updates (including test cases :) for RegressionResults on (still open) MATH-607. We can use separate issues for implementations; but we should keep the updates to RegressionResults attached to that issue.
> ADJUSTED R SQUARED INCORRECT IN REGRESSION RESULTS
> --------------------------------------------------
>
> Key: MATH-619
> URL: https://issues.apache.org/jira/browse/MATH-619
> Project: Commons Math
> Issue Type: Bug
> Affects Versions: 3.0
> Environment: Java
> Reporter: greg sterijevski
> Fix For: 3.0
>
> Attachments: regres
>
>
> I forgot to cast to double when dividing two integers:
> this.globalFitInfo[ADJRSQ_IDX] = 1.0 -
> (1.0 - this.globalFitInfo[RSQ_IDX]) *
> ( nobs / ( (nobs - rank)));
> Should be
> this.globalFitInfo[ADJRSQ_IDX] = 1.0 -
> (1.0 - this.globalFitInfo[RSQ_IDX]) *
> ( (double) nobs / ( (double) (nobs - rank)));
> Patch attached.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MATH-619) ADJUSTED R SQUARED INCORRECT IN
REGRESSION RESULTS
Posted by "greg sterijevski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
greg sterijevski updated MATH-619:
----------------------------------
Attachment: regres
> ADJUSTED R SQUARED INCORRECT IN REGRESSION RESULTS
> --------------------------------------------------
>
> Key: MATH-619
> URL: https://issues.apache.org/jira/browse/MATH-619
> Project: Commons Math
> Issue Type: Bug
> Affects Versions: 3.0
> Environment: Java
> Reporter: greg sterijevski
> Attachments: regres
>
>
> I forgot to cast to double when dividing two integers:
> this.globalFitInfo[ADJRSQ_IDX] = 1.0 -
> (1.0 - this.globalFitInfo[RSQ_IDX]) *
> ( nobs / ( (nobs - rank)));
> Should be
> this.globalFitInfo[ADJRSQ_IDX] = 1.0 -
> (1.0 - this.globalFitInfo[RSQ_IDX]) *
> ( (double) nobs / ( (double) (nobs - rank)));
> Patch attached.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira