You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/09/13 01:55:52 UTC
[GitHub] [arrow-datafusion] houqp opened a new pull request #994: manage python binding metadata with pyproject.toml
houqp opened a new pull request #994:
URL: https://github.com/apache/arrow-datafusion/pull/994
# Rationale for this change
pyproject.toml is a more idiomatic and easier to update compared to cargo.toml. also set package name to `datafusion` in pyproject.toml so we maturin names the final wheel as datafusion.tar.gz instead of datafusion-python.tar.gz
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] houqp commented on a change in pull request #994: manage python binding metadata with pyproject.toml
Posted by GitBox <gi...@apache.org>.
houqp commented on a change in pull request #994:
URL: https://github.com/apache/arrow-datafusion/pull/994#discussion_r707829149
##########
File path: python/LICENSE.txt
##########
@@ -0,0 +1,1085 @@
+
Review comment:
That's a good idea, I will remove it from the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] houqp commented on pull request #994: manage python binding metadata with pyproject.toml
Posted by GitBox <gi...@apache.org>.
houqp commented on pull request #994:
URL: https://github.com/apache/arrow-datafusion/pull/994#issuecomment-917782211
cc @Jimexist
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] houqp commented on pull request #994: manage python binding metadata with pyproject.toml
Posted by GitBox <gi...@apache.org>.
houqp commented on pull request #994:
URL: https://github.com/apache/arrow-datafusion/pull/994#issuecomment-919689717
@jorgecarleitao changed it to generate the full license file in release CICD run, see https://github.com/houqp/arrow-datafusion/actions/runs/1232759710 for an example.
I left a simple Apache LICENSE.txt file there so one can still run `maturin develop/build` in local development without having to run the create license script.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jorgecarleitao commented on a change in pull request #994: manage python binding metadata with pyproject.toml
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on a change in pull request #994:
URL: https://github.com/apache/arrow-datafusion/pull/994#discussion_r707687373
##########
File path: python/LICENSE.txt
##########
@@ -0,0 +1,1085 @@
+
Review comment:
We could make this part of the release build so that we only push this to the release and not drift on changes of the Cargo.toml (or need to remember to update it)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] houqp merged pull request #994: manage python binding metadata with pyproject.toml
Posted by GitBox <gi...@apache.org>.
houqp merged pull request #994:
URL: https://github.com/apache/arrow-datafusion/pull/994
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org