You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/03/19 11:13:20 UTC
[GitHub] [incubator-tvm] siju-samuel opened a new pull request #5098:
[TOPI][RELAY]Global MaxPool3d and AvgPool3d topi & relay implementation
siju-samuel opened a new pull request #5098: [TOPI][RELAY]Global MaxPool3d and AvgPool3d topi & relay implementation
URL: https://github.com/apache/incubator-tvm/pull/5098
Global MaxPool and AveragePool 3D
@MarisaKirisame @FrozenGene @yzhliu @vinx13 please help to review & merge this PR.
TIA
Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @ them in the pull request thread.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] masahi edited a comment on issue #5098:
[TOPI][RELAY]Global MaxPool3d and AvgPool3d topi & relay implementation
Posted by GitBox <gi...@apache.org>.
masahi edited a comment on issue #5098: [TOPI][RELAY]Global MaxPool3d and AvgPool3d topi & relay implementation
URL: https://github.com/apache/incubator-tvm/pull/5098#issuecomment-601494000
@siju-samuel Since global pooling is just a special case of adaptive pooling, I dont think adding all these Relay boilerplate is worth it. I prefer to remove global pool 2d as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] MarisaKirisame commented on a change in pull
request #5098: [TOPI][RELAY]Global MaxPool3d and AvgPool3d topi & relay
implementation
Posted by GitBox <gi...@apache.org>.
MarisaKirisame commented on a change in pull request #5098: [TOPI][RELAY]Global MaxPool3d and AvgPool3d topi & relay implementation
URL: https://github.com/apache/incubator-tvm/pull/5098#discussion_r395415481
##########
File path: python/tvm/relay/op/nn/nn.py
##########
@@ -943,6 +943,76 @@ def global_avg_pool2d(data,
return _make.global_avg_pool2d(data, layout)
+def global_max_pool3d(data,
+ layout="NCDHW"):
+ r"""3D global maximum pooling operator.
+
+ This operator takes data as input and does 3D max value calculation
+ across each window represented by DxWxH.
+
+
+ In the default case, where the data_layout is `NCDHW`
+ a data Tensor with shape `(batch_size, in_channels, depth, height, width)`,
+ to produce an output Tensor with the following rule:
+
+ with data of shape (b, c, d, h, w)
+
+ .. math::
+
+ \mbox{out}(b, c, 1, 1, 1) = \max_{l=0, \ldots, d}, \max_{m=0, \ldots, h},
+ \max_{n=0, \ldots, w} \mbox{datam}(b, c, l, m, n)
+
+ Parameters
+ ----------
+ data : tvm.relay.Expr
+ The input data to the operator.
+
+ layout : str, optional
Review comment:
Optional[str]
```suggestion
layout : str, optional
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] masahi commented on issue #5098:
[TOPI][RELAY]Global MaxPool3d and AvgPool3d topi & relay implementation
Posted by GitBox <gi...@apache.org>.
masahi commented on issue #5098: [TOPI][RELAY]Global MaxPool3d and AvgPool3d topi & relay implementation
URL: https://github.com/apache/incubator-tvm/pull/5098#issuecomment-601494000
@siju-samuel Since global pooling is just a special case of adaptive pooling, I dont think adding all these Relay boilaplate is worth it. I prefer to remove global pool 2d as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] masahi commented on pull request #5098: [TOPI][RELAY]Global MaxPool3d and AvgPool3d topi & relay implementation
Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #5098:
URL: https://github.com/apache/incubator-tvm/pull/5098#issuecomment-629576125
I think we shouldn't introduce this op for the reason I mentioned. If we want to use this op to convert `global_avg_pool` from frontends, we can define `global_avg_pool` function in frontend/common.py that just calls `adaptive_pool` with output size (1, 1).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] masahi commented on pull request #5098: [KERAS]Global MaxPool3d and AvgPool3d support
Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #5098:
URL: https://github.com/apache/incubator-tvm/pull/5098#issuecomment-630783562
Thanks @siju-samuel
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] masahi merged pull request #5098: [KERAS]Global MaxPool3d and AvgPool3d support
Posted by GitBox <gi...@apache.org>.
masahi merged pull request #5098:
URL: https://github.com/apache/incubator-tvm/pull/5098
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on pull request #5098: [TOPI][RELAY]Global MaxPool3d and AvgPool3d topi & relay implementation
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #5098:
URL: https://github.com/apache/incubator-tvm/pull/5098#issuecomment-629508473
@siju-samuel @masahi please comment about the status and act or close thie PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] siju-samuel commented on pull request #5098: [KERAS]Global MaxPool3d and AvgPool3d support
Posted by GitBox <gi...@apache.org>.
siju-samuel commented on pull request #5098:
URL: https://github.com/apache/incubator-tvm/pull/5098#issuecomment-630102255
@masahi Please help to review and merge.
TIA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] siju-samuel commented on pull request #5098: [TOPI][RELAY]Global MaxPool3d and AvgPool3d topi & relay implementation
Posted by GitBox <gi...@apache.org>.
siju-samuel commented on pull request #5098:
URL: https://github.com/apache/incubator-tvm/pull/5098#issuecomment-629578676
Thanks @masahi . I will update.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org