You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/23 21:48:01 UTC
[GitHub] [arrow] kou commented on a diff in pull request #14362: ARROW-17972: [CI] Update CUDA docker jobs
kou commented on code in PR #14362:
URL: https://github.com/apache/arrow/pull/14362#discussion_r1002774927
##########
docker-compose.yml:
##########
@@ -488,17 +488,36 @@ services:
shm_size: *shm-size
ulimits: *ulimits
environment: &cuda-environment
- <<: *ccache
+ <<: [*sccache, *ccache]
ARROW_BUILD_STATIC: "OFF"
ARROW_CUDA: "ON"
ARROW_GANDIVA: "OFF"
ARROW_GCS: "OFF"
ARROW_ORC: "OFF"
ARROW_S3: "OFF"
ARROW_SUBSTRAIT: "OFF"
+ ARROW_BUILD_UTILITIES: "OFF"
+ ARROW_COMPUTE: "OFF"
+ ARROW_CSV: "OFF"
+ ARROW_DATASET: "OFF"
+ ARROW_FILESYSTEM: "OFF"
+ ARROW_HDFS: "OFF"
+ ARROW_JEMALLOC: "OFF"
+ ARROW_JSON: "OFF"
+ ARROW_PLASMA: "OFF"
+ ARROW_PARQUET: "OFF"
+ ARROW_ENABLE_TIMING_TESTS: "OFF"
ARROW_WITH_OPENTELEMETRY: "OFF"
volumes: *ubuntu-volumes
- command: *cpp-command
+ command: /bin/bash -c "
+ /arrow/ci/scripts/cpp_build.sh /arrow /build &&
+ /arrow/ci/scripts/cpp_test.sh /arrow /build"
Review Comment:
It seems that this is (logically) same as `cpp-command`. Why can't we use `*cpp-command` here?
##########
docker-compose.yml:
##########
@@ -488,17 +488,36 @@ services:
shm_size: *shm-size
ulimits: *ulimits
environment: &cuda-environment
- <<: *ccache
+ <<: [*sccache, *ccache]
ARROW_BUILD_STATIC: "OFF"
ARROW_CUDA: "ON"
ARROW_GANDIVA: "OFF"
ARROW_GCS: "OFF"
ARROW_ORC: "OFF"
ARROW_S3: "OFF"
ARROW_SUBSTRAIT: "OFF"
+ ARROW_BUILD_UTILITIES: "OFF"
+ ARROW_COMPUTE: "OFF"
+ ARROW_CSV: "OFF"
+ ARROW_DATASET: "OFF"
+ ARROW_FILESYSTEM: "OFF"
+ ARROW_HDFS: "OFF"
+ ARROW_JEMALLOC: "OFF"
+ ARROW_JSON: "OFF"
+ ARROW_PLASMA: "OFF"
+ ARROW_PARQUET: "OFF"
+ ARROW_ENABLE_TIMING_TESTS: "OFF"
Review Comment:
Could you sort this list in alphabetical order?
##########
docker-compose.yml:
##########
@@ -783,8 +802,29 @@ services:
numba: ${NUMBA}
shm_size: *shm-size
environment:
- <<: [ *ccache, *cuda-environment ]
+ <<: [ *ccache, *sccache ]
+ #ARROW_BUILD_STATIC: "OFF"
Review Comment:
Can we remove this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org