You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/09/26 10:56:15 UTC
[PR] Avoid duplicate unsupported SQL parser test invocations [shardingsphere]
terrymanu opened a new pull request, #39968:
URL: https://github.com/apache/shardingsphere/pull/39968
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Avoid duplicate unsupported SQL parser test invocations [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #39968:
URL: https://github.com/apache/shardingsphere/pull/39968
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Avoid duplicate unsupported SQL parser test invocations [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #39968:
URL: https://github.com/apache/shardingsphere/pull/39968#issuecomment-5845666019
### Result
**Review Result: Mergeable**
The change is limited to one Parser test entry point. It does not change SQL parsing behavior or parameter generation for other tests.
### Evidence
- Unsupported SQL fixtures do not restrict `case-types`. The original test passed an empty parameter list to both builders, so both produced the same SQL.
- All 36 cases across the five enabled test classes passed, with no failures or skips. Every existing SQL and dialect combination remains covered once.
- Spotless, Checkstyle, and `git diff --check` passed for the changed file.
### Coverage
- Standalone local candidate, reviewed against the working tree before this change at `9b833a512f8`. The task-owned change is limited to `test/it/parser/src/main/java/org/apache/shardingsphere/test/it/sql/parser/internal/InternalUnsupportedSQLParserIT.java`; other working-tree changes are excluded.
- Verified the enabled Doris, Firebird, PostgreSQL, SQL92, and SQLServer cases. The MySQL, openGauss, and Oracle classes remain disabled. This change does not affect SQL syntax, so official syntax documentation is not applicable.
- This is a code-correctness result; CI was not reviewed. The full `install` was not run because it currently executes the E2E driver tests that you asked to exclude.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org