[GitHub] [doris] morrySnow commented on a diff in pull request #13382: [feature](Nereids) generate ExprId from 0 for each statement

[GitBox <gi...@apache.org>]

morrySnow commented on code in PR #13382:
URL: https://github.com/apache/doris/pull/13382#discussion_r996621918


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/LogicalPlanAdapter.java:
##########
@@ -85,6 +92,6 @@ public String toDigest() {
     }
 
     public static LogicalPlanAdapter of(Plan plan) {
-        return new LogicalPlanAdapter((LogicalPlan) plan);
+        return new LogicalPlanAdapter((LogicalPlan) plan, null);

Review Comment:
   u r right, UT and regression test not be processed now



##########
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/LogicalPlanAdapter.java:
##########
@@ -62,21 +65,25 @@ public OutFileClause getOutFileClause() {
         return null;
     }
 
+    public void setResultExprs(List<Expr> resultExprs) {
+        this.resultExprs = resultExprs;
+    }
+
     @Override
     public List<Expr> getResultExprs() {
         return resultExprs;
     }
 
-    public ArrayList<String> getColLabels() {
-        return colLabels;
+    public void setColLabels(ArrayList<String> colLabels) {
+        this.colLabels = colLabels;
     }
 
-    public void setResultExprs(List<Expr> resultExprs) {
-        this.resultExprs = resultExprs;
+    public ArrayList<String> getColLabels() {

Review Comment:
   ok~



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org