Re: [PR] HBASE-29626: Refactor server side scan metrics for Coproc hooks [hbase]

["virajjasani (via GitHub)" <gi...@apache.org>]

virajjasani commented on code in PR #7340:
URL: https://github.com/apache/hbase/pull/7340#discussion_r2377265281


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ServerCall.java:
##########
@@ -607,11 +606,10 @@ public synchronized BufferChain getResponse() {
 
   @Override
   public void updateFsReadTime(long latencyMillis) {
-    fsReadTimeMillis += latencyMillis;
   }
 
   @Override
   public long getFsReadTime() {

Review Comment:
   Let's remove `getFsReadTime()` entirely? It's of no use anyways right?



##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionScannerImpl.java:
##########
@@ -148,16 +145,7 @@ private static boolean hasNonce(HRegion region, long nonce) {
     } finally {
       region.smallestReadPointCalcLock.unlock(ReadPointCalculationLock.LockType.RECORDING_LOCK);
     }
-    boolean isScanMetricsEnabled = scan.isScanMetricsEnabled();
-    ThreadLocalServerSideScanMetrics.setScanMetricsEnabled(isScanMetricsEnabled);
-    if (isScanMetricsEnabled) {
-      this.scannerInitMetrics = new ServerSideScanMetrics();
-      ThreadLocalServerSideScanMetrics.reset();
-    }

Review Comment:
   I am bit confused, do we really not need this at all?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org