[GitHub] [fineract] adamsaghy commented on a diff in pull request #3386: FINERACT-1943 Transaction and datatable GET queries

["adamsaghy (via GitHub)" <gi...@apache.org>]

adamsaghy commented on code in PR #3386:
URL: https://github.com/apache/fineract/pull/3386#discussion_r1301423941


##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/search/service/SearchUtil.java:
##########
@@ -173,7 +232,9 @@ public static Object parseAndValidateColumnValue(final ResultsetColumnHeaderData
         if (StringUtils.isEmpty(columnValue)) {
             return columnValue;
         }
-        SQLInjectionValidator.validateDynamicQuery(columnValue);
+        if (strict) {

Review Comment:
   Can you please help me to understand why we need this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org