[GitHub] [tvm] masahi commented on a diff in pull request #15419: [VM][Textures] Enable OpenCL textures for VM

["masahi (via GitHub)" <gi...@apache.org>]

masahi commented on code in PR #15419:
URL: https://github.com/apache/tvm/pull/15419#discussion_r1282776870


##########
include/tvm/runtime/vm/bytecode.h:
##########
@@ -201,6 +203,10 @@ struct Instruction {
       Index alignment;
       /*! \brief The hint of the dtype. */
       DLDataType dtype_hint;
+      /*! \brief The number of dimensions. */
+      uint32_t ndim;
+      /*! \brief The shape of tensor. */
+      int64_t* shape;

Review Comment:
   With these information, does the existing field, `allocation_size`, become redundant? How about putting them into a union to save one int64?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org