You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Patrick Hunt (JIRA)" <ji...@apache.org> on 2009/07/29 20:28:14 UTC
[jira] Created: (ZOOKEEPER-490) the java docs for session creation
are misleading/incomplete
the java docs for session creation are misleading/incomplete
------------------------------------------------------------
Key: ZOOKEEPER-490
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-490
Project: Zookeeper
Issue Type: Bug
Affects Versions: 3.2.0, 3.1.1
Reporter: Patrick Hunt
Fix For: 3.2.1, 3.3.0
the javadoc for ZooKeeper constructor says:
* The client object will pick an arbitrary server and try to connect to it.
* If failed, it will try the next one in the list, until a connection is
* established, or all the servers have been tried.
the "or all server tried" phrase is misleading, it should indicate that we retry until success, con closed, or session expired.
we also need ot mention that connection is async, that constructor returns immed and you need to look for connection event in watcher
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-490) the java docs for session
creation are misleading/incomplete
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740504#action_12740504 ]
Hadoop QA commented on ZOOKEEPER-490:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12415675/ZOOKEEPER-490.patch
against trunk revision 801839.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/174/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/174/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/174/console
This message is automatically generated.
> the java docs for session creation are misleading/incomplete
> ------------------------------------------------------------
>
> Key: ZOOKEEPER-490
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-490
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.1.1, 3.2.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-490.patch
>
>
> the javadoc for ZooKeeper constructor says:
> * The client object will pick an arbitrary server and try to connect to it.
> * If failed, it will try the next one in the list, until a connection is
> * established, or all the servers have been tried.
> the "or all server tried" phrase is misleading, it should indicate that we retry until success, con closed, or session expired.
> we also need ot mention that connection is async, that constructor returns immed and you need to look for connection event in watcher
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-490) the java docs for session creation
are misleading/incomplete
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-490:
-----------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I've committed based on ben's +1.
> the java docs for session creation are misleading/incomplete
> ------------------------------------------------------------
>
> Key: ZOOKEEPER-490
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-490
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.1.1, 3.2.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-490.patch
>
>
> the javadoc for ZooKeeper constructor says:
> * The client object will pick an arbitrary server and try to connect to it.
> * If failed, it will try the next one in the list, until a connection is
> * established, or all the servers have been tried.
> the "or all server tried" phrase is misleading, it should indicate that we retry until success, con closed, or session expired.
> we also need ot mention that connection is async, that constructor returns immed and you need to look for connection event in watcher
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-490) the java docs for session creation
are misleading/incomplete
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-490:
-----------------------------------
Status: Patch Available (was: Open)
> the java docs for session creation are misleading/incomplete
> ------------------------------------------------------------
>
> Key: ZOOKEEPER-490
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-490
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.2.0, 3.1.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-490.patch
>
>
> the javadoc for ZooKeeper constructor says:
> * The client object will pick an arbitrary server and try to connect to it.
> * If failed, it will try the next one in the list, until a connection is
> * established, or all the servers have been tried.
> the "or all server tried" phrase is misleading, it should indicate that we retry until success, con closed, or session expired.
> we also need ot mention that connection is async, that constructor returns immed and you need to look for connection event in watcher
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-490) the java docs for session
creation are misleading/incomplete
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740890#action_12740890 ]
Hudson commented on ZOOKEEPER-490:
----------------------------------
Integrated in ZooKeeper-trunk #409 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/409/])
. the java docs for session creation are misleading/incomplete
> the java docs for session creation are misleading/incomplete
> ------------------------------------------------------------
>
> Key: ZOOKEEPER-490
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-490
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.1.1, 3.2.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-490.patch
>
>
> the javadoc for ZooKeeper constructor says:
> * The client object will pick an arbitrary server and try to connect to it.
> * If failed, it will try the next one in the list, until a connection is
> * established, or all the servers have been tried.
> the "or all server tried" phrase is misleading, it should indicate that we retry until success, con closed, or session expired.
> we also need ot mention that connection is async, that constructor returns immed and you need to look for connection event in watcher
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-490) the java docs for session creation
are misleading/incomplete
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-490:
------------------------------------
Hadoop Flags: [Reviewed]
+1 looks good pat
> the java docs for session creation are misleading/incomplete
> ------------------------------------------------------------
>
> Key: ZOOKEEPER-490
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-490
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.1.1, 3.2.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-490.patch
>
>
> the javadoc for ZooKeeper constructor says:
> * The client object will pick an arbitrary server and try to connect to it.
> * If failed, it will try the next one in the list, until a connection is
> * established, or all the servers have been tried.
> the "or all server tried" phrase is misleading, it should indicate that we retry until success, con closed, or session expired.
> we also need ot mention that connection is async, that constructor returns immed and you need to look for connection event in watcher
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-490) the java docs for session creation
are misleading/incomplete
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt reassigned ZOOKEEPER-490:
--------------------------------------
Assignee: Patrick Hunt
> the java docs for session creation are misleading/incomplete
> ------------------------------------------------------------
>
> Key: ZOOKEEPER-490
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-490
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.1.1, 3.2.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.2.1, 3.3.0
>
>
> the javadoc for ZooKeeper constructor says:
> * The client object will pick an arbitrary server and try to connect to it.
> * If failed, it will try the next one in the list, until a connection is
> * established, or all the servers have been tried.
> the "or all server tried" phrase is misleading, it should indicate that we retry until success, con closed, or session expired.
> we also need ot mention that connection is async, that constructor returns immed and you need to look for connection event in watcher
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-490) the java docs for session creation
are misleading/incomplete
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-490:
-----------------------------------
Attachment: ZOOKEEPER-490.patch
this patch updates the javadoc for zk construction
talks about async nature
talks about thread safety
> the java docs for session creation are misleading/incomplete
> ------------------------------------------------------------
>
> Key: ZOOKEEPER-490
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-490
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.1.1, 3.2.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-490.patch
>
>
> the javadoc for ZooKeeper constructor says:
> * The client object will pick an arbitrary server and try to connect to it.
> * If failed, it will try the next one in the list, until a connection is
> * established, or all the servers have been tried.
> the "or all server tried" phrase is misleading, it should indicate that we retry until success, con closed, or session expired.
> we also need ot mention that connection is async, that constructor returns immed and you need to look for connection event in watcher
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.