You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "westonpace (via GitHub)" <gi...@apache.org> on 2023/04/13 21:06:57 UTC
[GitHub] [arrow] westonpace opened a new pull request, #35117: GH-35115: [C++] Moved util_avx2.cc from acero to compute
westonpace opened a new pull request, #35117:
URL: https://github.com/apache/arrow/pull/35117
### Rationale for this change
The file util_avx2.cc contains implementation for methods defined in `src/arrow/compute/util.cc` but it was placed in `src/arrow/acero`. This leads to undefined symbol errors when compiling against AVX2.
### What changes are included in this PR?
The file util_avx2.cc is moved from `acero` to `compute`.
### Are these changes tested?
Regrettably, no. See #35116
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35117: GH-35115: [C++] Moved util_avx2.cc from acero to compute
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35117:
URL: https://github.com/apache/arrow/pull/35117#issuecomment-1515181958
['Python', 'R'] benchmarks have high level of regressions.
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/b2bb5296788d4ad7a5ff21c7741e9bfc...43d8894dc35b4420b0efd00004966e19/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35117: GH-35115: [C++] Moved util_avx2.cc from acero to compute
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35117:
URL: https://github.com/apache/arrow/pull/35117#issuecomment-1515180145
Benchmark runs are scheduled for baseline = 9824ffcd48e444a90098528d4a9150c6e9508626 and contender = ae633bc0442574926e5dca0e77dcfd0e2b0d3004. ae633bc0442574926e5dca0e77dcfd0e2b0d3004 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/43c74d28dd61469fbb743191e1c2080b...8fb063dcf0b4410cac563d4d035c6ec7/)
[Failed] [test-mac-arm](https://conbench.ursa.dev/compare/runs/4af1b9b2c3954d0fa21242f68d19b013...159c9f91536548cf94c76e0f29111a31/)
[Finished :arrow_down:5.61% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/b2bb5296788d4ad7a5ff21c7741e9bfc...43d8894dc35b4420b0efd00004966e19/)
[Finished :arrow_down:0.66% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/5b47708560df442cb3df1dca0f6186c3...276d72b2be8a416d8c272c7e3fa4e2ee/)
Buildkite builds:
[Finished] [`ae633bc0` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2738)
[Failed] [`ae633bc0` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2772)
[Finished] [`ae633bc0` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2736)
[Finished] [`ae633bc0` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2763)
[Finished] [`9824ffcd` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2737)
[Failed] [`9824ffcd` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2771)
[Finished] [`9824ffcd` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2735)
[Finished] [`9824ffcd` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2762)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace merged pull request #35117: GH-35115: [C++] Moved util_avx2.cc from acero to compute
Posted by "westonpace (via GitHub)" <gi...@apache.org>.
westonpace merged PR #35117:
URL: https://github.com/apache/arrow/pull/35117
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35117: GH-35115: [C++] Moved util_avx2.cc from acero to compute
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35117:
URL: https://github.com/apache/arrow/pull/35117#issuecomment-1507610884
:warning: GitHub issue #35115 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] icexelloss commented on pull request #35117: GH-35115: [C++] Moved util_avx2.cc from acero to compute
Posted by "icexelloss (via GitHub)" <gi...@apache.org>.
icexelloss commented on PR #35117:
URL: https://github.com/apache/arrow/pull/35117#issuecomment-1513042654
Sorry missed this - LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35117: GH-35115: [C++] Moved util_avx2.cc from acero to compute
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35117:
URL: https://github.com/apache/arrow/pull/35117#issuecomment-1507610837
* Closes: #35115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org