You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2015/05/08 14:30:19 UTC
Review Request 33976: LENS-26: option to download result into a file
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33976/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-26
https://issues.apache.org/jira/browse/LENS-26
Repository: lens
Description
-------
option to download result into a file
Diffs
-----
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c0616d2a2f7c98d89b4fcaff76f7c6f9d8b35730
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java d7b63724f50dc392a5440ce8362b4eb6ca81f885
src/site/apt/user/cli.apt cbbc3eb9e173f891baf0c7f765efe1a6c5bfa23f
Diff: https://reviews.apache.org/r/33976/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 33976: LENS-26: option to download result into a
file
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33976/#review83355
-----------------------------------------------------------
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java
<https://reviews.apache.org/r/33976/#comment134329>
If result is persisted on server, the result should be downloaded with http link and then saved to file.
With current changes the file contents will be output at some location.
- Amareshwari Sriramadasu
On May 8, 2015, 12:30 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33976/
> -----------------------------------------------------------
>
> (Updated May 8, 2015, 12:30 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-26
> https://issues.apache.org/jira/browse/LENS-26
>
>
> Repository: lens
>
>
> Description
> -------
>
> option to download result into a file
>
>
> Diffs
> -----
>
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c0616d2a2f7c98d89b4fcaff76f7c6f9d8b35730
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java d7b63724f50dc392a5440ce8362b4eb6ca81f885
> src/site/apt/user/cli.apt cbbc3eb9e173f891baf0c7f765efe1a6c5bfa23f
>
> Diff: https://reviews.apache.org/r/33976/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 33976: LENS-26: option to download result into a
file
Posted by Jaideep dhok <ja...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33976/#review83381
-----------------------------------------------------------
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java
<https://reviews.apache.org/r/33976/#comment134365>
I suppose as we are loading entire results in memory, this won't work for large result sets?
We should stream from the socket input stream directly to the file. Otherwise, it kind of defeats the purpose since most likely people would want to dump large result sets to a file.
- Jaideep dhok
On May 8, 2015, 12:30 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33976/
> -----------------------------------------------------------
>
> (Updated May 8, 2015, 12:30 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-26
> https://issues.apache.org/jira/browse/LENS-26
>
>
> Repository: lens
>
>
> Description
> -------
>
> option to download result into a file
>
>
> Diffs
> -----
>
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c0616d2a2f7c98d89b4fcaff76f7c6f9d8b35730
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java d7b63724f50dc392a5440ce8362b4eb6ca81f885
> src/site/apt/user/cli.apt cbbc3eb9e173f891baf0c7f765efe1a6c5bfa23f
>
> Diff: https://reviews.apache.org/r/33976/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 33976: LENS-26: option to download result into a
file
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33976/#review83541
-----------------------------------------------------------
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java
<https://reviews.apache.org/r/33976/#comment134544>
Can we make sure handle is always closed? Can we move close() method call to finally block?
- Raju Bairishetti
On May 12, 2015, 1:59 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33976/
> -----------------------------------------------------------
>
> (Updated May 12, 2015, 1:59 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-26
> https://issues.apache.org/jira/browse/LENS-26
>
>
> Repository: lens
>
>
> Description
> -------
>
> option to download result into a file
>
>
> Diffs
> -----
>
> .reviewboardrc e9a57e0
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c0616d2
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java d7b6372
> src/site/apt/user/cli.apt cbbc3eb
>
> Diff: https://reviews.apache.org/r/33976/diff/
>
>
> Testing
> -------
>
> None
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 33976: LENS-26: option to download result into a
file
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33976/#review83394
-----------------------------------------------------------
Ship it!
Ship It!
- Rajat Khandelwal
On May 12, 2015, 7:29 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33976/
> -----------------------------------------------------------
>
> (Updated May 12, 2015, 7:29 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-26
> https://issues.apache.org/jira/browse/LENS-26
>
>
> Repository: lens
>
>
> Description
> -------
>
> option to download result into a file
>
>
> Diffs
> -----
>
> .reviewboardrc e9a57e0
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c0616d2
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java d7b6372
> src/site/apt/user/cli.apt cbbc3eb
>
> Diff: https://reviews.apache.org/r/33976/diff/
>
>
> Testing
> -------
>
> None
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 33976: LENS-26: option to download result into a
file
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On May 19, 2015, 12:12 p.m., Amareshwari Sriramadasu wrote:
> > lens-client/src/main/java/org/apache/lens/client/LensClient.java, line 155
> > <https://reviews.apache.org/r/33976/diff/5/?file=962593#file962593line155>
> >
> > If httpResultSet is not available, we should say result not downloadable to user, and guideline message should be given on how he can fetch the result
Current design: If http result is there, or if in memory result is there, then it'll be saved to the directory provided with file name `{query_handle}.csv`. Else, the message that comes about the driver persistent queries will be printed.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33976/#review84269
-----------------------------------------------------------
On May 20, 2015, 7:31 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33976/
> -----------------------------------------------------------
>
> (Updated May 20, 2015, 7:31 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-26
> https://issues.apache.org/jira/browse/LENS-26
>
>
> Repository: lens
>
>
> Description
> -------
>
> option to download result into a file
>
>
> Diffs
> -----
>
> checkstyle/src/main/resources/checkstyle.xml 236f977f58f41cd3fee2ebe8445f38dd4a1f0d3b
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java 8707fec5612a04e9a07ed9d5e38f342ef1f9114e
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 05922e394e5fea9e95e67d56d04697ebf438f48d
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDStoragePartitionCommand.java 0d53e2107be116d4dbb855f247b57be0c1b97691
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 64e9ca47c5c7df444cdd16b2d55bc738d6c945bc
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java d7b63724f50dc392a5440ce8362b4eb6ca81f885
> lens-cli/src/test/java/org/apache/lens/cli/doc/TestGenerateCLIUserDoc.java 508690743aa39011722cd56f9ad649d5c83de9c7
> lens-client/src/main/java/org/apache/lens/client/LensClient.java 016e4ab1285582760b5da47b355402b747ea78e8
> lens-client/src/main/java/org/apache/lens/client/LensStatement.java 5ce3a82926ed2bad6f29300d24a18b4cadbe0e4b
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 43985bad1571e6899679551674cea76e6196e8f8
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java a953ec6a2117fa48e0a2ced4daa1f8d8d4e15731
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java 36a48b9ea48eb89780f5c98dc396ae5f176d1bd4
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java f11d8834d4010a1e7c616c6c3dd5ff90a6c577c5
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 0f4e990512beab0fdb0b8e51c08b165e97494a9b
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 3bf180c9ab6f2a9fec6259848ebf65ecd147cfcf
> src/site/apt/user/cli.apt bd394972790792905cb21dd0da5894840f404d8e
>
> Diff: https://reviews.apache.org/r/33976/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.818s]
> [INFO] Lens .............................................. SUCCESS [3.293s]
> [INFO] Lens API .......................................... SUCCESS [20.626s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.116s]
> [INFO] Lens Cube ......................................... SUCCESS [3:30.556s]
> [INFO] Lens DB storage ................................... SUCCESS [21.408s]
> [INFO] Lens Query Library ................................ SUCCESS [15.581s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:56.842s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [37.111s]
> [INFO] Lens Server ....................................... SUCCESS [5:22.697s]
> [INFO] Lens client ....................................... SUCCESS [37.577s]
> [INFO] Lens CLI .......................................... SUCCESS [3:18.496s]
> [INFO] Lens Examples ..................................... SUCCESS [9.647s]
> [INFO] Lens Distribution ................................. SUCCESS [8.324s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.860s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.076s]
> [INFO] Lens Regression ................................... SUCCESS [8.223s]
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 33976: LENS-26: option to download result into a
file
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33976/#review84269
-----------------------------------------------------------
lens-client/src/main/java/org/apache/lens/client/LensClient.java
<https://reviews.apache.org/r/33976/#comment135452>
If httpResultSet is not available, we should say result not downloadable to user, and guideline message should be given on how he can fetch the result
- Amareshwari Sriramadasu
On May 18, 2015, 12:57 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33976/
> -----------------------------------------------------------
>
> (Updated May 18, 2015, 12:57 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-26
> https://issues.apache.org/jira/browse/LENS-26
>
>
> Repository: lens
>
>
> Description
> -------
>
> option to download result into a file
>
>
> Diffs
> -----
>
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java 8707fec5612a04e9a07ed9d5e38f342ef1f9114e
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 05922e394e5fea9e95e67d56d04697ebf438f48d
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDStoragePartitionCommand.java 0d53e2107be116d4dbb855f247b57be0c1b97691
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 64e9ca47c5c7df444cdd16b2d55bc738d6c945bc
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java d7b63724f50dc392a5440ce8362b4eb6ca81f885
> lens-client/src/main/java/org/apache/lens/client/LensClient.java 016e4ab1285582760b5da47b355402b747ea78e8
> lens-client/src/main/java/org/apache/lens/client/LensStatement.java 5ce3a82926ed2bad6f29300d24a18b4cadbe0e4b
> src/site/apt/user/cli.apt bd394972790792905cb21dd0da5894840f404d8e
>
> Diff: https://reviews.apache.org/r/33976/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.818s]
> [INFO] Lens .............................................. SUCCESS [3.293s]
> [INFO] Lens API .......................................... SUCCESS [20.626s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.116s]
> [INFO] Lens Cube ......................................... SUCCESS [3:30.556s]
> [INFO] Lens DB storage ................................... SUCCESS [21.408s]
> [INFO] Lens Query Library ................................ SUCCESS [15.581s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:56.842s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [37.111s]
> [INFO] Lens Server ....................................... SUCCESS [5:22.697s]
> [INFO] Lens client ....................................... SUCCESS [37.577s]
> [INFO] Lens CLI .......................................... SUCCESS [3:18.496s]
> [INFO] Lens Examples ..................................... SUCCESS [9.647s]
> [INFO] Lens Distribution ................................. SUCCESS [8.324s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.860s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.076s]
> [INFO] Lens Regression ................................... SUCCESS [8.223s]
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 33976: LENS-26: option to download result into a
file
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33976/#review84679
-----------------------------------------------------------
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java
<https://reviews.apache.org/r/33976/#comment136030>
jdbc tests failing
- Rajat Khandelwal
On May 21, 2015, 3:06 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33976/
> -----------------------------------------------------------
>
> (Updated May 21, 2015, 3:06 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-26
> https://issues.apache.org/jira/browse/LENS-26
>
>
> Repository: lens
>
>
> Description
> -------
>
> option to download result into a file
>
>
> Diffs
> -----
>
> checkstyle/src/main/resources/checkstyle.xml 236f977f58f41cd3fee2ebe8445f38dd4a1f0d3b
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java 8707fec5612a04e9a07ed9d5e38f342ef1f9114e
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 05922e394e5fea9e95e67d56d04697ebf438f48d
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDStoragePartitionCommand.java 0d53e2107be116d4dbb855f247b57be0c1b97691
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 64e9ca47c5c7df444cdd16b2d55bc738d6c945bc
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java d7b63724f50dc392a5440ce8362b4eb6ca81f885
> lens-cli/src/test/java/org/apache/lens/cli/doc/TestGenerateCLIUserDoc.java 508690743aa39011722cd56f9ad649d5c83de9c7
> lens-client/src/main/java/org/apache/lens/client/LensClient.java 016e4ab1285582760b5da47b355402b747ea78e8
> lens-client/src/main/java/org/apache/lens/client/LensStatement.java 5ce3a82926ed2bad6f29300d24a18b4cadbe0e4b
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 43985bad1571e6899679551674cea76e6196e8f8
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java a953ec6a2117fa48e0a2ced4daa1f8d8d4e15731
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java 36a48b9ea48eb89780f5c98dc396ae5f176d1bd4
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java f11d8834d4010a1e7c616c6c3dd5ff90a6c577c5
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 0f4e990512beab0fdb0b8e51c08b165e97494a9b
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 3bf180c9ab6f2a9fec6259848ebf65ecd147cfcf
> src/site/apt/user/cli.apt bd394972790792905cb21dd0da5894840f404d8e
>
> Diff: https://reviews.apache.org/r/33976/diff/
>
>
> Testing
> -------
>
> Tests with lens persistence:
>
> lens-shell>
> lens-shell>
> lens-shell>set lens.query.enable.persistent.resultset=true
> Set param succeeded
> lens-shell>set lens.query.enable.persistent.resultset.indriver=false
> Set param succeeded
> lens-shell>query execute cube select customer_city_name, store_cost from sales where time_range_in(delivery_time, '2015-04-13-04', '2015-04-13-05') --async true
> 751e983d-5a15-411b-948a-724ddaf26084
> lens-shell>
> lens-shell>query results 751e983d-5a15-411b-948a-724ddaf26084
> Result set metadata can be only queries for successful queries
> lens-shell>query results 751e983d-5a15-411b-948a-724ddaf26084
> customer_city.name _c1
> Results of query stored at : file:/tmp/lensreports/751e983d-5a15-411b-948a-724ddaf26084.csv 2 rows process in (15) seconds.
>
> lens-shell>query results 751e983d-5a15-411b-948a-724ddaf26084 --save_location ~/
> Saved to /Users/rajat.khandelwal/751e983d-5a15-411b-948a-724ddaf26084.csv
> lens-shell>! cat /Users/rajat.khandelwal/751e983d-5a15-411b-948a-724ddaf26084.csv
> command is:cat /Users/rajat.khandelwal/751e983d-5a15-411b-948a-724ddaf26084.csv
> "Bangalore","0.0"
> "Hyderabad","2.0"
> lens-shell>
>
>
> Tests with driver persistence:
>
> lens-shell>set lens.query.enable.persistent.resultset.indriver=true
> Set param succeeded
> lens-shell>set lens.query.enable.persistent.resultset=false
> Set param succeeded
> lens-shell>query execute cube select customer_city_name, store_cost from sales where time_range_in(delivery_time, '2015-04-13-04', '2015-04-13-05') --async true
> d022efaa-ff96-4252-a3c6-2f1d43c30730
> lens-shell>
> lens-shell>query results d022efaa-ff96-4252-a3c6-2f1d43c30730 --save_location ~/
> Can't download the result because it's available in driver's persistence.
> customer_city.name _c1
> Results of query stored at : file:/tmp/lensreports/hdfsout/d022efaa-ff96-4252-a3c6-2f1d43c30730 -1 rows process in (11) seconds.
>
> lens-shell>! ls /tmp/lensreports/hdfsout/d022efaa-ff96-4252-a3c6-2f1d43c30730
> command is:ls /tmp/lensreports/hdfsout/d022efaa-ff96-4252-a3c6-2f1d43c30730
> 000000_0
> lens-shell>! cat /tmp/lensreports/hdfsout/d022efaa-ff96-4252-a3c6-2f1d43c30730/000000_0
> command is:cat /tmp/lensreports/hdfsout/d022efaa-ff96-4252-a3c6-2f1d43c30730/000000_0
> Bangalore0.0
> Hyderabad2.0
> lens-shell>
>
>
> With results in driver's memory, the tests have already been added to TestLensQueryCommands.
>
> JDBC tests are failing for now. I'm looking into it
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 33976: LENS-26: option to download result into a
file
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33976/
-----------------------------------------------------------
(Updated May 21, 2015, 8:48 p.m.)
Review request for lens.
Bugs: LENS-26
https://issues.apache.org/jira/browse/LENS-26
Repository: lens
Description
-------
option to download result into a file
Diffs (updated)
-----
checkstyle/src/main/resources/checkstyle.xml 236f977f58f41cd3fee2ebe8445f38dd4a1f0d3b
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java 8707fec5612a04e9a07ed9d5e38f342ef1f9114e
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 05922e394e5fea9e95e67d56d04697ebf438f48d
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDStoragePartitionCommand.java 0d53e2107be116d4dbb855f247b57be0c1b97691
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 64e9ca47c5c7df444cdd16b2d55bc738d6c945bc
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java d7b63724f50dc392a5440ce8362b4eb6ca81f885
lens-cli/src/test/java/org/apache/lens/cli/doc/TestGenerateCLIUserDoc.java e5fe067bd5464d4821d2ba72cf71cc24f178e157
lens-client/src/main/java/org/apache/lens/client/LensClient.java 9b0c93518be5cd75fe34199237f44d737283fa14
lens-client/src/main/java/org/apache/lens/client/LensStatement.java 5ce3a82926ed2bad6f29300d24a18b4cadbe0e4b
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 43985bad1571e6899679551674cea76e6196e8f8
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java a953ec6a2117fa48e0a2ced4daa1f8d8d4e15731
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java 36a48b9ea48eb89780f5c98dc396ae5f176d1bd4
lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java f11d8834d4010a1e7c616c6c3dd5ff90a6c577c5
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 0f4e990512beab0fdb0b8e51c08b165e97494a9b
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 343cd01b1fdce7ab76b0ca93c5ebbb91e807be94
src/site/apt/user/cli.apt 8efb58bf79d3a370bb7c2e906e2ff9f9db25ca86
Diff: https://reviews.apache.org/r/33976/diff/
Testing
-------
Tests with lens persistence:
lens-shell>
lens-shell>
lens-shell>set lens.query.enable.persistent.resultset=true
Set param succeeded
lens-shell>set lens.query.enable.persistent.resultset.indriver=false
Set param succeeded
lens-shell>query execute cube select customer_city_name, store_cost from sales where time_range_in(delivery_time, '2015-04-13-04', '2015-04-13-05') --async true
751e983d-5a15-411b-948a-724ddaf26084
lens-shell>
lens-shell>query results 751e983d-5a15-411b-948a-724ddaf26084
Result set metadata can be only queries for successful queries
lens-shell>query results 751e983d-5a15-411b-948a-724ddaf26084
customer_city.name _c1
Results of query stored at : file:/tmp/lensreports/751e983d-5a15-411b-948a-724ddaf26084.csv 2 rows process in (15) seconds.
lens-shell>query results 751e983d-5a15-411b-948a-724ddaf26084 --save_location ~/
Saved to /Users/rajat.khandelwal/751e983d-5a15-411b-948a-724ddaf26084.csv
lens-shell>! cat /Users/rajat.khandelwal/751e983d-5a15-411b-948a-724ddaf26084.csv
command is:cat /Users/rajat.khandelwal/751e983d-5a15-411b-948a-724ddaf26084.csv
"Bangalore","0.0"
"Hyderabad","2.0"
lens-shell>
Tests with driver persistence:
lens-shell>set lens.query.enable.persistent.resultset.indriver=true
Set param succeeded
lens-shell>set lens.query.enable.persistent.resultset=false
Set param succeeded
lens-shell>query execute cube select customer_city_name, store_cost from sales where time_range_in(delivery_time, '2015-04-13-04', '2015-04-13-05') --async true
d022efaa-ff96-4252-a3c6-2f1d43c30730
lens-shell>
lens-shell>query results d022efaa-ff96-4252-a3c6-2f1d43c30730 --save_location ~/
Can't download the result because it's available in driver's persistence.
customer_city.name _c1
Results of query stored at : file:/tmp/lensreports/hdfsout/d022efaa-ff96-4252-a3c6-2f1d43c30730 -1 rows process in (11) seconds.
lens-shell>! ls /tmp/lensreports/hdfsout/d022efaa-ff96-4252-a3c6-2f1d43c30730
command is:ls /tmp/lensreports/hdfsout/d022efaa-ff96-4252-a3c6-2f1d43c30730
000000_0
lens-shell>! cat /tmp/lensreports/hdfsout/d022efaa-ff96-4252-a3c6-2f1d43c30730/000000_0
command is:cat /tmp/lensreports/hdfsout/d022efaa-ff96-4252-a3c6-2f1d43c30730/000000_0
Bangalore0.0
Hyderabad2.0
lens-shell>
With results in driver's memory, the tests have already been added to TestLensQueryCommands.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.607s]
[INFO] Lens .............................................. SUCCESS [2.908s]
[INFO] Lens API .......................................... SUCCESS [20.365s]
[INFO] Lens API for server and extensions ................ SUCCESS [22.631s]
[INFO] Lens Cube ......................................... SUCCESS [3:20.968s]
[INFO] Lens DB storage ................................... SUCCESS [20.816s]
[INFO] Lens Query Library ................................ SUCCESS [17.466s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:54.960s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [36.275s]
[INFO] Lens Server ....................................... SUCCESS [5:32.284s]
[INFO] Lens client ....................................... SUCCESS [36.321s]
[INFO] Lens CLI .......................................... SUCCESS [3:20.782s]
[INFO] Lens Examples ..................................... SUCCESS [11.419s]
[INFO] Lens Distribution ................................. SUCCESS [7.824s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:20.895s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.696s]
[INFO] Lens Regression ................................... SUCCESS [7.494s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:38.747s
[INFO] Finished at: Thu May 21 14:54:54 UTC 2015
[INFO] Final Memory: 165M/1264M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 33976: LENS-26: option to download result into a
file
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33976/
-----------------------------------------------------------
(Updated May 21, 2015, 8:39 p.m.)
Review request for lens.
Bugs: LENS-26
https://issues.apache.org/jira/browse/LENS-26
Repository: lens
Description
-------
option to download result into a file
Diffs (updated)
-----
checkstyle/src/main/resources/checkstyle.xml 236f977f58f41cd3fee2ebe8445f38dd4a1f0d3b
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java 8707fec5612a04e9a07ed9d5e38f342ef1f9114e
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 05922e394e5fea9e95e67d56d04697ebf438f48d
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDStoragePartitionCommand.java 0d53e2107be116d4dbb855f247b57be0c1b97691
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 64e9ca47c5c7df444cdd16b2d55bc738d6c945bc
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java d7b63724f50dc392a5440ce8362b4eb6ca81f885
lens-cli/src/test/java/org/apache/lens/cli/doc/TestGenerateCLIUserDoc.java e5fe067bd5464d4821d2ba72cf71cc24f178e157
lens-client/src/main/java/org/apache/lens/client/LensClient.java 9b0c93518be5cd75fe34199237f44d737283fa14
lens-client/src/main/java/org/apache/lens/client/LensStatement.java 5ce3a82926ed2bad6f29300d24a18b4cadbe0e4b
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 43985bad1571e6899679551674cea76e6196e8f8
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java a953ec6a2117fa48e0a2ced4daa1f8d8d4e15731
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java 36a48b9ea48eb89780f5c98dc396ae5f176d1bd4
lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java f11d8834d4010a1e7c616c6c3dd5ff90a6c577c5
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 0f4e990512beab0fdb0b8e51c08b165e97494a9b
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 343cd01b1fdce7ab76b0ca93c5ebbb91e807be94
src/site/apt/user/cli.apt 8efb58bf79d3a370bb7c2e906e2ff9f9db25ca86
Diff: https://reviews.apache.org/r/33976/diff/
Testing (updated)
-------
Tests with lens persistence:
lens-shell>
lens-shell>
lens-shell>set lens.query.enable.persistent.resultset=true
Set param succeeded
lens-shell>set lens.query.enable.persistent.resultset.indriver=false
Set param succeeded
lens-shell>query execute cube select customer_city_name, store_cost from sales where time_range_in(delivery_time, '2015-04-13-04', '2015-04-13-05') --async true
751e983d-5a15-411b-948a-724ddaf26084
lens-shell>
lens-shell>query results 751e983d-5a15-411b-948a-724ddaf26084
Result set metadata can be only queries for successful queries
lens-shell>query results 751e983d-5a15-411b-948a-724ddaf26084
customer_city.name _c1
Results of query stored at : file:/tmp/lensreports/751e983d-5a15-411b-948a-724ddaf26084.csv 2 rows process in (15) seconds.
lens-shell>query results 751e983d-5a15-411b-948a-724ddaf26084 --save_location ~/
Saved to /Users/rajat.khandelwal/751e983d-5a15-411b-948a-724ddaf26084.csv
lens-shell>! cat /Users/rajat.khandelwal/751e983d-5a15-411b-948a-724ddaf26084.csv
command is:cat /Users/rajat.khandelwal/751e983d-5a15-411b-948a-724ddaf26084.csv
"Bangalore","0.0"
"Hyderabad","2.0"
lens-shell>
Tests with driver persistence:
lens-shell>set lens.query.enable.persistent.resultset.indriver=true
Set param succeeded
lens-shell>set lens.query.enable.persistent.resultset=false
Set param succeeded
lens-shell>query execute cube select customer_city_name, store_cost from sales where time_range_in(delivery_time, '2015-04-13-04', '2015-04-13-05') --async true
d022efaa-ff96-4252-a3c6-2f1d43c30730
lens-shell>
lens-shell>query results d022efaa-ff96-4252-a3c6-2f1d43c30730 --save_location ~/
Can't download the result because it's available in driver's persistence.
customer_city.name _c1
Results of query stored at : file:/tmp/lensreports/hdfsout/d022efaa-ff96-4252-a3c6-2f1d43c30730 -1 rows process in (11) seconds.
lens-shell>! ls /tmp/lensreports/hdfsout/d022efaa-ff96-4252-a3c6-2f1d43c30730
command is:ls /tmp/lensreports/hdfsout/d022efaa-ff96-4252-a3c6-2f1d43c30730
000000_0
lens-shell>! cat /tmp/lensreports/hdfsout/d022efaa-ff96-4252-a3c6-2f1d43c30730/000000_0
command is:cat /tmp/lensreports/hdfsout/d022efaa-ff96-4252-a3c6-2f1d43c30730/000000_0
Bangalore0.0
Hyderabad2.0
lens-shell>
With results in driver's memory, the tests have already been added to TestLensQueryCommands.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.607s]
[INFO] Lens .............................................. SUCCESS [2.908s]
[INFO] Lens API .......................................... SUCCESS [20.365s]
[INFO] Lens API for server and extensions ................ SUCCESS [22.631s]
[INFO] Lens Cube ......................................... SUCCESS [3:20.968s]
[INFO] Lens DB storage ................................... SUCCESS [20.816s]
[INFO] Lens Query Library ................................ SUCCESS [17.466s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:54.960s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [36.275s]
[INFO] Lens Server ....................................... SUCCESS [5:32.284s]
[INFO] Lens client ....................................... SUCCESS [36.321s]
[INFO] Lens CLI .......................................... SUCCESS [3:20.782s]
[INFO] Lens Examples ..................................... SUCCESS [11.419s]
[INFO] Lens Distribution ................................. SUCCESS [7.824s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:20.895s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.696s]
[INFO] Lens Regression ................................... SUCCESS [7.494s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:38.747s
[INFO] Finished at: Thu May 21 14:54:54 UTC 2015
[INFO] Final Memory: 165M/1264M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 33976: LENS-26: option to download result into a
file
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33976/
-----------------------------------------------------------
(Updated May 21, 2015, 3:38 p.m.)
Review request for lens.
Bugs: LENS-26
https://issues.apache.org/jira/browse/LENS-26
Repository: lens
Description
-------
option to download result into a file
Diffs (updated)
-----
checkstyle/src/main/resources/checkstyle.xml 236f977f58f41cd3fee2ebe8445f38dd4a1f0d3b
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java 8707fec5612a04e9a07ed9d5e38f342ef1f9114e
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 05922e394e5fea9e95e67d56d04697ebf438f48d
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDStoragePartitionCommand.java 0d53e2107be116d4dbb855f247b57be0c1b97691
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 64e9ca47c5c7df444cdd16b2d55bc738d6c945bc
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java d7b63724f50dc392a5440ce8362b4eb6ca81f885
lens-cli/src/test/java/org/apache/lens/cli/doc/TestGenerateCLIUserDoc.java 508690743aa39011722cd56f9ad649d5c83de9c7
lens-client/src/main/java/org/apache/lens/client/LensClient.java 016e4ab1285582760b5da47b355402b747ea78e8
lens-client/src/main/java/org/apache/lens/client/LensStatement.java 5ce3a82926ed2bad6f29300d24a18b4cadbe0e4b
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 43985bad1571e6899679551674cea76e6196e8f8
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java a953ec6a2117fa48e0a2ced4daa1f8d8d4e15731
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java 36a48b9ea48eb89780f5c98dc396ae5f176d1bd4
lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java f11d8834d4010a1e7c616c6c3dd5ff90a6c577c5
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 0f4e990512beab0fdb0b8e51c08b165e97494a9b
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 3bf180c9ab6f2a9fec6259848ebf65ecd147cfcf
src/site/apt/user/cli.apt bd394972790792905cb21dd0da5894840f404d8e
Diff: https://reviews.apache.org/r/33976/diff/
Testing (updated)
-------
Tests with lens persistence:
lens-shell>
lens-shell>
lens-shell>set lens.query.enable.persistent.resultset=true
Set param succeeded
lens-shell>set lens.query.enable.persistent.resultset.indriver=false
Set param succeeded
lens-shell>query execute cube select customer_city_name, store_cost from sales where time_range_in(delivery_time, '2015-04-13-04', '2015-04-13-05') --async true
751e983d-5a15-411b-948a-724ddaf26084
lens-shell>
lens-shell>query results 751e983d-5a15-411b-948a-724ddaf26084
Result set metadata can be only queries for successful queries
lens-shell>query results 751e983d-5a15-411b-948a-724ddaf26084
customer_city.name _c1
Results of query stored at : file:/tmp/lensreports/751e983d-5a15-411b-948a-724ddaf26084.csv 2 rows process in (15) seconds.
lens-shell>query results 751e983d-5a15-411b-948a-724ddaf26084 --save_location ~/
Saved to /Users/rajat.khandelwal/751e983d-5a15-411b-948a-724ddaf26084.csv
lens-shell>! cat /Users/rajat.khandelwal/751e983d-5a15-411b-948a-724ddaf26084.csv
command is:cat /Users/rajat.khandelwal/751e983d-5a15-411b-948a-724ddaf26084.csv
"Bangalore","0.0"
"Hyderabad","2.0"
lens-shell>
Tests with driver persistence:
lens-shell>set lens.query.enable.persistent.resultset.indriver=true
Set param succeeded
lens-shell>set lens.query.enable.persistent.resultset=false
Set param succeeded
lens-shell>query execute cube select customer_city_name, store_cost from sales where time_range_in(delivery_time, '2015-04-13-04', '2015-04-13-05') --async true
d022efaa-ff96-4252-a3c6-2f1d43c30730
lens-shell>
lens-shell>query results d022efaa-ff96-4252-a3c6-2f1d43c30730 --save_location ~/
Can't download the result because it's available in driver's persistence.
customer_city.name _c1
Results of query stored at : file:/tmp/lensreports/hdfsout/d022efaa-ff96-4252-a3c6-2f1d43c30730 -1 rows process in (11) seconds.
lens-shell>! ls /tmp/lensreports/hdfsout/d022efaa-ff96-4252-a3c6-2f1d43c30730
command is:ls /tmp/lensreports/hdfsout/d022efaa-ff96-4252-a3c6-2f1d43c30730
000000_0
lens-shell>! cat /tmp/lensreports/hdfsout/d022efaa-ff96-4252-a3c6-2f1d43c30730/000000_0
command is:cat /tmp/lensreports/hdfsout/d022efaa-ff96-4252-a3c6-2f1d43c30730/000000_0
Bangalore0.0
Hyderabad2.0
lens-shell>
With results in driver's memory, the tests have already been added to TestLensQueryCommands.
JDBC tests are failing for now. I'm looking into it
jdbc tests passing after last change. Testing by running all tests
Thanks,
Rajat Khandelwal
Re: Review Request 33976: LENS-26: option to download result into a
file
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33976/
-----------------------------------------------------------
(Updated May 21, 2015, 3:06 p.m.)
Review request for lens.
Bugs: LENS-26
https://issues.apache.org/jira/browse/LENS-26
Repository: lens
Description
-------
option to download result into a file
Diffs
-----
checkstyle/src/main/resources/checkstyle.xml 236f977f58f41cd3fee2ebe8445f38dd4a1f0d3b
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java 8707fec5612a04e9a07ed9d5e38f342ef1f9114e
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 05922e394e5fea9e95e67d56d04697ebf438f48d
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDStoragePartitionCommand.java 0d53e2107be116d4dbb855f247b57be0c1b97691
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 64e9ca47c5c7df444cdd16b2d55bc738d6c945bc
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java d7b63724f50dc392a5440ce8362b4eb6ca81f885
lens-cli/src/test/java/org/apache/lens/cli/doc/TestGenerateCLIUserDoc.java 508690743aa39011722cd56f9ad649d5c83de9c7
lens-client/src/main/java/org/apache/lens/client/LensClient.java 016e4ab1285582760b5da47b355402b747ea78e8
lens-client/src/main/java/org/apache/lens/client/LensStatement.java 5ce3a82926ed2bad6f29300d24a18b4cadbe0e4b
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 43985bad1571e6899679551674cea76e6196e8f8
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java a953ec6a2117fa48e0a2ced4daa1f8d8d4e15731
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java 36a48b9ea48eb89780f5c98dc396ae5f176d1bd4
lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java f11d8834d4010a1e7c616c6c3dd5ff90a6c577c5
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 0f4e990512beab0fdb0b8e51c08b165e97494a9b
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 3bf180c9ab6f2a9fec6259848ebf65ecd147cfcf
src/site/apt/user/cli.apt bd394972790792905cb21dd0da5894840f404d8e
Diff: https://reviews.apache.org/r/33976/diff/
Testing (updated)
-------
Tests with lens persistence:
lens-shell>
lens-shell>
lens-shell>set lens.query.enable.persistent.resultset=true
Set param succeeded
lens-shell>set lens.query.enable.persistent.resultset.indriver=false
Set param succeeded
lens-shell>query execute cube select customer_city_name, store_cost from sales where time_range_in(delivery_time, '2015-04-13-04', '2015-04-13-05') --async true
751e983d-5a15-411b-948a-724ddaf26084
lens-shell>
lens-shell>query results 751e983d-5a15-411b-948a-724ddaf26084
Result set metadata can be only queries for successful queries
lens-shell>query results 751e983d-5a15-411b-948a-724ddaf26084
customer_city.name _c1
Results of query stored at : file:/tmp/lensreports/751e983d-5a15-411b-948a-724ddaf26084.csv 2 rows process in (15) seconds.
lens-shell>query results 751e983d-5a15-411b-948a-724ddaf26084 --save_location ~/
Saved to /Users/rajat.khandelwal/751e983d-5a15-411b-948a-724ddaf26084.csv
lens-shell>! cat /Users/rajat.khandelwal/751e983d-5a15-411b-948a-724ddaf26084.csv
command is:cat /Users/rajat.khandelwal/751e983d-5a15-411b-948a-724ddaf26084.csv
"Bangalore","0.0"
"Hyderabad","2.0"
lens-shell>
Tests with driver persistence:
lens-shell>set lens.query.enable.persistent.resultset.indriver=true
Set param succeeded
lens-shell>set lens.query.enable.persistent.resultset=false
Set param succeeded
lens-shell>query execute cube select customer_city_name, store_cost from sales where time_range_in(delivery_time, '2015-04-13-04', '2015-04-13-05') --async true
d022efaa-ff96-4252-a3c6-2f1d43c30730
lens-shell>
lens-shell>query results d022efaa-ff96-4252-a3c6-2f1d43c30730 --save_location ~/
Can't download the result because it's available in driver's persistence.
customer_city.name _c1
Results of query stored at : file:/tmp/lensreports/hdfsout/d022efaa-ff96-4252-a3c6-2f1d43c30730 -1 rows process in (11) seconds.
lens-shell>! ls /tmp/lensreports/hdfsout/d022efaa-ff96-4252-a3c6-2f1d43c30730
command is:ls /tmp/lensreports/hdfsout/d022efaa-ff96-4252-a3c6-2f1d43c30730
000000_0
lens-shell>! cat /tmp/lensreports/hdfsout/d022efaa-ff96-4252-a3c6-2f1d43c30730/000000_0
command is:cat /tmp/lensreports/hdfsout/d022efaa-ff96-4252-a3c6-2f1d43c30730/000000_0
Bangalore0.0
Hyderabad2.0
lens-shell>
With results in driver's memory, the tests have already been added to TestLensQueryCommands.
JDBC tests are failing for now. I'm looking into it
Thanks,
Rajat Khandelwal
Re: Review Request 33976: LENS-26: option to download result into a
file
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33976/#review84676
-----------------------------------------------------------
Ship it!
Please update testing done with all combinations of save-location and resultset persistence - with whats displayed on CLI
- Amareshwari Sriramadasu
On May 20, 2015, 2:01 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33976/
> -----------------------------------------------------------
>
> (Updated May 20, 2015, 2:01 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-26
> https://issues.apache.org/jira/browse/LENS-26
>
>
> Repository: lens
>
>
> Description
> -------
>
> option to download result into a file
>
>
> Diffs
> -----
>
> checkstyle/src/main/resources/checkstyle.xml 236f977f58f41cd3fee2ebe8445f38dd4a1f0d3b
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java 8707fec5612a04e9a07ed9d5e38f342ef1f9114e
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 05922e394e5fea9e95e67d56d04697ebf438f48d
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDStoragePartitionCommand.java 0d53e2107be116d4dbb855f247b57be0c1b97691
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 64e9ca47c5c7df444cdd16b2d55bc738d6c945bc
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java d7b63724f50dc392a5440ce8362b4eb6ca81f885
> lens-cli/src/test/java/org/apache/lens/cli/doc/TestGenerateCLIUserDoc.java 508690743aa39011722cd56f9ad649d5c83de9c7
> lens-client/src/main/java/org/apache/lens/client/LensClient.java 016e4ab1285582760b5da47b355402b747ea78e8
> lens-client/src/main/java/org/apache/lens/client/LensStatement.java 5ce3a82926ed2bad6f29300d24a18b4cadbe0e4b
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 43985bad1571e6899679551674cea76e6196e8f8
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java a953ec6a2117fa48e0a2ced4daa1f8d8d4e15731
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java 36a48b9ea48eb89780f5c98dc396ae5f176d1bd4
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java f11d8834d4010a1e7c616c6c3dd5ff90a6c577c5
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 0f4e990512beab0fdb0b8e51c08b165e97494a9b
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 3bf180c9ab6f2a9fec6259848ebf65ecd147cfcf
> src/site/apt/user/cli.apt bd394972790792905cb21dd0da5894840f404d8e
>
> Diff: https://reviews.apache.org/r/33976/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.818s]
> [INFO] Lens .............................................. SUCCESS [3.293s]
> [INFO] Lens API .......................................... SUCCESS [20.626s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.116s]
> [INFO] Lens Cube ......................................... SUCCESS [3:30.556s]
> [INFO] Lens DB storage ................................... SUCCESS [21.408s]
> [INFO] Lens Query Library ................................ SUCCESS [15.581s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:56.842s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [37.111s]
> [INFO] Lens Server ....................................... SUCCESS [5:22.697s]
> [INFO] Lens client ....................................... SUCCESS [37.577s]
> [INFO] Lens CLI .......................................... SUCCESS [3:18.496s]
> [INFO] Lens Examples ..................................... SUCCESS [9.647s]
> [INFO] Lens Distribution ................................. SUCCESS [8.324s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.860s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.076s]
> [INFO] Lens Regression ................................... SUCCESS [8.223s]
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 33976: LENS-26: option to download result into a
file
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33976/
-----------------------------------------------------------
(Updated May 20, 2015, 7:31 p.m.)
Review request for lens.
Bugs: LENS-26
https://issues.apache.org/jira/browse/LENS-26
Repository: lens
Description
-------
option to download result into a file
Diffs (updated)
-----
checkstyle/src/main/resources/checkstyle.xml 236f977f58f41cd3fee2ebe8445f38dd4a1f0d3b
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java 8707fec5612a04e9a07ed9d5e38f342ef1f9114e
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 05922e394e5fea9e95e67d56d04697ebf438f48d
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDStoragePartitionCommand.java 0d53e2107be116d4dbb855f247b57be0c1b97691
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 64e9ca47c5c7df444cdd16b2d55bc738d6c945bc
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java d7b63724f50dc392a5440ce8362b4eb6ca81f885
lens-cli/src/test/java/org/apache/lens/cli/doc/TestGenerateCLIUserDoc.java 508690743aa39011722cd56f9ad649d5c83de9c7
lens-client/src/main/java/org/apache/lens/client/LensClient.java 016e4ab1285582760b5da47b355402b747ea78e8
lens-client/src/main/java/org/apache/lens/client/LensStatement.java 5ce3a82926ed2bad6f29300d24a18b4cadbe0e4b
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 43985bad1571e6899679551674cea76e6196e8f8
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java a953ec6a2117fa48e0a2ced4daa1f8d8d4e15731
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java 36a48b9ea48eb89780f5c98dc396ae5f176d1bd4
lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java f11d8834d4010a1e7c616c6c3dd5ff90a6c577c5
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 0f4e990512beab0fdb0b8e51c08b165e97494a9b
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 3bf180c9ab6f2a9fec6259848ebf65ecd147cfcf
src/site/apt/user/cli.apt bd394972790792905cb21dd0da5894840f404d8e
Diff: https://reviews.apache.org/r/33976/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.818s]
[INFO] Lens .............................................. SUCCESS [3.293s]
[INFO] Lens API .......................................... SUCCESS [20.626s]
[INFO] Lens API for server and extensions ................ SUCCESS [21.116s]
[INFO] Lens Cube ......................................... SUCCESS [3:30.556s]
[INFO] Lens DB storage ................................... SUCCESS [21.408s]
[INFO] Lens Query Library ................................ SUCCESS [15.581s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:56.842s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [37.111s]
[INFO] Lens Server ....................................... SUCCESS [5:22.697s]
[INFO] Lens client ....................................... SUCCESS [37.577s]
[INFO] Lens CLI .......................................... SUCCESS [3:18.496s]
[INFO] Lens Examples ..................................... SUCCESS [9.647s]
[INFO] Lens Distribution ................................. SUCCESS [8.324s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:21.860s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.076s]
[INFO] Lens Regression ................................... SUCCESS [8.223s]
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 33976: LENS-26: option to download result into a
file
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33976/
-----------------------------------------------------------
(Updated May 20, 2015, 7:16 p.m.)
Review request for lens.
Bugs: LENS-26
https://issues.apache.org/jira/browse/LENS-26
Repository: lens
Description
-------
option to download result into a file
Diffs (updated)
-----
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java 8707fec5612a04e9a07ed9d5e38f342ef1f9114e
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 05922e394e5fea9e95e67d56d04697ebf438f48d
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDStoragePartitionCommand.java 0d53e2107be116d4dbb855f247b57be0c1b97691
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 64e9ca47c5c7df444cdd16b2d55bc738d6c945bc
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java d7b63724f50dc392a5440ce8362b4eb6ca81f885
lens-cli/src/test/java/org/apache/lens/cli/doc/TestGenerateCLIUserDoc.java 508690743aa39011722cd56f9ad649d5c83de9c7
lens-client/src/main/java/org/apache/lens/client/LensClient.java 016e4ab1285582760b5da47b355402b747ea78e8
lens-client/src/main/java/org/apache/lens/client/LensStatement.java 5ce3a82926ed2bad6f29300d24a18b4cadbe0e4b
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 43985bad1571e6899679551674cea76e6196e8f8
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java a953ec6a2117fa48e0a2ced4daa1f8d8d4e15731
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java 36a48b9ea48eb89780f5c98dc396ae5f176d1bd4
lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java f11d8834d4010a1e7c616c6c3dd5ff90a6c577c5
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 0f4e990512beab0fdb0b8e51c08b165e97494a9b
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 3bf180c9ab6f2a9fec6259848ebf65ecd147cfcf
src/site/apt/user/cli.apt bd394972790792905cb21dd0da5894840f404d8e
Diff: https://reviews.apache.org/r/33976/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.818s]
[INFO] Lens .............................................. SUCCESS [3.293s]
[INFO] Lens API .......................................... SUCCESS [20.626s]
[INFO] Lens API for server and extensions ................ SUCCESS [21.116s]
[INFO] Lens Cube ......................................... SUCCESS [3:30.556s]
[INFO] Lens DB storage ................................... SUCCESS [21.408s]
[INFO] Lens Query Library ................................ SUCCESS [15.581s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:56.842s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [37.111s]
[INFO] Lens Server ....................................... SUCCESS [5:22.697s]
[INFO] Lens client ....................................... SUCCESS [37.577s]
[INFO] Lens CLI .......................................... SUCCESS [3:18.496s]
[INFO] Lens Examples ..................................... SUCCESS [9.647s]
[INFO] Lens Distribution ................................. SUCCESS [8.324s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:21.860s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.076s]
[INFO] Lens Regression ................................... SUCCESS [8.223s]
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 33976: LENS-26: option to download result into a
file
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On May 20, 2015, 5:30 p.m., Amareshwari Sriramadasu wrote:
> > lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java, line 209
> > <https://reviews.apache.org/r/33976/diff/6/?file=963607#file963607line209>
> >
> > missing close?
> >
> > Will the above try close both input and output streams? I'm seeing some new code today, can you point to documentation for this?
https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html
> On May 20, 2015, 5:30 p.m., Amareshwari Sriramadasu wrote:
> > lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java, line 288
> > <https://reviews.apache.org/r/33976/diff/6/?file=963607#file963607line288>
> >
> > finally IOUtils.close ?
Similar thing as above.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33976/#review84499
-----------------------------------------------------------
On May 20, 2015, 5:17 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33976/
> -----------------------------------------------------------
>
> (Updated May 20, 2015, 5:17 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-26
> https://issues.apache.org/jira/browse/LENS-26
>
>
> Repository: lens
>
>
> Description
> -------
>
> option to download result into a file
>
>
> Diffs
> -----
>
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java 8707fec5612a04e9a07ed9d5e38f342ef1f9114e
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 05922e394e5fea9e95e67d56d04697ebf438f48d
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDStoragePartitionCommand.java 0d53e2107be116d4dbb855f247b57be0c1b97691
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 64e9ca47c5c7df444cdd16b2d55bc738d6c945bc
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java d7b63724f50dc392a5440ce8362b4eb6ca81f885
> lens-cli/src/test/java/org/apache/lens/cli/doc/TestGenerateCLIUserDoc.java 508690743aa39011722cd56f9ad649d5c83de9c7
> lens-client/src/main/java/org/apache/lens/client/LensClient.java 016e4ab1285582760b5da47b355402b747ea78e8
> lens-client/src/main/java/org/apache/lens/client/LensStatement.java 5ce3a82926ed2bad6f29300d24a18b4cadbe0e4b
> src/site/apt/user/cli.apt bd394972790792905cb21dd0da5894840f404d8e
>
> Diff: https://reviews.apache.org/r/33976/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.818s]
> [INFO] Lens .............................................. SUCCESS [3.293s]
> [INFO] Lens API .......................................... SUCCESS [20.626s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.116s]
> [INFO] Lens Cube ......................................... SUCCESS [3:30.556s]
> [INFO] Lens DB storage ................................... SUCCESS [21.408s]
> [INFO] Lens Query Library ................................ SUCCESS [15.581s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:56.842s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [37.111s]
> [INFO] Lens Server ....................................... SUCCESS [5:22.697s]
> [INFO] Lens client ....................................... SUCCESS [37.577s]
> [INFO] Lens CLI .......................................... SUCCESS [3:18.496s]
> [INFO] Lens Examples ..................................... SUCCESS [9.647s]
> [INFO] Lens Distribution ................................. SUCCESS [8.324s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.860s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.076s]
> [INFO] Lens Regression ................................... SUCCESS [8.223s]
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 33976: LENS-26: option to download result into a
file
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33976/#review84499
-----------------------------------------------------------
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java
<https://reviews.apache.org/r/33976/#comment135814>
missing close?
Will the above try close both input and output streams? I'm seeing some new code today, can you point to documentation for this?
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java
<https://reviews.apache.org/r/33976/#comment135815>
finally IOUtils.close ?
- Amareshwari Sriramadasu
On May 20, 2015, 11:47 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33976/
> -----------------------------------------------------------
>
> (Updated May 20, 2015, 11:47 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-26
> https://issues.apache.org/jira/browse/LENS-26
>
>
> Repository: lens
>
>
> Description
> -------
>
> option to download result into a file
>
>
> Diffs
> -----
>
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java 8707fec5612a04e9a07ed9d5e38f342ef1f9114e
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 05922e394e5fea9e95e67d56d04697ebf438f48d
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDStoragePartitionCommand.java 0d53e2107be116d4dbb855f247b57be0c1b97691
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 64e9ca47c5c7df444cdd16b2d55bc738d6c945bc
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java d7b63724f50dc392a5440ce8362b4eb6ca81f885
> lens-cli/src/test/java/org/apache/lens/cli/doc/TestGenerateCLIUserDoc.java 508690743aa39011722cd56f9ad649d5c83de9c7
> lens-client/src/main/java/org/apache/lens/client/LensClient.java 016e4ab1285582760b5da47b355402b747ea78e8
> lens-client/src/main/java/org/apache/lens/client/LensStatement.java 5ce3a82926ed2bad6f29300d24a18b4cadbe0e4b
> src/site/apt/user/cli.apt bd394972790792905cb21dd0da5894840f404d8e
>
> Diff: https://reviews.apache.org/r/33976/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.818s]
> [INFO] Lens .............................................. SUCCESS [3.293s]
> [INFO] Lens API .......................................... SUCCESS [20.626s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.116s]
> [INFO] Lens Cube ......................................... SUCCESS [3:30.556s]
> [INFO] Lens DB storage ................................... SUCCESS [21.408s]
> [INFO] Lens Query Library ................................ SUCCESS [15.581s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:56.842s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [37.111s]
> [INFO] Lens Server ....................................... SUCCESS [5:22.697s]
> [INFO] Lens client ....................................... SUCCESS [37.577s]
> [INFO] Lens CLI .......................................... SUCCESS [3:18.496s]
> [INFO] Lens Examples ..................................... SUCCESS [9.647s]
> [INFO] Lens Distribution ................................. SUCCESS [8.324s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.860s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.076s]
> [INFO] Lens Regression ................................... SUCCESS [8.223s]
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 33976: LENS-26: option to download result into a
file
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33976/
-----------------------------------------------------------
(Updated May 20, 2015, 5:17 p.m.)
Review request for lens.
Bugs: LENS-26
https://issues.apache.org/jira/browse/LENS-26
Repository: lens
Description
-------
option to download result into a file
Diffs (updated)
-----
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java 8707fec5612a04e9a07ed9d5e38f342ef1f9114e
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 05922e394e5fea9e95e67d56d04697ebf438f48d
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDStoragePartitionCommand.java 0d53e2107be116d4dbb855f247b57be0c1b97691
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 64e9ca47c5c7df444cdd16b2d55bc738d6c945bc
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java d7b63724f50dc392a5440ce8362b4eb6ca81f885
lens-cli/src/test/java/org/apache/lens/cli/doc/TestGenerateCLIUserDoc.java 508690743aa39011722cd56f9ad649d5c83de9c7
lens-client/src/main/java/org/apache/lens/client/LensClient.java 016e4ab1285582760b5da47b355402b747ea78e8
lens-client/src/main/java/org/apache/lens/client/LensStatement.java 5ce3a82926ed2bad6f29300d24a18b4cadbe0e4b
src/site/apt/user/cli.apt bd394972790792905cb21dd0da5894840f404d8e
Diff: https://reviews.apache.org/r/33976/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.818s]
[INFO] Lens .............................................. SUCCESS [3.293s]
[INFO] Lens API .......................................... SUCCESS [20.626s]
[INFO] Lens API for server and extensions ................ SUCCESS [21.116s]
[INFO] Lens Cube ......................................... SUCCESS [3:30.556s]
[INFO] Lens DB storage ................................... SUCCESS [21.408s]
[INFO] Lens Query Library ................................ SUCCESS [15.581s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:56.842s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [37.111s]
[INFO] Lens Server ....................................... SUCCESS [5:22.697s]
[INFO] Lens client ....................................... SUCCESS [37.577s]
[INFO] Lens CLI .......................................... SUCCESS [3:18.496s]
[INFO] Lens Examples ..................................... SUCCESS [9.647s]
[INFO] Lens Distribution ................................. SUCCESS [8.324s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:21.860s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.076s]
[INFO] Lens Regression ................................... SUCCESS [8.223s]
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 33976: LENS-26: option to download result into a
file
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On May 19, 2015, 1:50 p.m., Raju Bairishetti wrote:
> > lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java, line 286
> > <https://reviews.apache.org/r/33976/diff/5/?file=962591#file962591line286>
> >
> > Seems not closing the outStream? Can we call IOUtils.closeStream() or handle in try(outStream)?
Everything inside `try(blah)` is closed.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33976/#review84281
-----------------------------------------------------------
On May 18, 2015, 6:27 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33976/
> -----------------------------------------------------------
>
> (Updated May 18, 2015, 6:27 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-26
> https://issues.apache.org/jira/browse/LENS-26
>
>
> Repository: lens
>
>
> Description
> -------
>
> option to download result into a file
>
>
> Diffs
> -----
>
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java 8707fec5612a04e9a07ed9d5e38f342ef1f9114e
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 05922e394e5fea9e95e67d56d04697ebf438f48d
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDStoragePartitionCommand.java 0d53e2107be116d4dbb855f247b57be0c1b97691
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 64e9ca47c5c7df444cdd16b2d55bc738d6c945bc
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java d7b63724f50dc392a5440ce8362b4eb6ca81f885
> lens-client/src/main/java/org/apache/lens/client/LensClient.java 016e4ab1285582760b5da47b355402b747ea78e8
> lens-client/src/main/java/org/apache/lens/client/LensStatement.java 5ce3a82926ed2bad6f29300d24a18b4cadbe0e4b
> src/site/apt/user/cli.apt bd394972790792905cb21dd0da5894840f404d8e
>
> Diff: https://reviews.apache.org/r/33976/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.818s]
> [INFO] Lens .............................................. SUCCESS [3.293s]
> [INFO] Lens API .......................................... SUCCESS [20.626s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.116s]
> [INFO] Lens Cube ......................................... SUCCESS [3:30.556s]
> [INFO] Lens DB storage ................................... SUCCESS [21.408s]
> [INFO] Lens Query Library ................................ SUCCESS [15.581s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:56.842s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [37.111s]
> [INFO] Lens Server ....................................... SUCCESS [5:22.697s]
> [INFO] Lens client ....................................... SUCCESS [37.577s]
> [INFO] Lens CLI .......................................... SUCCESS [3:18.496s]
> [INFO] Lens Examples ..................................... SUCCESS [9.647s]
> [INFO] Lens Distribution ................................. SUCCESS [8.324s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.860s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.076s]
> [INFO] Lens Regression ................................... SUCCESS [8.223s]
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 33976: LENS-26: option to download result into a
file
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33976/#review84281
-----------------------------------------------------------
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java
<https://reviews.apache.org/r/33976/#comment135501>
Seems not closing the outStream? Can we call IOUtils.closeStream() or handle in try(outStream)?
- Raju Bairishetti
On May 18, 2015, 12:57 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33976/
> -----------------------------------------------------------
>
> (Updated May 18, 2015, 12:57 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-26
> https://issues.apache.org/jira/browse/LENS-26
>
>
> Repository: lens
>
>
> Description
> -------
>
> option to download result into a file
>
>
> Diffs
> -----
>
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java 8707fec5612a04e9a07ed9d5e38f342ef1f9114e
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 05922e394e5fea9e95e67d56d04697ebf438f48d
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDStoragePartitionCommand.java 0d53e2107be116d4dbb855f247b57be0c1b97691
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 64e9ca47c5c7df444cdd16b2d55bc738d6c945bc
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java d7b63724f50dc392a5440ce8362b4eb6ca81f885
> lens-client/src/main/java/org/apache/lens/client/LensClient.java 016e4ab1285582760b5da47b355402b747ea78e8
> lens-client/src/main/java/org/apache/lens/client/LensStatement.java 5ce3a82926ed2bad6f29300d24a18b4cadbe0e4b
> src/site/apt/user/cli.apt bd394972790792905cb21dd0da5894840f404d8e
>
> Diff: https://reviews.apache.org/r/33976/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.818s]
> [INFO] Lens .............................................. SUCCESS [3.293s]
> [INFO] Lens API .......................................... SUCCESS [20.626s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.116s]
> [INFO] Lens Cube ......................................... SUCCESS [3:30.556s]
> [INFO] Lens DB storage ................................... SUCCESS [21.408s]
> [INFO] Lens Query Library ................................ SUCCESS [15.581s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:56.842s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [37.111s]
> [INFO] Lens Server ....................................... SUCCESS [5:22.697s]
> [INFO] Lens client ....................................... SUCCESS [37.577s]
> [INFO] Lens CLI .......................................... SUCCESS [3:18.496s]
> [INFO] Lens Examples ..................................... SUCCESS [9.647s]
> [INFO] Lens Distribution ................................. SUCCESS [8.324s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.860s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.076s]
> [INFO] Lens Regression ................................... SUCCESS [8.223s]
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 33976: LENS-26: option to download result into a
file
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33976/#review84266
-----------------------------------------------------------
src/site/apt/user/cli.apt
<https://reviews.apache.org/r/33976/#comment135450>
Someone please review. It has my own ship it! from the time I was testing the patch review tool.
- Rajat Khandelwal
On May 18, 2015, 6:27 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33976/
> -----------------------------------------------------------
>
> (Updated May 18, 2015, 6:27 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-26
> https://issues.apache.org/jira/browse/LENS-26
>
>
> Repository: lens
>
>
> Description
> -------
>
> option to download result into a file
>
>
> Diffs
> -----
>
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java 8707fec5612a04e9a07ed9d5e38f342ef1f9114e
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 05922e394e5fea9e95e67d56d04697ebf438f48d
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDStoragePartitionCommand.java 0d53e2107be116d4dbb855f247b57be0c1b97691
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 64e9ca47c5c7df444cdd16b2d55bc738d6c945bc
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java d7b63724f50dc392a5440ce8362b4eb6ca81f885
> lens-client/src/main/java/org/apache/lens/client/LensClient.java 016e4ab1285582760b5da47b355402b747ea78e8
> lens-client/src/main/java/org/apache/lens/client/LensStatement.java 5ce3a82926ed2bad6f29300d24a18b4cadbe0e4b
> src/site/apt/user/cli.apt bd394972790792905cb21dd0da5894840f404d8e
>
> Diff: https://reviews.apache.org/r/33976/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.818s]
> [INFO] Lens .............................................. SUCCESS [3.293s]
> [INFO] Lens API .......................................... SUCCESS [20.626s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.116s]
> [INFO] Lens Cube ......................................... SUCCESS [3:30.556s]
> [INFO] Lens DB storage ................................... SUCCESS [21.408s]
> [INFO] Lens Query Library ................................ SUCCESS [15.581s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:56.842s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [37.111s]
> [INFO] Lens Server ....................................... SUCCESS [5:22.697s]
> [INFO] Lens client ....................................... SUCCESS [37.577s]
> [INFO] Lens CLI .......................................... SUCCESS [3:18.496s]
> [INFO] Lens Examples ..................................... SUCCESS [9.647s]
> [INFO] Lens Distribution ................................. SUCCESS [8.324s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.860s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.076s]
> [INFO] Lens Regression ................................... SUCCESS [8.223s]
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 33976: LENS-26: option to download result into a
file
Posted by Jaideep dhok <ja...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33976/#review84267
-----------------------------------------------------------
Can you add a unit test to check if output gets written to file? We can have an expected result file and match contents against it.
- Jaideep dhok
On May 18, 2015, 12:57 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33976/
> -----------------------------------------------------------
>
> (Updated May 18, 2015, 12:57 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-26
> https://issues.apache.org/jira/browse/LENS-26
>
>
> Repository: lens
>
>
> Description
> -------
>
> option to download result into a file
>
>
> Diffs
> -----
>
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java 8707fec5612a04e9a07ed9d5e38f342ef1f9114e
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 05922e394e5fea9e95e67d56d04697ebf438f48d
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDStoragePartitionCommand.java 0d53e2107be116d4dbb855f247b57be0c1b97691
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 64e9ca47c5c7df444cdd16b2d55bc738d6c945bc
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java d7b63724f50dc392a5440ce8362b4eb6ca81f885
> lens-client/src/main/java/org/apache/lens/client/LensClient.java 016e4ab1285582760b5da47b355402b747ea78e8
> lens-client/src/main/java/org/apache/lens/client/LensStatement.java 5ce3a82926ed2bad6f29300d24a18b4cadbe0e4b
> src/site/apt/user/cli.apt bd394972790792905cb21dd0da5894840f404d8e
>
> Diff: https://reviews.apache.org/r/33976/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.818s]
> [INFO] Lens .............................................. SUCCESS [3.293s]
> [INFO] Lens API .......................................... SUCCESS [20.626s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.116s]
> [INFO] Lens Cube ......................................... SUCCESS [3:30.556s]
> [INFO] Lens DB storage ................................... SUCCESS [21.408s]
> [INFO] Lens Query Library ................................ SUCCESS [15.581s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:56.842s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [37.111s]
> [INFO] Lens Server ....................................... SUCCESS [5:22.697s]
> [INFO] Lens client ....................................... SUCCESS [37.577s]
> [INFO] Lens CLI .......................................... SUCCESS [3:18.496s]
> [INFO] Lens Examples ..................................... SUCCESS [9.647s]
> [INFO] Lens Distribution ................................. SUCCESS [8.324s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.860s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.076s]
> [INFO] Lens Regression ................................... SUCCESS [8.223s]
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 33976: LENS-26: option to download result into a
file
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33976/
-----------------------------------------------------------
(Updated May 18, 2015, 6:27 p.m.)
Review request for lens.
Bugs: LENS-26
https://issues.apache.org/jira/browse/LENS-26
Repository: lens
Description
-------
option to download result into a file
Diffs (updated)
-----
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java 8707fec5612a04e9a07ed9d5e38f342ef1f9114e
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 05922e394e5fea9e95e67d56d04697ebf438f48d
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDStoragePartitionCommand.java 0d53e2107be116d4dbb855f247b57be0c1b97691
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 64e9ca47c5c7df444cdd16b2d55bc738d6c945bc
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java d7b63724f50dc392a5440ce8362b4eb6ca81f885
lens-client/src/main/java/org/apache/lens/client/LensClient.java 016e4ab1285582760b5da47b355402b747ea78e8
lens-client/src/main/java/org/apache/lens/client/LensStatement.java 5ce3a82926ed2bad6f29300d24a18b4cadbe0e4b
src/site/apt/user/cli.apt bd394972790792905cb21dd0da5894840f404d8e
Diff: https://reviews.apache.org/r/33976/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.818s]
[INFO] Lens .............................................. SUCCESS [3.293s]
[INFO] Lens API .......................................... SUCCESS [20.626s]
[INFO] Lens API for server and extensions ................ SUCCESS [21.116s]
[INFO] Lens Cube ......................................... SUCCESS [3:30.556s]
[INFO] Lens DB storage ................................... SUCCESS [21.408s]
[INFO] Lens Query Library ................................ SUCCESS [15.581s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:56.842s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [37.111s]
[INFO] Lens Server ....................................... SUCCESS [5:22.697s]
[INFO] Lens client ....................................... SUCCESS [37.577s]
[INFO] Lens CLI .......................................... SUCCESS [3:18.496s]
[INFO] Lens Examples ..................................... SUCCESS [9.647s]
[INFO] Lens Distribution ................................. SUCCESS [8.324s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:21.860s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.076s]
[INFO] Lens Regression ................................... SUCCESS [8.223s]
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 33976: LENS-26: option to download result into a
file
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33976/
-----------------------------------------------------------
(Updated May 18, 2015, 1:53 p.m.)
Review request for lens.
Bugs: LENS-26
https://issues.apache.org/jira/browse/LENS-26
Repository: lens
Description
-------
option to download result into a file
Diffs (updated)
-----
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java 8707fec5612a04e9a07ed9d5e38f342ef1f9114e
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 05922e394e5fea9e95e67d56d04697ebf438f48d
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDStoragePartitionCommand.java 0d53e2107be116d4dbb855f247b57be0c1b97691
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 64e9ca47c5c7df444cdd16b2d55bc738d6c945bc
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java d7b63724f50dc392a5440ce8362b4eb6ca81f885
lens-client/src/main/java/org/apache/lens/client/LensClient.java 016e4ab1285582760b5da47b355402b747ea78e8
lens-client/src/main/java/org/apache/lens/client/LensStatement.java 5ce3a82926ed2bad6f29300d24a18b4cadbe0e4b
src/site/apt/user/cli.apt bd394972790792905cb21dd0da5894840f404d8e
Diff: https://reviews.apache.org/r/33976/diff/
Testing
-------
None
Thanks,
Rajat Khandelwal
Re: Review Request 33976: LENS-26: option to download result into a
file
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33976/
-----------------------------------------------------------
(Updated May 14, 2015, 6:46 p.m.)
Review request for lens.
Bugs: LENS-26
https://issues.apache.org/jira/browse/LENS-26
Repository: lens
Description
-------
option to download result into a file
Diffs (updated)
-----
.reviewboardrc e9a57e0693039fa44aa3fb9822563b5c1c8191b0
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java 8707fec5612a04e9a07ed9d5e38f342ef1f9114e
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 05922e394e5fea9e95e67d56d04697ebf438f48d
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDStoragePartitionCommand.java 0d53e2107be116d4dbb855f247b57be0c1b97691
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 64e9ca47c5c7df444cdd16b2d55bc738d6c945bc
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java d7b63724f50dc392a5440ce8362b4eb6ca81f885
lens-client/src/main/java/org/apache/lens/client/LensClient.java 016e4ab1285582760b5da47b355402b747ea78e8
lens-client/src/main/java/org/apache/lens/client/LensStatement.java 5ce3a82926ed2bad6f29300d24a18b4cadbe0e4b
src/site/apt/user/cli.apt bd394972790792905cb21dd0da5894840f404d8e
Diff: https://reviews.apache.org/r/33976/diff/
Testing
-------
None
Thanks,
Rajat Khandelwal
Re: Review Request 33976: LENS-26: option to download result into a
file
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33976/
-----------------------------------------------------------
(Updated May 12, 2015, 7:29 p.m.)
Review request for lens.
Bugs: LENS-26
https://issues.apache.org/jira/browse/LENS-26
Repository: lens
Description
-------
option to download result into a file
Diffs (updated)
-----
.reviewboardrc e9a57e0
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c0616d2
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java d7b6372
src/site/apt/user/cli.apt cbbc3eb
Diff: https://reviews.apache.org/r/33976/diff/
Testing (updated)
-------
None
Thanks,
Rajat Khandelwal