[GitHub] [flink] AHeise commented on pull request #19514: [FLINK-27308][Filesystem][S3] Update the Hadoop implementation for filesystems to 3.3.2

[GitBox <gi...@apache.org>]

AHeise commented on PR #19514:
URL: https://github.com/apache/flink/pull/19514#issuecomment-1108489833

   > I think I know the reason for the failing test, this is something we have fixed in our internal build by adding commons-compress (https://mvnrepository.com/artifact/org.apache.commons/commons-compress/1.21) to the flink-s3-fs-hadoop pom.xml since it is being excluded in the hadoop import.
   
   Okay this one is probably on me. I excluded that back when we removed shading. The basic idea is that we already have common-compress in flink-core and with it in flink-dist. However, I goofed up because plugins do only have access to `org.apache.flink` classes. 
   
   It probably works if you put it in `lib/` but then we can't easily upgrade Hadoop - one of the motivations for fs plugins. It's also fair to replicate the jar in flink-dist and in s3 plugin as we can independently upgrade the version if needed.
   
   So thanks for fixing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org