You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/07/16 04:20:06 UTC

[GitHub] [phoenix] yanxinyi commented on a change in pull request #830: PHOENIX-6013 RVC Offset does not handle coerced literal nulls properly

yanxinyi commented on a change in pull request #830:
URL: https://github.com/apache/phoenix/pull/830#discussion_r455500807



##########
File path: phoenix-core/src/main/java/org/apache/phoenix/compile/RVCOffsetCompiler.java
##########
@@ -283,19 +276,34 @@ public CompiledOffset getRVCOffset(StatementContext context, FilterableStatement
         return compiledOffset;
     }
 
-    @VisibleForTesting List<RowKeyColumnExpression> buildListOfRowKeyColumnExpressions(
-            List<Expression> expressions, boolean isIndex)
-            throws RowValueConstructorOffsetNotCoercibleException {
+    @VisibleForTesting
+    List<RowKeyColumnExpression> buildListOfRowKeyColumnExpressions (
+            Expression whereExpression, boolean isIndex)
+            throws RowValueConstructorOffsetNotCoercibleException, RowValueConstructorOffsetInternalErrorException {
+
+        List<Expression> expressions;
+        if((whereExpression instanceof  AndExpression)) {

Review comment:
       nit: two spaces




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org