You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2022/03/12 04:14:50 UTC

[GitHub] [thrift] kainjow commented on a change in pull request #2523: THRIFT-5139: THRIFT-4181: Python3 type hints

kainjow commented on a change in pull request #2523:
URL: https://github.com/apache/thrift/pull/2523#discussion_r825244144



##########
File path: compiler/cpp/src/thrift/generate/t_py_generator.cc
##########
@@ -2839,4 +2927,5 @@ THRIFT_REGISTER_GENERATOR(
     "                     Package prefix for generated files.\n"
     "    old_style:       Deprecated. Generate old-style classes.\n"
     "    enum:            Generates Python's IntEnum, connects thrift to python enums. Python 3.4 and higher.\n"
+    "    type_hints:        Generate type hints and type checks in write method.\n"

Review comment:
       nit: can you make the spacing line up?
   ```suggestion
       "    type_hints:      Generate type hints and type checks in write method.\n"
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org