You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/05/05 01:35:27 UTC
[GitHub] [druid] gianm opened a new pull request #11199: Fix vectorized cardinality bug on certain string columns.
gianm opened a new pull request #11199:
URL: https://github.com/apache/druid/pull/11199
Fixes a bug introduced in #11182, related to the fact that in some cases,
ColumnProcessors.makeVectorProcessor will call "makeObjectProcessor"
instead of "makeSingleValueDimensionProcessor" or
"makeMultiValueDimensionProcessor". CardinalityVectorProcessorFactory
improperly ignored calls to "makeObjectProcessor".
In addition to fixing the bug, I added this detail to the javadocs for
VectorColumnProcessorFactory, to prevent others from running into the
same thing in the future. They do not currently call out this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis commented on a change in pull request #11199: Fix vectorized cardinality bug on certain string columns.
Posted by GitBox <gi...@apache.org>.
clintropolis commented on a change in pull request #11199:
URL: https://github.com/apache/druid/pull/11199#discussion_r628061017
##########
File path: processing/src/main/java/org/apache/druid/segment/VectorColumnProcessorFactory.java
##########
@@ -41,17 +41,25 @@
public interface VectorColumnProcessorFactory<T>
{
/**
- * Called when {@link ColumnCapabilities#getType()} is STRING and the underlying column always has a single value
+ * Called only if {@link ColumnCapabilities#getType()} is STRING and the underlying column always has a single value
Review comment:
woops, I guess I only fixed up docs for `VectorColumnSelectorFactory` in #10613, should've done these too, my bad
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] gianm merged pull request #11199: Fix vectorized cardinality bug on certain string columns.
Posted by GitBox <gi...@apache.org>.
gianm merged pull request #11199:
URL: https://github.com/apache/druid/pull/11199
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org