You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/06/02 02:57:44 UTC
[GitHub] [superset] Renderz opened a new pull request, #20237: fix(cosmetic): Fix Datasource Modal Out Of Box
Renderz opened a new pull request, #20237:
URL: https://github.com/apache/superset/pull/20237
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
remove 'overflow: visible' from DatasourceModal component, to fit with the height limit, and show the scrollbar.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
Before
After
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: [Fixed #20236](https://github.com/apache/superset/issues/20236)
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #20237: fix(cosmetic): Fix Datasource Modal Out Of Box
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #20237:
URL: https://github.com/apache/superset/pull/20237#issuecomment-1145599588
# [Codecov](https://codecov.io/gh/apache/superset/pull/20237?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#20237](https://codecov.io/gh/apache/superset/pull/20237?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (948b641) into [master](https://codecov.io/gh/apache/superset/commit/e5f26313a59a2e9c7cb8a27c8060a325b06fc285?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e5f2631) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #20237 +/- ##
=======================================
Coverage 66.50% 66.50%
=======================================
Files 1726 1726
Lines 64790 64790
Branches 6829 6829
=======================================
Hits 43087 43087
Misses 19967 19967
Partials 1736 1736
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.33% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/20237?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...tend/src/components/Datasource/DatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/20237/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YXNvdXJjZS9EYXRhc291cmNlTW9kYWwudHN4) | `69.04% <ø> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/20237?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/20237?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e5f2631...948b641](https://codecov.io/gh/apache/superset/pull/20237?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] stephenLYZ commented on pull request #20237: fix(cosmetic): Fix Datasource Modal Out Of Box
Posted by GitBox <gi...@apache.org>.
stephenLYZ commented on PR #20237:
URL: https://github.com/apache/superset/pull/20237#issuecomment-1145007779
Thanks for the contribution! Actually this css snippet can be found in the context of this [issue](https://github.com/apache/superset/pull/13858), so we probably can't remove it easily, but if we verify that the issue is working correctly, I think it's okay to remove it. I think the problem is probably related to this [issue](https://github.com/apache/superset/pull/20147/files#diff-8681971330bf64f19cbbe547d528fe0f78b56787224726fc4d6f2ab4bf31bb47R99). cc @rusackas
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #20237: fix(cosmetic): Fix Datasource Modal Out Of Box
Posted by GitBox <gi...@apache.org>.
rusackas commented on PR #20237:
URL: https://github.com/apache/superset/pull/20237#issuecomment-1145598223
Looked at the other two modals that allow overflow, and they don't seem so problematic. I think this fix is the better way forward than the revert, but I'll let it simmer for a moment for discussion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #20237: fix(cosmetic): Fix Datasource Modal Out Of Box
Posted by GitBox <gi...@apache.org>.
rusackas commented on PR #20237:
URL: https://github.com/apache/superset/pull/20237#issuecomment-1145595351
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Renderz commented on pull request #20237: fix(cosmetic): Fix Datasource Modal Out Of Box
Posted by GitBox <gi...@apache.org>.
Renderz commented on PR #20237:
URL: https://github.com/apache/superset/pull/20237#issuecomment-1145550593
> Thanks for the contribution! Actually this css snippet can be found in the context of this [issue](https://github.com/apache/superset/pull/13858), so we probably can't remove it easily, but if we verify that the issue is working correctly, I think it's okay to remove it. I think the problem is probably related to this [issue](https://github.com/apache/superset/pull/20147/files#diff-8681971330bf64f19cbbe547d528fe0f78b56787224726fc4d6f2ab4bf31bb47R99), which is about maxHeight of the modal. cc @rusackas
Thanks for reviewing.
I think other modals may facing the same issue(when actual height is more than max height).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #20237: fix(cosmetic): Fix Datasource Modal Out Of Box
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #20237:
URL: https://github.com/apache/superset/pull/20237#issuecomment-1145596272
@rusackas Ephemeral environment spinning up at http://34.221.129.77:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #20237: fix(cosmetic): Fix Datasource Modal Out Of Box
Posted by GitBox <gi...@apache.org>.
rusackas commented on PR #20237:
URL: https://github.com/apache/superset/pull/20237#issuecomment-1145595276
FWIW, when I run this locally, I'm not seeing the issue that @AAfghahi was tackling in his earlier PR, but I'm spinning up an ephemeral environment, and pinging him for a review, just in case :)
<img width="583" alt="image" src="https://user-images.githubusercontent.com/812905/171791516-77f17eb5-b3f0-44a9-84e7-74ce7d95c742.png">
<img width="513" alt="image" src="https://user-images.githubusercontent.com/812905/171791573-9ef59642-588f-462c-8de8-c99f6fa43fd5.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #20237: fix(cosmetic): Fix Datasource Modal Out Of Box
Posted by GitBox <gi...@apache.org>.
rusackas merged PR #20237:
URL: https://github.com/apache/superset/pull/20237
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #20237: fix(cosmetic): Fix Datasource Modal Out Of Box
Posted by GitBox <gi...@apache.org>.
rusackas commented on PR #20237:
URL: https://github.com/apache/superset/pull/20237#issuecomment-1145995216
Thanks for fixing this. The Save Chart modal has overflow visible, but looks OK since it's short. Same with the Dashboard's Refresh Interval Modal. We can do this same fix on either, but it makes matters _worse_ on the Refresh Interval modal. If you do this fix on the Save Chart modal, it works fine, but looks a bit goofy as the bottom Select menu goes upward to cover the Input above it. I'll leave them both alone, but I'm open to ideas/consideration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #20237: fix(cosmetic): Fix Datasource Modal Out Of Box
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #20237:
URL: https://github.com/apache/superset/pull/20237#issuecomment-1145993431
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org