[GitHub] [solr] risdenk commented on a diff in pull request #1443: SOLR-16676: Test improvements

["risdenk (via GitHub)" <gi...@apache.org>]

risdenk commented on code in PR #1443:
URL: https://github.com/apache/solr/pull/1443#discussion_r1129840310


##########
solr/core/src/test/org/apache/solr/handler/TestHttpRequestId.java:
##########
@@ -126,7 +116,7 @@ public void onFailure(Throwable throwable) {
       assertEquals(3, reqLog.getQueue().size());
       while (!reqLog.getQueue().isEmpty()) {
         var reqEvent = reqLog.getQueue().poll();
-        assertTrue(reqEvent.getContextData().containsKey(key));
+        assertNotNull(reqEvent);

Review Comment:
   Fixed in 117960e0d521c18ce48a7f2b520a65a0eab4870b



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org