You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/08/25 12:14:18 UTC

[GitHub] [skywalking] mikhail-dr commented on issue #7556: [INFRA] License text from .licenserc.yaml should be taken as-is by skywaking-eyes

mikhail-dr commented on issue #7556:
URL: https://github.com/apache/skywalking/issues/7556#issuecomment-905446584


   thanks, @kezhenxu94 . However, now the tool is adding an _extra_ empty line after the copyright notice. I think this is because you changed the following line https://github.com/apache/skywalking-eyes/blob/1e5ec5bb1e827531f5b540f5bdbf668ecf925cad/pkg/header/fix.go#L122 but you also need to remove the extra ```\n``` that is added there. It was needed previously, but with your latest change, I think you also need to remove that new line. thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org