You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by SerCeMan <gi...@git.apache.org> on 2017/10/19 01:31:36 UTC
[GitHub] lucene-solr pull request #264: Fix NPE on connection failure
GitHub user SerCeMan opened a pull request:
https://github.com/apache/lucene-solr/pull/264
Fix NPE on connection failure
We're using ZK for node discovery. During rare evens of when some nodes are unavailable, we observe NPEs. I'm not quite familiar with the solr client logic but by looking at the code further, I concluded that the iteration misses a null check.
```java
java.lang.NullPointerException: null
at org.apache.solr.client.solrj.impl.CloudSolrClient.requestWithRetryOnStaleState(CloudSolrClient.java:1143)
at org.apache.solr.client.solrj.impl.CloudSolrClient.request(CloudSolrClient.java:1037)
at org.apache.solr.client.solrj.SolrRequest.process(SolrRequest.java:149)
at org.apache.solr.client.solrj.SolrClient.query(SolrClient.java:974)
at org.apache.solr.client.solrj.SolrClient.query(SolrClient.java:990)
at com.canva.search.SolrQueryServiceImpl.query(SolrQueryServiceImpl.java:65)
at com.canva.search.SolrQueryServiceImpl.query(SolrQueryServiceImpl.java:50)
at com.canva.search.server.SearchServiceServer.searchMedia(SearchServiceServer.java:358)
at com.canva.search.server.FinagleSearchServer.searchMedia(FinagleSearchServer.java:97)
at com.canva.search.server.FinagleSearchServer.doApply(FinagleSearchServer.java:63)
at com.canva.http.AbstractFinagleServer.doApply0(AbstractFinagleServer.java:321)
at com.canva.http.AbstractFinagleServer.lambda$apply$1(AbstractFinagleServer.java:279)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SerCeMan/lucene-solr patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/264.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #264
----
commit 093e63533bc71c1e7c65709d05746b7d7b1a0a13
Author: Sergey Tselovalnikov <se...@gmail.com>
Date: 2017-10-19T01:25:50Z
Fix NPE on connection failure
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #264: Fix NPE on connection failure
Posted by SerCeMan <gi...@git.apache.org>.
Github user SerCeMan commented on the issue:
https://github.com/apache/lucene-solr/pull/264
Hey, @jpountz!
Could you take a look at this? It's a minor change, but it would make our logs much cleaner.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #264: Fix NPE on connection failure
Posted by tflobbe <gi...@git.apache.org>.
Github user tflobbe commented on the issue:
https://github.com/apache/lucene-solr/pull/264
I believe this is the same as reported in SOLR-11620
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #264: Fix NPE on connection failure
Posted by SerCeMan <gi...@git.apache.org>.
Github user SerCeMan closed the pull request at:
https://github.com/apache/lucene-solr/pull/264
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #264: Fix NPE on connection failure
Posted by SerCeMan <gi...@git.apache.org>.
Github user SerCeMan commented on the issue:
https://github.com/apache/lucene-solr/pull/264
Closing as this might be fixed by https://issues.apache.org/jira/browse/SOLR-11484
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org