You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/03/30 04:20:28 UTC
[GitHub] [incubator-hudi] leesf commented on issue #1465: [HUDI-746]: Reduce
build warnings < 10
leesf commented on issue #1465: [HUDI-746]: Reduce build warnings < 10
URL: https://github.com/apache/incubator-hudi/pull/1465#issuecomment-605773685
> @leesf quick clarification.. if we refactor / touch more classes, then the import order warning will keep recurring? I wonder, if we should remove/comment that completely from checkstyle.. there is no point in having something we are not enforcing.. thoughts?
In fact, the ImportOrder rule severity is info(https://github.com/apache/incubator-hudi/blob/master/style/checkstyle.xml#L283), and we should not get the warning when building. We firstly set the severity to error, but need to adjust import order manually, which is really tedious, and after discussion in ML, then we set the severity to info, see commit(4b1b3fc28cc68c61e2042029a80211dcbe0fcfb4).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services