You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/09/15 08:41:32 UTC
[GitHub] [rocketmq] maixiaohai opened a new pull request #2301: [ISSUE #2300] Enhancement: Benchmark support acl and msg trace
maixiaohai opened a new pull request #2301:
URL: https://github.com/apache/rocketmq/pull/2301
## What is the purpose of the change
Issue #2300
## Brief changelog
1.add support for acl
2.add msgTraceEnabled option for producer and consumer
3.fix Algorithm HmacSHA1 not available using openjdk
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin merged pull request #2301: [ISSUE #2300] Enhancement: Benchmark support acl and msg trace
Posted by GitBox <gi...@apache.org>.
RongtongJin merged pull request #2301:
URL: https://github.com/apache/rocketmq/pull/2301
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls edited a comment on pull request #2301: [ISSUE #2300] Enhancement: Benchmark support acl and msg trace
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #2301:
URL: https://github.com/apache/rocketmq/pull/2301#issuecomment-692595648
[](https://coveralls.io/builds/33498333)
Coverage decreased (-0.1%) to 51.192% when pulling **9105d620504d5e274d396675565e27598ddc34e7 on maixiaohai:benchmark_support_acl_and_msg_trace** into **2a8ba5a79935ab0a23646455427647ebd57d9e07 on apache:develop**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] maixiaohai commented on a change in pull request #2301: [ISSUE #2300] Enhancement: Benchmark support acl and msg trace
Posted by GitBox <gi...@apache.org>.
maixiaohai commented on a change in pull request #2301:
URL: https://github.com/apache/rocketmq/pull/2301#discussion_r489315350
##########
File path: example/src/main/java/org/apache/rocketmq/example/benchmark/Consumer.java
##########
@@ -111,7 +113,7 @@ public void run() {
}
}, 10000, 10000);
- DefaultMQPushConsumer consumer = new DefaultMQPushConsumer(group);
+ DefaultMQPushConsumer consumer = new DefaultMQPushConsumer(group, AclClient.getAclRPCHook(), new AllocateMessageQueueAveragely(), msgTraceEnable, null);
Review comment:
@RongtongJin I‘ve fixed it, pls review it~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin merged pull request #2301: [ISSUE #2300] Enhancement: Benchmark support acl and msg trace
Posted by GitBox <gi...@apache.org>.
RongtongJin merged pull request #2301:
URL: https://github.com/apache/rocketmq/pull/2301
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] maixiaohai commented on a change in pull request #2301: [ISSUE #2300] Enhancement: Benchmark support acl and msg trace
Posted by GitBox <gi...@apache.org>.
maixiaohai commented on a change in pull request #2301:
URL: https://github.com/apache/rocketmq/pull/2301#discussion_r489197163
##########
File path: example/src/main/java/org/apache/rocketmq/example/benchmark/Consumer.java
##########
@@ -111,7 +113,7 @@ public void run() {
}
}, 10000, 10000);
- DefaultMQPushConsumer consumer = new DefaultMQPushConsumer(group);
+ DefaultMQPushConsumer consumer = new DefaultMQPushConsumer(group, AclClient.getAclRPCHook(), new AllocateMessageQueueAveragely(), msgTraceEnable, null);
Review comment:
OK, I will fix it ASAP.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #2301: [ISSUE #2300] Enhancement: Benchmark support acl and msg trace
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #2301:
URL: https://github.com/apache/rocketmq/pull/2301#issuecomment-692595648
[](https://coveralls.io/builds/33468433)
Coverage decreased (-0.07%) to 51.227% when pulling **b31aa7403b5587cb406f50beb514eafa3c6cb4ba on maixiaohai:benchmark_support_acl_and_msg_trace** into **2a8ba5a79935ab0a23646455427647ebd57d9e07 on apache:develop**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin commented on a change in pull request #2301: [ISSUE #2300] Enhancement: Benchmark support acl and msg trace
Posted by GitBox <gi...@apache.org>.
RongtongJin commented on a change in pull request #2301:
URL: https://github.com/apache/rocketmq/pull/2301#discussion_r489184938
##########
File path: example/src/main/java/org/apache/rocketmq/example/benchmark/Consumer.java
##########
@@ -111,7 +113,7 @@ public void run() {
}
}, 10000, 10000);
- DefaultMQPushConsumer consumer = new DefaultMQPushConsumer(group);
+ DefaultMQPushConsumer consumer = new DefaultMQPushConsumer(group, AclClient.getAclRPCHook(), new AllocateMessageQueueAveragely(), msgTraceEnable, null);
Review comment:
You need to maintain compatibility and let users choose whether to use ACL instead of forcing users to use ACL.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org