You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2023/01/17 20:46:38 UTC
[GitHub] [beam] AnandInguva opened a new pull request, #25045: Update/add torch versions to tox.init
AnandInguva opened a new pull request, #25045:
URL: https://github.com/apache/beam/pull/25045
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on pull request #25045: Update/add torch versions to tox.ini
Posted by GitBox <gi...@apache.org>.
AnandInguva commented on PR #25045:
URL: https://github.com/apache/beam/pull/25045#issuecomment-1386091165
R : @damccorm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #25045: Update/add torch versions to tox.ini
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #25045:
URL: https://github.com/apache/beam/pull/25045#discussion_r1073608275
##########
sdks/python/tox.ini:
##########
@@ -319,6 +319,9 @@ deps =
-r build-requirements.txt
19: torch>=1.9.0,<1.10.0
110: torch>=1.10.0,<1.11.0
+ 111: torch>=1.11.0,<1.12.0
+ 112: torch>=1.12.0,<1.13.0
+ 113: torch>=1.13.0,<1.14.0
Review Comment:
In order for this to work, I think we need to:
1) Add more versions like this - https://github.com/apache/beam/blob/55d8ecb2584e711f8c382f71a7fca39b86a89e67/sdks/python/test-suites/tox/py38/build.gradle#L112
2) Update line 317 to be `[testenv:py{37,38,39,310}-pytorch-{19,110,111,112,113}]`
Right now, these tests aren't getting run as part of the precommit - https://ci-beam.apache.org/job/beam_PreCommit_Python_Commit/26635/consoleFull
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #25045: Update/add torch versions to tox.ini
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #25045:
URL: https://github.com/apache/beam/pull/25045#issuecomment-1386115024
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @tvalentyn for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on a diff in pull request #25045: Update/add torch versions to tox.ini
Posted by GitBox <gi...@apache.org>.
AnandInguva commented on code in PR #25045:
URL: https://github.com/apache/beam/pull/25045#discussion_r1073951454
##########
sdks/python/tox.ini:
##########
@@ -319,6 +319,9 @@ deps =
-r build-requirements.txt
19: torch>=1.9.0,<1.10.0
110: torch>=1.10.0,<1.11.0
+ 111: torch>=1.11.0,<1.12.0
+ 112: torch>=1.12.0,<1.13.0
+ 113: torch>=1.13.0,<1.14.0
Review Comment:
Thanks. I will update them in some time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #25045: Update/add torch versions to tox.ini
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #25045:
URL: https://github.com/apache/beam/pull/25045#discussion_r1085491813
##########
sdks/python/test-suites/tox/py38/build.gradle:
##########
@@ -113,6 +113,18 @@ toxTask "testPy38pytorch-110", "py38-pytorch-110", "${posargs}"
test.dependsOn "testPy38pytorch-110"
preCommitPy38.dependsOn "testPy38pytorch-110"
+toxTask "testPy38pytorch-111", "py38-pytorch-111", "${posargs}"
+test.dependsOn "testPy38pytorch-111"
+preCommitPy38.dependsOn "testPy38pytorch-111"
+
+toxTask "testPy38pytorch-112", "py38-pytorch-112", "${posargs}"
+test.dependsOn "testPy38pytorch-112"
+preCommitPy38.dependsOn "testPy38pytorch-112"
+
+toxTask "testPy38pytorch-113", "py38-pytorch-113", "${posargs}"
+test.dependsOn "testPy38pytorch-113"
+preCommitPy38.dependsOn "testPy38pytorch-113"
Review Comment:
```suggestion
preCommitPyCoverage.dependsOn "testPy38pytorch-111"
toxTask "testPy38pytorch-112", "py38-pytorch-112", "${posargs}"
test.dependsOn "testPy38pytorch-112"
preCommitPyCoverage.dependsOn "testPy38pytorch-112"
toxTask "testPy38pytorch-113", "py38-pytorch-113", "${posargs}"
test.dependsOn "testPy38pytorch-113"
preCommitPyCoverage.dependsOn "testPy38pytorch-113"
```
These were generally updated in https://github.com/apache/beam/commit/b3aa2e89489898f8c760294ba4dba2310ac53e70
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #25045: Update/add torch versions to tox.ini
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #25045:
URL: https://github.com/apache/beam/pull/25045#issuecomment-1386049512
# [Codecov](https://codecov.io/gh/apache/beam/pull/25045?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#25045](https://codecov.io/gh/apache/beam/pull/25045?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bda9efb) into [master](https://codecov.io/gh/apache/beam/commit/5a2a3a4dfb26b7e8a7f2b132e1913fb4504216b2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5a2a3a4) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #25045 +/- ##
=======================================
Coverage 73.12% 73.12%
=======================================
Files 735 735
Lines 98151 98151
=======================================
Hits 71774 71774
Misses 25013 25013
Partials 1364 1364
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on pull request #25045: Update/add torch versions to tox.ini
Posted by "AnandInguva (via GitHub)" <gi...@apache.org>.
AnandInguva commented on PR #25045:
URL: https://github.com/apache/beam/pull/25045#issuecomment-1398929799
> Details
3 minutes.
It went from 31 minutes to 34 minutes for this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #25045: Update/add torch versions to tox.ini
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on PR #25045:
URL: https://github.com/apache/beam/pull/25045#issuecomment-1399073226
No comments from me, I'll let @damccorm merge to make sure his comments were addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on pull request #25045: Update/add torch versions to tox.ini
Posted by "AnandInguva (via GitHub)" <gi...@apache.org>.
AnandInguva commented on PR #25045:
URL: https://github.com/apache/beam/pull/25045#issuecomment-1399070814
@tvalentyn PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm merged pull request #25045: Update/add torch versions to tox.ini
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm merged PR #25045:
URL: https://github.com/apache/beam/pull/25045
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #25045: Update/add torch versions to tox.ini
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on PR #25045:
URL: https://github.com/apache/beam/pull/25045#issuecomment-1386181941
What is the impact of this change on precommit runtime?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org